[Bug testsuite/59897] New: FAIL: c-c++-common/asan/use-after-return-1.c -O* output pattern test, is 1: 0x2285020

[Bug testsuite/59897] New: FAIL: c-c++-common/asan/use-after-return-1.c -O* output pattern test, is 1: 0x2285020

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59897

            Bug ID: 59897
           Summary: FAIL: c-c++-common/asan/use-after-return-1.c  -O*
                    output pattern test, is 1: 0x2285020
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dominiq at lps dot ens.fr
                CC: chefmax at gcc dot gnu.org, howarth at bromo dot med.uc.edu,
                    iains at gcc dot gnu.org
              Host: x86_64-apple-darwin1*
            Target: x86_64-apple-darwin1*
             Build: x86_64-apple-darwin1*

On x86_64-apple-darwin1* the test c-c++-common/asan/use-after-return-1.c (new
at r206458) fails because the regexp "    #0.*Func2.*use-after-return-1.c:31.*"
is not matched by the output. AFAICT this output requires addr2line and the
test will fail on all targets which does not have it, e.g. darwin. I have
silenced the failure with the following patch:

--- ../_clean/gcc/testsuite/c-c++-common/asan/use-after-return-1.c   
2014-01-09 10:14:04.000000000 +0100
+++ gcc/testsuite/c-c++-common/asan/use-after-return-1.c    2014-01-09
15:51:04.000000000 +0100
@@ -48,6 +48,6 @@ int main(int argc, char **argv) {
 }

 /* { dg-output "WRITE of size 1 at .* thread T0.*" } */
-/* { dg-output "    #0.*Func2.*use-after-return-1.c:31.*" } */
+/* { dg-output "    #0.*(Func2)?.*use-after-return-1.(c:31)?.*" } */
 /* { dg-output "is located in stack of thread T0 at offset.*" } */
 /* { dg-output "\'local\' <== Memory access at offset 32 is inside this
variable" } */

but there is probably a better way to do it.

[Bug testsuite/59897] FAIL: c-c++-common/asan/use-after-return-1.c -O* output pattern test, is 1: 0x2285020

[y.gribov at samsung dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59897

Yury Gribov <y.gribov at samsung dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |y.gribov at samsung dot com

--- Comment #1 from Yury Gribov <y.gribov at samsung dot com> ---
Looks like we do more or less the same for all other Asan tests.

[Bug testsuite/59897] FAIL: c-c++-common/asan/use-after-return-1.c -O* output pattern test, is 1: 0x2285020

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59897

--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> Looks like we do more or less the same for all other Asan tests.

Could you please explicit the "more or less"?

AFACT "    #0.*Func2.*use-after-return-1.c:31.*" is generated by addr2line and
is not present for darwin.

[Bug testsuite/59897] FAIL: c-c++-common/asan/use-after-return-1.c -O* output pattern test, is 1: 0x2285020

[y.gribov at samsung dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59897

--- Comment #3 from Yury Gribov <y.gribov at samsung dot com> ---
(In reply to Dominique d'Humieres from comment #2)
> Could you please explicit the "more or less"?

We also ignore function names / line info but use slightly different regexp.
Here's an example for strncpy-overflow-1.c:

/* { dg-output "    #0 0x\[0-9a-f\]+ (in
_*(interceptor_|)strncpy|\[(\])\[^\n\r]*(\n|\r\n|\r)" } */

[Bug testsuite/59897] FAIL: c-c++-common/asan/use-after-return-1.c -O* output pattern test, is 1: 0x2285020

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59897

--- Comment #4 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> We also ignore function names / line info but use slightly different regexp. ...

All the other asan tests pass on darwin (except strncpy-overflow-1.c at -O0,
pr59148). Only use-after-return-1.c fails due to the strings 'Func2' and
'c:31'.

[Bug testsuite/59897] FAIL: c-c++-common/asan/use-after-return-1.c -O* output pattern test, is 1: 0x2285020

[chefmax at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59897

--- Comment #5 from chefmax at gcc dot gnu.org ---
Author: chefmax
Date: Thu Jan 23 12:48:25 2014
New Revision: 206961

URL: http://gcc.gnu.org/viewcvs?rev=206961&root=gcc&view=rev
Log:
2014-01-23  Dominique Dhumieres  <dominiq@lps.ens.fr>

        PR sanitizer/59897
        * c-c++-common/asan/use-after-return-1.c: Fixed
        to pass on darwin.

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/c-c++-common/asan/use-after-return-1.c

[Bug testsuite/59897] FAIL: c-c++-common/asan/use-after-return-1.c -O* output pattern test, is 1: 0x2285020

[y.gribov at samsung dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59897

--- Comment #6 from Yury Gribov <y.gribov at samsung dot com> ---
Dominique, please check and close if it works for you.

[Bug testsuite/59897] FAIL: c-c++-common/asan/use-after-return-1.c -O* output pattern test, is 1: 0x2285020

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59897

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> Dominique, please check and close if it works for you.

Done! Thanks for the commit.