public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "glisse at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug ipa/59948] Optimize std::function Date: Fri, 02 May 2014 14:06:00 -0000 [thread overview] Message-ID: <bug-59948-4-ASwhHM9DZw@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-59948-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59948 --- Comment #5 from Marc Glisse <glisse at gcc dot gnu.org> --- (In reply to Jan Hubicka from comment #3) > The code in fold-const for nonzero check is really broken. I have somewerhe > WIP symtab patch for doing this, but it is not completely trivial to hook it > into fold-const when symtab is not built yet - just as in this case and in > some cases for LTO you really want to know if symbol is defined... For this case I don't think you really need to do it in fold-const, it should be fine to handle it elsewhere later (VRP may not be enough though), or to do it in fold-const but skip it if symtab is not ready. But if LTO has stronger requirements... (In reply to Jan Hubicka from comment #4) > About the inlining issue, am not really sure how to handle this without > iterating optimizers and inliner like llvm does (Maxim had patch for this). > I wonder if we can't just declare the operator () always_inline to make sure > it is early inlined? I'd rather avoid relying on always_inline, so it still works if people use boost::function or other similar code instead. But maybe temporarily... > It gets me to _M_empty call that we fail to inline because we do not inline > into alwaysinlines (because of cycles) but then we do not iterate the early > inliner anymore so we do not inline after inlining always inlines. This is > quite broken :( Any news on Maxim's patch? There was a discussion in 2011, but I can't find anything more recent, and things have changed a bit since then...
next prev parent reply other threads:[~2014-05-02 14:06 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-01-26 11:31 [Bug ipa/59948] New: " glisse at gcc dot gnu.org 2014-01-26 13:24 ` [Bug ipa/59948] " glisse at gcc dot gnu.org 2014-01-29 13:27 ` rguenth at gcc dot gnu.org 2014-02-04 2:35 ` hubicka at gcc dot gnu.org 2014-02-04 3:00 ` hubicka at gcc dot gnu.org 2014-05-02 14:06 ` glisse at gcc dot gnu.org [this message] 2014-09-26 16:54 ` hubicka at gcc dot gnu.org 2015-02-26 0:09 ` glisse at gcc dot gnu.org 2023-09-25 9:04 ` hubicka at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-59948-4-ASwhHM9DZw@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).