public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/59984] OpenMP and Cilk Plus SIMD pragma makes loop incorrect
Date: Fri, 07 Feb 2014 14:34:00 -0000	[thread overview]
Message-ID: <bug-59984-4-hX5muxTY2M@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-59984-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59984

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
I guess during gimplification when gimplifying #pragma omp simd body we should
add all the local variables (declared in the body) that aren't static and are
address taken to private clause on the #pragma omp simd, so that they will be
handled like if you in your testcase do instead:
    int v1, v2;
#pragma omp simd private (v1, v2)
    for(i = 0; i < 1000; i++)
    {
      foo(a[i], &v1, &v2);
      a[i] = v1 * v2;
    }

We don't vectorize that right now, but that is something that is likely
fixable.


  parent reply	other threads:[~2014-02-07 14:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-29 14:41 [Bug c/59984] New: " evstupac at gmail dot com
2014-01-29 14:42 ` [Bug c/59984] " evstupac at gmail dot com
2014-02-05 18:42 ` mpolacek at gcc dot gnu.org
2014-02-06 12:59 ` izamyatin at gmail dot com
2014-02-06 16:11 ` jakub at gcc dot gnu.org
2014-02-07 14:34 ` jakub at gcc dot gnu.org [this message]
2014-02-07 15:20 ` jakub at gcc dot gnu.org
2014-02-08  9:10 ` jakub at gcc dot gnu.org
2014-02-08  9:29 ` jakub at gcc dot gnu.org
2014-02-08  9:30 ` jakub at gcc dot gnu.org
2014-04-22 11:38 ` jakub at gcc dot gnu.org
2014-07-16 13:31 ` jakub at gcc dot gnu.org
2014-10-30 10:43 ` jakub at gcc dot gnu.org
2014-11-13 23:51 ` evstupac at gmail dot com
2014-11-14 15:04 ` jakub at gcc dot gnu.org
2014-11-17  9:03 ` rguenther at suse dot de
2014-11-17 14:58 ` rguenth at gcc dot gnu.org
2015-06-26 20:13 ` jakub at gcc dot gnu.org
2015-06-26 20:36 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-59984-4-hX5muxTY2M@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).