[Bug libitm/60004] New: Conditional return within transaction causes ICE

[Bug libitm/60004] New: Conditional return within transaction causes ICE

[spear at cse dot lehigh.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60004

            Bug ID: 60004
           Summary: Conditional return within transaction causes ICE
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libitm
          Assignee: unassigned at gcc dot gnu.org
          Reporter: spear at cse dot lehigh.edu

The following code produces an ICE:
int a;
int f() {
    __transaction_atomic {
        if (a == 5)
            return 1;
    }
}

compilation:
gcc -std=c++11 -fgnu-tm test_if.cc -c

error:
test_if.cc: In function ‘int f()’:
test_if.cc:4:5: internal compiler error: in lower_eh_constructs_2, at
tree-eh.c:2105
 int f()
     ^
0xb96c26 lower_eh_constructs_2
        ../../../src/gcc-libitm/gcc/tree-eh.c:2105
0xb96c26 lower_eh_constructs_1
        ../../../src/gcc-libitm/gcc/tree-eh.c:2123
0xb979a4 lower_try_finally_switch
        ../../../src/gcc-libitm/gcc/tree-eh.c:1392
0xb979a4 lower_try_finally
        ../../../src/gcc-libitm/gcc/tree-eh.c:1722
0xb979a4 lower_eh_constructs_2
        ../../../src/gcc-libitm/gcc/tree-eh.c:2065
0xb979a4 lower_eh_constructs_1
        ../../../src/gcc-libitm/gcc/tree-eh.c:2123
0xb98e91 lower_eh_constructs
        ../../../src/gcc-libitm/gcc/tree-eh.c:2141
0xb98e91 execute
        ../../../src/gcc-libitm/gcc/tree-eh.c:2193
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.

Environment: 
gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/home/spear/gcc/install/gcc/libexec/gcc/x86_64-unknown-linux-gnu/4.9.0/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: ../../src/gcc-libitm/configure
--prefix=/home/spear/gcc/install/gcc --with-gmp=/home/spear/gcc/install/gmp/
--with-mpfr=/home/spear/gcc/install/mpfr/
--with-mpc=/home/spear/gcc/install/mpc/ --enable-languages=c,c++,lto
--enable-multilib --enable-lto
Thread model: posix
gcc version 4.9.0 20140129 (experimental) (GCC)
>From gcc-bugs-return-442107-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Jan 31 05:11:11 2014
Return-Path: <gcc-bugs-return-442107-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 25134 invoked by alias); 31 Jan 2014 05:11:11 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 25009 invoked by uid 48); 31 Jan 2014 05:11:06 -0000
From: "dominiq at lps dot ens.fr" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug debug/52727] [4.9 Regression] internal compiler error at dwarf2cfi.c2:685
Date: Fri, 31 Jan 2014 05:11:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: debug
X-Bugzilla-Version: 4.7.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: major
X-Bugzilla-Who: dominiq at lps dot ens.fr
X-Bugzilla-Status: REOPENED
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: rth at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.7.1
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-52727-4-dhgOmAunQR@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-52727-4@http.gcc.gnu.org/bugzilla/>
References: <bug-52727-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-01/txt/msg03249.txt.bz2
Content-length: 455

http://gcc.gnu.org/bugzilla/show_bug.cgi?idR727

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dominiq at lps dot ens.fr

--- Comment #21 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
*** Bug 59981 has been marked as a duplicate of this bug. ***

[Bug libitm/60004] Conditional return within transaction causes ICE

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60004

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-01-31
                 CC|                            |mpolacek at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #1 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Confirmed.  We hit

2103     case GIMPLE_EH_ELSE:
2104       /* We should be eliminating this in lower_try_finally et al.  */
2105       gcc_unreachable ();

[Bug libitm/60004] Conditional return within transaction causes ICE

[rth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60004

--- Comment #2 from Richard Henderson <rth at gcc dot gnu.org> ---
Author: rth
Date: Fri Jan 31 19:35:31 2014
New Revision: 207367

URL: http://gcc.gnu.org/viewcvs?rev=207367&root=gcc&view=rev
Log:
PR middle-end/60004

        * tree-eh.c (lower_try_finally_switch): Delay lowering finally block
        until after else_eh is processed.

    * g++.dg/tm/pr60004.C: New.

Added:
    trunk/gcc/testsuite/g++.dg/tm/pr60004.C
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-eh.c

[Bug middle-end/60004] Conditional return within transaction causes ICE

[rth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60004

Richard Henderson <rth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
          Component|libitm                      |middle-end
         Resolution|---                         |FIXED
   Target Milestone|---                         |4.9.0

--- Comment #3 from Richard Henderson <rth at gcc dot gnu.org> ---
Fixed.

[Bug middle-end/60004] Conditional return within transaction causes ICE

[rth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60004

--- Comment #4 from Richard Henderson <rth at gcc dot gnu.org> ---
Author: rth
Date: Sat Feb  1 05:20:13 2014
New Revision: 207380

URL: http://gcc.gnu.org/viewcvs?rev=207380&root=gcc&view=rev
Log:
PR middle-end/60004

  * tree-eh.c (lower_try_finally_switch): Delay lowering finally block
  until after else_eh is processed.

Added:
    branches/gcc-4_7-branch/gcc/testsuite/g++.dg/tm/pr60004.C
Modified:
    branches/gcc-4_7-branch/gcc/ChangeLog
    branches/gcc-4_7-branch/gcc/tree-eh.c

[Bug middle-end/60004] Conditional return within transaction causes ICE

[rth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60004

--- Comment #5 from Richard Henderson <rth at gcc dot gnu.org> ---
Author: rth
Date: Sat Feb  1 05:24:07 2014
New Revision: 207381

URL: http://gcc.gnu.org/viewcvs?rev=207381&root=gcc&view=rev
Log:
PR middle-end/60004

  * tree-eh.c (lower_try_finally_switch): Delay lowering finally block
  until after else_eh is processed.

Added:
    branches/gcc-4_8-branch/gcc/testsuite/g++.dg/tm/pr60004.C
Modified:
    branches/gcc-4_8-branch/gcc/ChangeLog
    branches/gcc-4_8-branch/gcc/tree-eh.c

[Bug middle-end/60004] Conditional return within transaction causes ICE

[rth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60004

Richard Henderson <rth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.0                       |4.7.5

[Bug middle-end/60004] Conditional return within transaction causes ICE

[spear at cse dot lehigh.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60004

--- Comment #6 from Mike Spear <spear at cse dot lehigh.edu> ---
(For the record, this bug was found by wcm214@lehigh.edu, even though I
reported it)