public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenther at suse dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/60043] -fschedule-insns2 breaks anti-dependency
Date: Tue, 04 Feb 2014 09:26:00 -0000	[thread overview]
Message-ID: <bug-60043-4-L5pTstN4T7@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-60043-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60043

--- Comment #3 from rguenther at suse dot de <rguenther at suse dot de> ---
On Tue, 4 Feb 2014, abel at gcc dot gnu.org wrote:

> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60043
> 
> Andrey Belevantsev <abel at gcc dot gnu.org> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |abel at gcc dot gnu.org
> 
> --- Comment #1 from Andrey Belevantsev <abel at gcc dot gnu.org> ---
> I don't follow the reasoning of this example and the original ML thread.  The
> load of *b follows the store to *a, thus the scheduler is checking for the
> presence of the _true_ dependence between them:
> 
> gcc/sched-deps.c:
> 2660                 if (true_dependence (XEXP (pending_mem, 0), VOIDmode, t)
> 2661                     && ! sched_insns_conditions_mutex_p (insn,
> 2662                                                          XEXP (pending,
> 0)))
> 2663                   note_mem_dep (t, XEXP (pending_mem, 0), XEXP (pending,
> 0),
> 2664                                 sched_deps_info->generate_spec_deps
> 2665                                 ? BEGIN_DATA | DEP_TRUE : DEP_TRUE);
> 
> which does not exist because the mems have different alias sets.  But you have
> agreed that TBAA can be used for true dependences in the ML thread, no?  What
> is then required from the scheduler?

Yes, TBAA can be used for true dependences - but a true dependence is
read-after-write.  Here we have an anti-dependence, write-after-read.
When the scheduler wants to exchange two mems then it needs to use
the predicate that is correct _before_ the transform, not after.

Thus in the above code it seems that it does not check whether the
write from pending[_mem] is before or after the read in 't' - the
used predicate needs to change dependent on the order of the insns
(or conservatively assume an anti-dependence and thus disable TBAA).


  parent reply	other threads:[~2014-02-04  9:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-03 13:18 [Bug rtl-optimization/60043] New: " rguenth at gcc dot gnu.org
2014-02-04  6:59 ` [Bug rtl-optimization/60043] " abel at gcc dot gnu.org
2014-02-04  7:14 ` abel at gcc dot gnu.org
2014-02-04  9:26 ` rguenther at suse dot de [this message]
2014-02-04  9:27 ` rguenth at gcc dot gnu.org
2014-02-04  9:37 ` abel at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-60043-4-L5pTstN4T7@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).