public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/60101] [4.7/4.8/4.9 Regression] Long compile times when mixed complex floating point datatypes are used in lengthy expressions
Date: Tue, 11 Feb 2014 13:10:00 -0000	[thread overview]
Message-ID: <bug-60101-4-ZcwZiwYWSq@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-60101-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60101

--- Comment #8 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #7)
> passes with this change and the testcase from this PR finishes in under a
> second.  Manuel, can you please try to explain what you were trying to
> achieve in the SAVE_EXPR case and whether the reversal of copy behavior in
> merge_tlist was on purpose?

I don't remember I implemented this part (the revision that you mention is not
adding the handling of SAVE_EXPR or the reversal of copy behavior). My patch
simply extended the definition of what is considered candidates for warning (by
looking at the operands of operators). I took a look at my patch, and I don't
fully understand how it triggers the bug that you mention. Perhaps there is
some duplication between the code path that I added (since it is meant to
recurse on operands) and some special-handling that was there for SAVE_EXPR and
COND_EXPR.
>From gcc-bugs-return-443277-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Feb 11 13:14:27 2014
Return-Path: <gcc-bugs-return-443277-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 6458 invoked by alias); 11 Feb 2014 13:14:27 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 6392 invoked by uid 48); 11 Feb 2014 13:14:23 -0000
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/60101] [4.7/4.8/4.9 Regression] Long compile times when mixed complex floating point datatypes are used in lengthy expressions
Date: Tue, 11 Feb 2014 13:14:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 4.8.2
X-Bugzilla-Keywords: compile-time-hog, diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.7.4
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-60101-4-R3wdzQGbDq@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-60101-4@http.gcc.gnu.org/bugzilla/>
References: <bug-60101-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-02/txt/msg01034.txt.bz2
Content-length: 506

http://gcc.gnu.org/bugzilla/show_bug.cgi?id`101

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bernds at gcc dot gnu.org

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Ah, sorry, Manuel, it seems that code is older, has been added already in
http://gcc.gnu.org/ml/gcc-patches/2000-11/msg00541.html


  parent reply	other threads:[~2014-02-11 13:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-06 19:51 [Bug c/60101] New: " thorstenkurth at me dot com
2014-02-07 12:38 ` [Bug c/60101] [4.7/4.8/4.9 Regression] " rguenth at gcc dot gnu.org
2014-02-10 13:59 ` mpolacek at gcc dot gnu.org
2014-02-10 17:29 ` mpolacek at gcc dot gnu.org
2014-02-10 17:43 ` mpolacek at gcc dot gnu.org
2014-02-10 18:12 ` jakub at gcc dot gnu.org
2014-02-10 20:07 ` mpolacek at gcc dot gnu.org
2014-02-11 13:10 ` manu at gcc dot gnu.org [this message]
2014-02-11 13:15 ` jakub at gcc dot gnu.org
2014-02-11 13:17 ` manu at gcc dot gnu.org
2014-02-12  7:36 ` jakub at gcc dot gnu.org
2014-02-12  7:40 ` [Bug c/60101] [4.7/4.8 " jakub at gcc dot gnu.org
2014-03-06  8:02 ` jakub at gcc dot gnu.org
2014-06-12 13:35 ` [Bug c/60101] [4.7 " rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-60101-4-ZcwZiwYWSq@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).