[Bug c/60114] New: Incorrect column number for -pedantic and -Wconversion

[Bug c/60114] New: Incorrect column number for -pedantic and -Wconversion

[chengniansun at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60114

            Bug ID: 60114
           Summary: Incorrect column number for -pedantic and -Wconversion
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: chengniansun at gmail dot com

The column number in the warnings by -pedantic and -Wconversion is not precise. 


$: cat short.c 
int l[9] = {0xD051BC10L,0x976F2A4DL,0x976F2A4DL};
$: gcc-trunk -c -pedantic short.c
short.c:1:1: warning: overflow in implicit constant conversion [-Woverflow]
 int l[9] = {0xD051BC10L,0x976F2A4DL,0x976F2A4DL};
 ^
short.c:1:1: warning: overflow in implicit constant conversion [-Woverflow]
short.c:1:1: warning: overflow in implicit constant conversion [-Woverflow]
$: gcc-trunk -c -Wconversion short.c
short.c:1:1: warning: conversion to ‘int’ alters ‘long int’ constant value
[-Wconversion]
 int l[9] = {0xD051BC10L,0x976F2A4DL,0x976F2A4DL};
 ^
short.c:1:1: warning: conversion to ‘int’ alters ‘long int’ constant value
[-Wconversion]
short.c:1:1: warning: conversion to ‘int’ alters ‘long int’ constant value
[-Wconversion]
>From gcc-bugs-return-443018-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Feb 08 06:51:57 2014
Return-Path: <gcc-bugs-return-443018-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 16617 invoked by alias); 8 Feb 2014 06:51:57 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 16592 invoked by uid 48); 8 Feb 2014 06:51:52 -0000
From: "su at cs dot ucdavis.edu" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/60115] New: wrong code at -O3 on x86_64-linux-gnu
Date: Sat, 08 Feb 2014 06:51:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: su at cs dot ucdavis.edu
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-60115-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-02/txt/msg00775.txt.bz2
Content-length: 1316

http://gcc.gnu.org/bugzilla/show_bug.cgi?id`115

            Bug ID: 60115
           Summary: wrong code at -O3 on x86_64-linux-gnu
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: su at cs dot ucdavis.edu

The current gcc trunk mis-compiles the following code on x86_64-linux-gnu at
-O3 in both 32-bit and 64-bit modes.

This is a regression from 4.8.x.

Although the code has an out-of-bound array access, it isn't executed, so the
code is valid.

$ gcc-trunk -v
Using built-in specs.
COLLECT_GCC=gcc-trunk
COLLECT_LTO_WRAPPER=/usr/local/gcc-trunk/libexec/gcc/x86_64-unknown-linux-gnu/4.9.0/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: ../gcc-trunk/configure --prefix=/usr/local/gcc-trunk
--enable-languages=c,c++ --disable-werror --enable-multilib
Thread model: posix
gcc version 4.9.0 20140207 (experimental) [trunk revision 207610] (GCC)
$
$ gcc-trunk -O2 small.c; a.out
$ gcc-4.8 -O3 small.c; a.out
$
$ gcc-trunk -O3 small.c; a.out
Segmentation fault (core dumped)
$


-----------------------


int a, b[1];

int
main ()
{
 lbl:
  for (; a; a--)
    if (b[613])
      goto lbl;

  return 0;
}

[Bug c/60114] Incorrect column number for -pedantic and -Wconversion

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60114

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2014-02-08
                 CC|                            |mpolacek at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |mpolacek at gcc dot gnu.org
   Target Milestone|---                         |4.9.0
     Ever confirmed|0                           |1

--- Comment #1 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Mine.

[Bug c/60114] Incorrect column number for -pedantic and -Wconversion

[chengniansun at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60114

--- Comment #2 from Chengnian Sun <chengniansun at gmail dot com> ---
It seems -pedantic and -Woverflow are different. When I issue 
$ gcc-trunk -c -Woverflow s.c
then there is no overflow warning. (There is indeed no overflow.)

But when I use 
$ gcc-trunk -c -pedantic s.c
the warning says that it is emitted from -Woverflow. Is this expected?

[Bug c/60114] Incorrect column number for -pedantic and -Wconversion

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60114

--- Comment #3 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
-Woverflow is turned on by default, so it doesn't matter if you specify it or
not; what matters here is the -Wpedantic (we have a bug about that discrepancy:
PR59753).  So yeah, expected.

[Bug c/60114] Incorrect column number for -pedantic and -Wconversion

[manu at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60114

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |manu at gcc dot gnu.org

--- Comment #4 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Chengnian Sun from comment #2)
> It seems -pedantic and -Woverflow are different. When I issue 
> $ gcc-trunk -c -Woverflow s.c
> then there is no overflow warning. (There is indeed no overflow.)
> 
> But when I use 
> $ gcc-trunk -c -pedantic s.c
> the warning says that it is emitted from -Woverflow. Is this expected?

There are some warnings that are only enabled if -Wpedantic is given in
combination with other flag. Unfortunately, there is currently no way to say
that a warning is enabled by the combination of two flags, short of creating a
new flag -Wpedantic-overflow, which is enabled by the combination of -Wpedantic
&& -Woverflow. I think it could be a nice workaround
>From gcc-bugs-return-443049-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Feb 08 16:13:01 2014
Return-Path: <gcc-bugs-return-443049-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 4420 invoked by alias); 8 Feb 2014 16:13:01 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 4372 invoked by uid 48); 8 Feb 2014 16:12:57 -0000
From: "su at cs dot ucdavis.edu" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/60115] [4.9 Regression] wrong code at -O3 on x86_64-linux-gnu
Date: Sat, 08 Feb 2014 16:13:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: su at cs dot ucdavis.edu
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-60115-4-6VHe2J5k9o@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-60115-4@http.gcc.gnu.org/bugzilla/>
References: <bug-60115-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-02/txt/msg00806.txt.bz2
Content-length: 485

http://gcc.gnu.org/bugzilla/show_bug.cgi?id`115

--- Comment #3 from Zhendong Su <su at cs dot ucdavis.edu> ---
(In reply to Jakub Jelinek from comment #2)
> I have to use something like:
> int a, b[1];
>
> int
> main ()
> {
> lbl:
>   for (; a; a--)
>     if (b[10000000])
>       goto lbl;
>
>   return 0;
> }
>
> to actually successfully reproduce it.  Anyway, started with r204458.

Thanks Jakub. That's interesting. It reproduces for me as small as 450 for the
array index.

[Bug c/60114] Incorrect column number for -pedantic and -Wconversion

[manu at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60114

--- Comment #5 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Manuel López-Ibáñez from comment #4)
> (In reply to Chengnian Sun from comment #2)
> > It seems -pedantic and -Woverflow are different. When I issue 
> > $ gcc-trunk -c -Woverflow s.c
> > then there is no overflow warning. (There is indeed no overflow.)
> > 
> > But when I use 
> > $ gcc-trunk -c -pedantic s.c
> > the warning says that it is emitted from -Woverflow. Is this expected?
> 
> There are some warnings that are only enabled if -Wpedantic is given in
> combination with other flag. Unfortunately, there is currently no way to say
> that a warning is enabled by the combination of two flags, short of creating
> a new flag -Wpedantic-overflow, which is enabled by the combination of
> -Wpedantic && -Woverflow. I think it could be a nice workaround

That said, I think it would be even nicer to print the flags that appear in the
command-line (or pragmas) that triggered this warning, instead of the flag that
controls it. So here it will print [-Wpedantic,-Woverflow]. Although we now
record the relations between the flags explicitly in the *.opt files, there is
no explicit structure that allows following the chain of dependencies.
>From gcc-bugs-return-443055-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Feb 08 16:23:24 2014
Return-Path: <gcc-bugs-return-443055-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 10863 invoked by alias); 8 Feb 2014 16:23:24 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 10594 invoked by uid 55); 8 Feb 2014 16:23:19 -0000
From: "pault at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/60066] Bad elemental invocation of non-scalar base object
Date: Sat, 08 Feb 2014 16:23:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: pault at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-60066-4-WHmzFYARxE@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-60066-4@http.gcc.gnu.org/bugzilla/>
References: <bug-60066-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-02/txt/msg00812.txt.bz2
Content-length: 538

http://gcc.gnu.org/bugzilla/show_bug.cgi?id`066

--- Comment #11 from Paul Thomas <pault at gcc dot gnu.org> ---
Author: pault
Date: Sat Feb  8 16:22:46 2014
New Revision: 207633

URL: http://gcc.gnu.org/viewcvs?rev 7633&root=gcc&view=rev
Log:
2014-02-08  Paul Thomas  <pault@gcc.gnu.org>

    PR fortran/60066
    * gfortran.dg/elemental_subroutine_10.f90 : New test. This PR
    was fixed by the patch for PR59906.

Added:
    trunk/gcc/testsuite/gfortran.dg/elemental_subroutine_10.f90
Modified:
    trunk/gcc/testsuite/ChangeLog

[Bug c/60114] Incorrect column number for -pedantic and -Wconversion

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60114

--- Comment #6 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Patch posted: <http://gcc.gnu.org/ml/gcc-patches/2014-02/msg00592.html>, it
will probably need to wait for GCC 5.0.

[Bug c/60114] Incorrect column number for -pedantic and -Wconversion

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60114

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |diagnostic
   Target Milestone|4.9.0                       |---

[Bug c/60114] Incorrect column number for -pedantic and -Wconversion

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60114

--- Comment #7 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Fri Apr 25 10:49:56 2014
New Revision: 209794

URL: http://gcc.gnu.org/viewcvs?rev=209794&root=gcc&view=rev
Log:
    PR c/60114
c/
    * c-parser.c (c_parser_initelt): Pass input_location to
    process_init_element.
    (c_parser_initval): Pass loc to process_init_element.
    * c-tree.h (process_init_element): Adjust declaration.
    * c-typeck.c (push_init_level): Pass input_location to
    process_init_element.
    (pop_init_level): Likewise.
    (set_designator): Likewise.
    (output_init_element): Add location_t parameter.  Pass loc to
    digest_init.
    (output_pending_init_elements): Pass input_location to
    output_init_element.
    (process_init_element): Add location_t parameter.  Pass loc to
    output_init_element.
testsuite/
    * gcc.dg/pr60114.c: New test.


Added:
    trunk/gcc/testsuite/gcc.dg/pr60114.c
Modified:
    trunk/gcc/c/ChangeLog
    trunk/gcc/c/c-parser.c
    trunk/gcc/c/c-tree.h
    trunk/gcc/c/c-typeck.c
    trunk/gcc/testsuite/ChangeLog

[Bug c/60114] Incorrect column number for -pedantic and -Wconversion

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60114

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Fixed.

[Bug c/60114] Incorrect column number for -pedantic and -Wconversion

[yroux at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60114

--- Comment #9 from yroux at gcc dot gnu.org ---
Author: yroux
Date: Wed Jul 16 20:14:34 2014
New Revision: 212697

URL: https://gcc.gnu.org/viewcvs?rev=212697&root=gcc&view=rev
Log:
gcc/
2014-07-16  Yvan Roux  <yvan.roux@linaro.org>

    Backport from trunk r209794.
    2014-04-25  Marek Polacek  <polacek@redhat.com>

    PR c/60114
    * c-parser.c (c_parser_initelt): Pass input_location to
    process_init_element.
    (c_parser_initval): Pass loc to process_init_element.
    * c-tree.h (process_init_element): Adjust declaration.
    * c-typeck.c (push_init_level): Pass input_location to
    process_init_element.
    (pop_init_level): Likewise.
    (set_designator): Likewise.
    (output_init_element): Add location_t parameter.  Pass loc to
    digest_init.
    (output_pending_init_elements): Pass input_location to
    output_init_element.
    (process_init_element): Add location_t parameter.  Pass loc to
    output_init_element.

gcc/testsuite/
2014-07-16  Yvan Roux  <yvan.roux@linaro.org>

    Backport from trunk r209794, 209858.
    2014-04-25  Marek Polacek  <polacek@redhat.com>

    PR c/60114
    * gcc.dg/pr60114.c: New test.

    2014-04-28  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

    PR c/60983
    * gcc.dg/pr60114.c: Use signed chars.


Added:
    branches/linaro/gcc-4_9-branch/gcc/testsuite/gcc.dg/pr60114.c
Modified:
    branches/linaro/gcc-4_9-branch/gcc/ChangeLog.linaro
    branches/linaro/gcc-4_9-branch/gcc/c/c-parser.c
    branches/linaro/gcc-4_9-branch/gcc/c/c-tree.h
    branches/linaro/gcc-4_9-branch/gcc/c/c-typeck.c
    branches/linaro/gcc-4_9-branch/gcc/testsuite/ChangeLog.linaro