From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31942 invoked by alias); 18 Feb 2014 13:59:07 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Received: (qmail 31863 invoked by uid 48); 18 Feb 2014 13:59:04 -0000 From: "jakub at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug sanitizer/60142] [4.9 Regression][asan] -fsanitize=address breaks debugging - stepping into functions no longer possible Date: Tue, 18 Feb 2014 13:59:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: sanitizer X-Bugzilla-Version: 4.9.0 X-Bugzilla-Keywords: wrong-debug X-Bugzilla-Severity: normal X-Bugzilla-Who: jakub at gcc dot gnu.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 4.9.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2014-02/txt/msg01840.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60142 Jakub Jelinek changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |drow at gcc dot gnu.org, | |rth at gcc dot gnu.org --- Comment #7 from Jakub Jelinek --- Ah, so it seems the emitting of forced line note at the end of second basic block comes from: http://gcc.gnu.org/ml/gcc-patches/2004-01/msg01589.html If it is really just Daniel's paranoia that is the reason for it, perhaps we can just force the line note change after both prologue notes, like: --- gcc/final.c.jj 2014-01-03 11:40:35.000000000 +0100 +++ gcc/final.c 2014-02-18 14:50:36.675445581 +0100 @@ -112,9 +112,8 @@ along with GCC; see the file COPYING3. #endif /* Bitflags used by final_scan_insn. */ -#define SEEN_BB 1 -#define SEEN_NOTE 2 -#define SEEN_EMITTED 4 +#define SEEN_NOTE 1 +#define SEEN_EMITTED 2 /* Last insn processed by final_scan_insn. */ static rtx debug_insn; @@ -2128,9 +2127,7 @@ call_from_call_insn (rtx insn) SEEN is used to track the end of the prologue, for emitting debug information. We force the emission of a line note after - both NOTE_INSN_PROLOGUE_END and NOTE_INSN_FUNCTION_BEG, or - at the beginning of the second basic block, whichever comes - first. */ + both NOTE_INSN_PROLOGUE_END and NOTE_INSN_FUNCTION_BEG. */ rtx final_scan_insn (rtx insn, FILE *file, int optimize_p ATTRIBUTE_UNUSED, @@ -2189,14 +2186,6 @@ final_scan_insn (rtx insn, FILE *file, i if (targetm.asm_out.unwind_emit) targetm.asm_out.unwind_emit (asm_out_file, insn); - if ((*seen & (SEEN_EMITTED | SEEN_BB)) == SEEN_BB) - { - *seen |= SEEN_EMITTED; - force_source_line = true; - } - else - *seen |= SEEN_BB; - discriminator = NOTE_BASIC_BLOCK (insn)->discriminator; break; I can bootstrap/regtest this, Jan, could you check this out with GDB testsuite?