[Bug lto/60150] New: [4.9 Regression] ICE in function_and_variable_visibility, at ipa.c:1000

[Bug lto/60150] New: [4.9 Regression] ICE in function_and_variable_visibility, at ipa.c:1000

[d.g.gorbachev at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60150

            Bug ID: 60150
           Summary: [4.9 Regression] ICE in
                    function_and_variable_visibility, at ipa.c:1000
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: lto
          Assignee: unassigned at gcc dot gnu.org
          Reporter: d.g.gorbachev at gmail dot com

Created attachment 32108
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32108&action=edit
Testcase

[Bug lto/60150] [4.9 Regression] ICE in function_and_variable_visibility, at ipa.c:1000

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60150

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.9.0

[Bug lto/60150] [4.9 Regression] ICE in function_and_variable_visibility, at ipa.c:1000

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60150

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-02-27
     Ever confirmed|0                           |1

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed.

[Bug lto/60150] [4.9 Regression] ICE in function_and_variable_visibility, at ipa.c:1000

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60150

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |hubicka at gcc dot gnu.org

--- Comment #2 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
OK, this is ordering issue in the localization process: we localize comdat
groups one by one, but we also copy visibilities from functions to thunks (that
is somewhat useless fixup at LTO time).
This patch makes the comdat group localization to happen all at once.

Index: ipa.c
===================================================================
--- ipa.c       (revision 207934)
+++ ipa.c       (working copy)
@@ -970,15 +970,32 @@ function_and_variable_visibility (bool w
          gcc_assert (whole_program || in_lto_p
                      || !TREE_PUBLIC (node->decl));
          node->unique_name = ((node->resolution == LDPR_PREVAILING_DEF_IRONLY
-                                     || node->resolution ==
LDPR_PREVAILING_DEF_IRONLY_EXP)
-                                     && TREE_PUBLIC (node->decl));
+                               || node->unqiue_name
+                               || node->resolution ==
LDPR_PREVAILING_DEF_IRONLY_EXP)
+                               && TREE_PUBLIC (node->decl));
          node->resolution = LDPR_PREVAILING_DEF_IRONLY;
          if (node->same_comdat_group && TREE_PUBLIC (node->decl))
-           /* cgraph_externally_visible_p has already checked all other nodes
-              in the group and they will all be made local.  We need to
-              dissolve the group at once so that the predicate does not
-              segfault though. */
-           symtab_dissolve_same_comdat_group_list (node);
+           {
+             symtab_node *next = node;
+
+             /* Set all members of comdat group local.  */
+             if (node->same_comdat_group)
+               for (next = node->same_comdat_group;
+                    next != node;
+                    next = next->same_comdat_group)
+               {
+                 symtab_make_decl_local (next->decl);
+                 next->unique_name = ((next->resolution ==
LDPR_PREVAILING_DEF_IRONLY
+                                       || next->unqiue_name
+                                       || next->resolution ==
LDPR_PREVAILING_DEF_IRONLY_EXP)
+                                       && TREE_PUBLIC (next->decl));
+               }
+             /* cgraph_externally_visible_p has already checked all other
nodes
+                in the group and they will all be made local.  We need to
+                dissolve the group at once so that the predicate does not
+                segfault though. */
+             symtab_dissolve_same_comdat_group_list (node);
+           }
          symtab_make_decl_local (node->decl);
        }

[Bug lto/60150] [4.9 Regression] ICE in function_and_variable_visibility, at ipa.c:1000

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60150

--- Comment #3 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Author: hubicka
Date: Sun Mar  2 22:19:37 2014
New Revision: 208262

URL: http://gcc.gnu.org/viewcvs?rev=208262&root=gcc&view=rev
Log:
    PR ipa/60150
    * ipa.c (function_and_variable_visibility): When dissolving comdat
    group, also set all symbols to local.
    * g++.dg/lto/pr60150.H: New testcase.
    * g++.dg/lto/pr60150_0.C: New testcase.
    * g++.dg/lto/pr60150_1.C: New testcase.

Added:
    trunk/gcc/testsuite/g++.dg/lto/pr60150.H
    trunk/gcc/testsuite/g++.dg/lto/pr60150_0.C
    trunk/gcc/testsuite/g++.dg/lto/pr60150_1.C
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ipa.c
    trunk/gcc/testsuite/ChangeLog

[Bug lto/60150] [4.9 Regression] ICE in function_and_variable_visibility, at ipa.c:1000

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60150

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Fixed.

[Bug lto/60150] [4.9 Regression] ICE in function_and_variable_visibility, at ipa.c:1000

[d.g.gorbachev at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60150

--- Comment #5 from Dmitry Gorbachev <d.g.gorbachev at gmail dot com> ---
Ok, but there is no «#define XXX» before «#include "pr60150.H"» in pr60150_0.C,
which does not seem to be correct.
>From gcc-bugs-return-445354-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Mar 04 08:59:56 2014
Return-Path: <gcc-bugs-return-445354-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 27507 invoked by alias); 4 Mar 2014 08:59:55 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 27444 invoked by uid 48); 4 Mar 2014 08:59:52 -0000
From: "janus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/58880] [4.9 Regression] [OOP] ICE on valid with FINAL function and type extension
Date: Tue, 04 Mar 2014 08:59:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: janus at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-58880-4-QiZP4CJ0o2@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-58880-4@http.gcc.gnu.org/bugzilla/>
References: <bug-58880-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-03/txt/msg00223.txt.bz2
Content-length: 502

http://gcc.gnu.org/bugzilla/show_bug.cgi?idX880

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu.org

--- Comment #4 from janus at gcc dot gnu.org ---
(In reply to Dominique d'Humieres from comment #3)
> The Ice starts at r199409.

Yes, this was the commit (by Tobias) which enabled the finalization wrapper.

[Bug lto/60150] [4.9 Regression] ICE in function_and_variable_visibility, at ipa.c:1000

[d.g.gorbachev at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60150

--- Comment #6 from Dmitry Gorbachev <d.g.gorbachev at gmail dot com> ---
Filed bug 64076 for a new problem.