public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug target/60179] New: [4.9 Regression] target optimization attribute streaming is broken
@ 2014-02-13 15:22 rguenth at gcc dot gnu.org
2014-02-13 15:25 ` [Bug target/60179] " rguenth at gcc dot gnu.org
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: rguenth at gcc dot gnu.org @ 2014-02-13 15:22 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60179
Bug ID: 60179
Summary: [4.9 Regression] target optimization attribute
streaming is broken
Product: gcc
Version: 4.9.0
Status: UNCONFIRMED
Keywords: lto
Severity: normal
Priority: P3
Component: target
Assignee: unassigned at gcc dot gnu.org
Reporter: rguenth at gcc dot gnu.org
Target: x86_64-*-*, i?86-*-*
Since somewhen recently the i386 target started to put pointers to strings in
struct cl_target_option (TargetSaves in i386.opt). This breaks LTO streaming
of TS_TARGET_OPTION which streams the contents of cl_target_option
byte-for-byte.
For me this results in a LTO bootstrap comparison failure when comparing
stage2/libccp/lex.o and stage3/libcpp/lex.o.
And it obviously will make the backend crash if anybody would ever inspect
one of those streamed string pointers (well, or they'll point somewhere
random and not so useful).
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug target/60179] [4.9 Regression] target optimization attribute streaming is broken 2014-02-13 15:22 [Bug target/60179] New: [4.9 Regression] target optimization attribute streaming is broken rguenth at gcc dot gnu.org @ 2014-02-13 15:25 ` rguenth at gcc dot gnu.org 2014-02-13 15:25 ` rguenth at gcc dot gnu.org ` (6 subsequent siblings) 7 siblings, 0 replies; 9+ messages in thread From: rguenth at gcc dot gnu.org @ 2014-02-13 15:25 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60179 Richard Biener <rguenth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tmsriram at google dot com --- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> --- CCing offender. ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/60179] [4.9 Regression] target optimization attribute streaming is broken 2014-02-13 15:22 [Bug target/60179] New: [4.9 Regression] target optimization attribute streaming is broken rguenth at gcc dot gnu.org 2014-02-13 15:25 ` [Bug target/60179] " rguenth at gcc dot gnu.org @ 2014-02-13 15:25 ` rguenth at gcc dot gnu.org 2014-02-13 15:49 ` rguenth at gcc dot gnu.org ` (5 subsequent siblings) 7 siblings, 0 replies; 9+ messages in thread From: rguenth at gcc dot gnu.org @ 2014-02-13 15:25 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60179 Richard Biener <rguenth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hubicka at gcc dot gnu.org Known to work| |4.8.3 Target Milestone|--- |4.9.0 --- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> --- i386 is the only port TargetSaveing strings, nios2 saves arrays (not sure how they end up in cl_target_option). rs6000 is saving ints. It was suggested to change streaming to not stream TS_TARGET_OPTION but re-generate them from the attributes (we stream those if they are present and preserved). ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/60179] [4.9 Regression] target optimization attribute streaming is broken 2014-02-13 15:22 [Bug target/60179] New: [4.9 Regression] target optimization attribute streaming is broken rguenth at gcc dot gnu.org 2014-02-13 15:25 ` [Bug target/60179] " rguenth at gcc dot gnu.org 2014-02-13 15:25 ` rguenth at gcc dot gnu.org @ 2014-02-13 15:49 ` rguenth at gcc dot gnu.org 2014-02-13 16:01 ` rguenth at gcc dot gnu.org ` (4 subsequent siblings) 7 siblings, 0 replies; 9+ messages in thread From: rguenth at gcc dot gnu.org @ 2014-02-13 15:49 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60179 --- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> --- Created attachment 32125 --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32125&action=edit untested patch ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/60179] [4.9 Regression] target optimization attribute streaming is broken 2014-02-13 15:22 [Bug target/60179] New: [4.9 Regression] target optimization attribute streaming is broken rguenth at gcc dot gnu.org ` (2 preceding siblings ...) 2014-02-13 15:49 ` rguenth at gcc dot gnu.org @ 2014-02-13 16:01 ` rguenth at gcc dot gnu.org 2014-02-13 16:05 ` rguenth at gcc dot gnu.org ` (3 subsequent siblings) 7 siblings, 0 replies; 9+ messages in thread From: rguenth at gcc dot gnu.org @ 2014-02-13 16:01 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60179 Richard Biener <rguenth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32125|0 |1 is obsolete| | --- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> --- Created attachment 32126 --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32126&action=edit non-working patch ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/60179] [4.9 Regression] target optimization attribute streaming is broken 2014-02-13 15:22 [Bug target/60179] New: [4.9 Regression] target optimization attribute streaming is broken rguenth at gcc dot gnu.org ` (3 preceding siblings ...) 2014-02-13 16:01 ` rguenth at gcc dot gnu.org @ 2014-02-13 16:05 ` rguenth at gcc dot gnu.org 2014-02-14 12:04 ` rguenth at gcc dot gnu.org ` (2 subsequent siblings) 7 siblings, 0 replies; 9+ messages in thread From: rguenth at gcc dot gnu.org @ 2014-02-13 16:05 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60179 Richard Biener <rguenth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |ASSIGNED Last reconfirmed| |2014-02-13 Assignee|unassigned at gcc dot gnu.org |rguenth at gcc dot gnu.org Ever confirmed|0 |1 --- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> --- Created attachment 32127 --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32127&action=edit patch ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/60179] [4.9 Regression] target optimization attribute streaming is broken 2014-02-13 15:22 [Bug target/60179] New: [4.9 Regression] target optimization attribute streaming is broken rguenth at gcc dot gnu.org ` (4 preceding siblings ...) 2014-02-13 16:05 ` rguenth at gcc dot gnu.org @ 2014-02-14 12:04 ` rguenth at gcc dot gnu.org 2014-02-14 12:05 ` rguenth at gcc dot gnu.org 2014-05-21 14:46 ` sandra at gcc dot gnu.org 7 siblings, 0 replies; 9+ messages in thread From: rguenth at gcc dot gnu.org @ 2014-02-14 12:04 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60179 --- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> --- Author: rguenth Date: Fri Feb 14 12:03:43 2014 New Revision: 207783 URL: http://gcc.gnu.org/viewcvs?rev=207783&root=gcc&view=rev Log: 2014-02-14 Richard Biener <rguenther@suse.de> PR lto/60179 * lto-streamer-out.c (DFS_write_tree_body): Do not follow DECL_FUNCTION_SPECIFIC_TARGET. (hash_tree): Do not hash DECL_FUNCTION_SPECIFIC_TARGET. * tree-streamer-out.c (pack_ts_target_option): Remove. (streamer_pack_tree_bitfields): Do not stream TS_TARGET_OPTION. (write_ts_function_decl_tree_pointers): Do not stream DECL_FUNCTION_SPECIFIC_TARGET. * tree-streamer-in.c (unpack_ts_target_option): Remove. (unpack_value_fields): Do not stream TS_TARGET_OPTION. (lto_input_ts_function_decl_tree_pointers): Do not stream DECL_FUNCTION_SPECIFIC_TARGET. lto/ * lto.c (compare_tree_sccs_1): Do not compare DECL_FUNCTION_SPECIFIC_TARGET. (lto_read_decls): Re-build DECL_FUNCTION_SPECIFIC_TARGET. Modified: trunk/gcc/ChangeLog trunk/gcc/lto-streamer-out.c trunk/gcc/lto/ChangeLog trunk/gcc/lto/lto.c trunk/gcc/tree-streamer-in.c trunk/gcc/tree-streamer-out.c ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/60179] [4.9 Regression] target optimization attribute streaming is broken 2014-02-13 15:22 [Bug target/60179] New: [4.9 Regression] target optimization attribute streaming is broken rguenth at gcc dot gnu.org ` (5 preceding siblings ...) 2014-02-14 12:04 ` rguenth at gcc dot gnu.org @ 2014-02-14 12:05 ` rguenth at gcc dot gnu.org 2014-05-21 14:46 ` sandra at gcc dot gnu.org 7 siblings, 0 replies; 9+ messages in thread From: rguenth at gcc dot gnu.org @ 2014-02-14 12:05 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60179 Richard Biener <rguenth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> --- Fixed. ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/60179] [4.9 Regression] target optimization attribute streaming is broken 2014-02-13 15:22 [Bug target/60179] New: [4.9 Regression] target optimization attribute streaming is broken rguenth at gcc dot gnu.org ` (6 preceding siblings ...) 2014-02-14 12:05 ` rguenth at gcc dot gnu.org @ 2014-05-21 14:46 ` sandra at gcc dot gnu.org 7 siblings, 0 replies; 9+ messages in thread From: sandra at gcc dot gnu.org @ 2014-05-21 14:46 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60179 --- Comment #8 from sandra at gcc dot gnu.org --- Author: sandra Date: Wed May 21 14:45:36 2014 New Revision: 210714 URL: http://gcc.gnu.org/viewcvs?rev=210714&root=gcc&view=rev Log: 2014-05-21 Cesar Philippidis <cesar@codesourcery.com> Sandra Loosemore <sandra@codesourcery.com> PR lto/60179 gcc/testsuite/ * lib/scanasm.exp (scan-lto-assembler): New procedure. * gcc.target/nios2/custom-fp-lto.c: New test. Added: trunk/gcc/testsuite/gcc.target/nios2/custom-fp-lto.c Modified: trunk/gcc/testsuite/ChangeLog trunk/gcc/testsuite/lib/scanasm.exp ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-05-21 14:46 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2014-02-13 15:22 [Bug target/60179] New: [4.9 Regression] target optimization attribute streaming is broken rguenth at gcc dot gnu.org 2014-02-13 15:25 ` [Bug target/60179] " rguenth at gcc dot gnu.org 2014-02-13 15:25 ` rguenth at gcc dot gnu.org 2014-02-13 15:49 ` rguenth at gcc dot gnu.org 2014-02-13 16:01 ` rguenth at gcc dot gnu.org 2014-02-13 16:05 ` rguenth at gcc dot gnu.org 2014-02-14 12:04 ` rguenth at gcc dot gnu.org 2014-02-14 12:05 ` rguenth at gcc dot gnu.org 2014-05-21 14:46 ` sandra at gcc dot gnu.org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).