public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "ubizjak at gmail dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/60207] Wrong TFmode check in construct_container Date: Sat, 15 Feb 2014 08:48:00 -0000 [thread overview] Message-ID: <bug-60207-4-gQEa7tO8TK@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-60207-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60207 --- Comment #1 from Uroš Bizjak <ubizjak at gmail dot com> --- (In reply to H.J. Lu from comment #0) > But we didn't remove mode == TFmode check in construct_container. This check is benign. classify_argument will return: case TFmode: classes[0] = X86_64_SSE_CLASS; classes[1] = X86_64_SSEUP_CLASS; return 2; and the check in construct_container is: if (n == 2 && regclass[0] == X86_64_INTEGER_CLASS && regclass[1] == X86_64_INTEGER_CLASS && (mode == CDImode || mode == TImode || mode == TFmode) && intreg[0] + 1 == intreg[1]) return gen_rtx_REG (mode, intreg[0]); The above condition never triggers due to regclass checks. So, you can remove TFmode check without harm. The patch is pre-approved for mainline and release branches. >From gcc-bugs-return-443627-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Feb 15 09:45:36 2014 Return-Path: <gcc-bugs-return-443627-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org> Delivered-To: listarch-gcc-bugs@gcc.gnu.org Received: (qmail 29918 invoked by alias); 15 Feb 2014 09:45:35 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: <gcc-bugs.gcc.gnu.org> List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/> List-Post: <mailto:gcc-bugs@gcc.gnu.org> List-Help: <mailto:gcc-bugs-help@gcc.gnu.org> Sender: gcc-bugs-owner@gcc.gnu.org Delivered-To: mailing list gcc-bugs@gcc.gnu.org Received: (qmail 29873 invoked by uid 48); 15 Feb 2014 09:45:32 -0000 From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug rtl-optimization/49847] [4.7/4.8/4.9 Regression] NULL deref in fold_rtx (prev_insn_cc0 == NULL) Date: Sat, 15 Feb 2014 09:45:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: rtl-optimization X-Bugzilla-Version: 4.7.0 X-Bugzilla-Keywords: build, ice-on-valid-code X-Bugzilla-Severity: critical X-Bugzilla-Who: rguenth at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Priority: P4 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 4.7.4 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: <bug-49847-4-HRmyZ6nN4d@http.gcc.gnu.org/bugzilla/> In-Reply-To: <bug-49847-4@http.gcc.gnu.org/bugzilla/> References: <bug-49847-4@http.gcc.gnu.org/bugzilla/> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2014-02/txt/msg01384.txt.bz2 Content-length: 660 http://gcc.gnu.org/bugzilla/show_bug.cgi?idI847 Richard Biener <rguenth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|richard.guenther at gmail dot com |rguenth at gcc dot gnu.org, | |stevenb.gcc at gmail dot com --- Comment #27 from Richard Biener <rguenth at gcc dot gnu.org> --- Yeah, not sure how non-cc0 targets avoid this situation. I wonder if there is a suitable pre-reload pass to do such reloading (I'm not sure teaching reload to do that is the best idea ...)
next parent reply other threads:[~2014-02-15 8:48 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <bug-60207-4@http.gcc.gnu.org/bugzilla/> 2014-02-15 8:48 ` ubizjak at gmail dot com [this message] 2014-02-19 22:43 ` hjl at gcc dot gnu.org 2014-02-19 22:46 ` hjl at gcc dot gnu.org 2014-02-19 22:47 ` hjl.tools at gmail dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-60207-4-gQEa7tO8TK@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).