* [Bug fortran/60234] [4.9 Regression] [OOP] ICE in generate_finalization_wrapper at fortran/class.c:1883
2014-02-16 22:55 [Bug fortran/60234] New: OOP internal compiler error: in generate_finalization_wrapper antony at cosmologist dot info
@ 2014-02-17 10:28 ` janus at gcc dot gnu.org
2014-02-17 10:39 ` janus at gcc dot gnu.org
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: janus at gcc dot gnu.org @ 2014-02-17 10:28 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60234
janus at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |ice-on-valid-code
Status|UNCONFIRMED |NEW
Last reconfirmed| |2014-02-17
CC| |janus at gcc dot gnu.org
Summary|OOP internal compiler |[4.9 Regression] [OOP] ICE
|error: in |in
|generate_finalization_wrapp |generate_finalization_wrapp
|er |er at fortran/class.c:1883
Ever confirmed|0 |1
--- Comment #1 from janus at gcc dot gnu.org ---
Reduced test case:
module ObjectLists
implicit none
Type TObjectList
contains
FINAL :: finalize
end Type
Type, extends(TObjectList):: TRealCompareList
end Type
contains
subroutine finalize(L)
Type(TObjectList) :: L
end subroutine
integer function CompareReal(this)
Class(TRealCompareList) :: this
end function
end module
4.8 rejects it cleanly ('not yet implemented'), so the ICE is a regression.
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug fortran/60234] [4.9 Regression] [OOP] ICE in generate_finalization_wrapper at fortran/class.c:1883
2014-02-16 22:55 [Bug fortran/60234] New: OOP internal compiler error: in generate_finalization_wrapper antony at cosmologist dot info
2014-02-17 10:28 ` [Bug fortran/60234] [4.9 Regression] [OOP] ICE in generate_finalization_wrapper at fortran/class.c:1883 janus at gcc dot gnu.org
@ 2014-02-17 10:39 ` janus at gcc dot gnu.org
2014-02-17 11:11 ` janus at gcc dot gnu.org
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: janus at gcc dot gnu.org @ 2014-02-17 10:39 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60234
--- Comment #2 from janus at gcc dot gnu.org ---
This patchlet seems to be sufficient to fix the ICE:
Index: gcc/fortran/decl.c
===================================================================
--- gcc/fortran/decl.c (revision 207804)
+++ gcc/fortran/decl.c (working copy)
@@ -1199,7 +1199,7 @@ build_sym (const char *name, gfc_charlen *cl, bool
sym->attr.implied_index = 0;
if (sym->ts.type == BT_CLASS)
- return gfc_build_class_symbol (&sym->ts, &sym->attr, &sym->as, false);
+ return gfc_build_class_symbol (&sym->ts, &sym->attr, &sym->as, true);
return true;
}
Comment 1 compiles fine with this, but comment 0 hits another ICE:
ObjectLists.f90:186:0: internal compiler error: Segmentation fault
class is (object_array_pointer)
^
0x93e90f crash_signal
/home/jweil/gcc49/trunk/gcc/toplev.c:337
0x672420 gfc_get_derived_type(gfc_symbol*)
/home/jweil/gcc49/trunk/gcc/fortran/trans-types.c:2455
0x672988 gfc_typenode_for_spec(gfc_typespec*)
/home/jweil/gcc49/trunk/gcc/fortran/trans-types.c:1112
0x671263 gfc_sym_type(gfc_symbol*)
/home/jweil/gcc49/trunk/gcc/fortran/trans-types.c:2137
0x671728 gfc_get_function_type(gfc_symbol*)
/home/jweil/gcc49/trunk/gcc/fortran/trans-types.c:2797
0x6721ca gfc_get_ppc_type(gfc_component*)
/home/jweil/gcc49/trunk/gcc/fortran/trans-types.c:2322
0x6726a7 gfc_get_derived_type(gfc_symbol*)
/home/jweil/gcc49/trunk/gcc/fortran/trans-types.c:2484
0x672988 gfc_typenode_for_spec(gfc_typespec*)
/home/jweil/gcc49/trunk/gcc/fortran/trans-types.c:1112
0x671263 gfc_sym_type(gfc_symbol*)
/home/jweil/gcc49/trunk/gcc/fortran/trans-types.c:2137
0x637b96 gfc_get_symbol_decl(gfc_symbol*)
/home/jweil/gcc49/trunk/gcc/fortran/trans-decl.c:1390
0x639f99 gfc_create_module_variable
/home/jweil/gcc49/trunk/gcc/fortran/trans-decl.c:4267
0x607453 do_traverse_symtree
/home/jweil/gcc49/trunk/gcc/fortran/symbol.c:3575
0x63ae12 gfc_generate_module_vars(gfc_namespace*)
/home/jweil/gcc49/trunk/gcc/fortran/trans-decl.c:4693
0x61cef1 gfc_generate_module_code(gfc_namespace*)
/home/jweil/gcc49/trunk/gcc/fortran/trans.c:1930
0x5db92b translate_all_program_units
/home/jweil/gcc49/trunk/gcc/fortran/parse.c:4523
0x5db92b gfc_parse_file()
/home/jweil/gcc49/trunk/gcc/fortran/parse.c:4733
0x618335 gfc_be_parse_file
/home/jweil/gcc49/trunk/gcc/fortran/f95-lang.c:188
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug fortran/60234] [4.9 Regression] [OOP] ICE in generate_finalization_wrapper at fortran/class.c:1883
2014-02-16 22:55 [Bug fortran/60234] New: OOP internal compiler error: in generate_finalization_wrapper antony at cosmologist dot info
2014-02-17 10:28 ` [Bug fortran/60234] [4.9 Regression] [OOP] ICE in generate_finalization_wrapper at fortran/class.c:1883 janus at gcc dot gnu.org
2014-02-17 10:39 ` janus at gcc dot gnu.org
@ 2014-02-17 11:11 ` janus at gcc dot gnu.org
2014-02-17 11:28 ` janus at gcc dot gnu.org
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: janus at gcc dot gnu.org @ 2014-02-17 11:11 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60234
--- Comment #3 from janus at gcc dot gnu.org ---
(In reply to janus from comment #2)
> Comment 1 compiles fine with this, but comment 0 hits another ICE:
>
> ObjectLists.f90:186:0: internal compiler error: Segmentation fault
> class is (object_array_pointer)
> ^
> 0x93e90f crash_signal
> /home/jweil/gcc49/trunk/gcc/toplev.c:337
> 0x672420 gfc_get_derived_type(gfc_symbol*)
> /home/jweil/gcc49/trunk/gcc/fortran/trans-types.c:2455
A reduced test case for this ICE is:
integer function Compare(R1)
class(*) R1
end function
But it seems to be due to the patch in comment 2 and does not occur without it.
>From gcc-bugs-return-443906-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Feb 17 11:11:36 2014
Return-Path: <gcc-bugs-return-443906-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 13091 invoked by alias); 17 Feb 2014 11:11:36 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 13043 invoked by uid 48); 17 Feb 2014 11:11:32 -0000
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/60183] [4.7/4.8 Regression] phiprop creates invalid code
Date: Mon, 17 Feb 2014 11:11:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 4.8.2
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: rguenth at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.7.4
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cf_known_to_work short_desc
Message-ID: <bug-60183-4-3ZBr3U42JL@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-60183-4@http.gcc.gnu.org/bugzilla/>
References: <bug-60183-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-02/txt/msg01663.txt.bz2
Content-length: 581
http://gcc.gnu.org/bugzilla/show_bug.cgi?id`183
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Known to work| |4.9.0
Summary|[4.7/4.8/4.9 Regression] |[4.7/4.8 Regression]
|phiprop creates invalid |phiprop creates invalid
|code |code
--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed on trunk sofar.
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug fortran/60234] [4.9 Regression] [OOP] ICE in generate_finalization_wrapper at fortran/class.c:1883
2014-02-16 22:55 [Bug fortran/60234] New: OOP internal compiler error: in generate_finalization_wrapper antony at cosmologist dot info
` (2 preceding siblings ...)
2014-02-17 11:11 ` janus at gcc dot gnu.org
@ 2014-02-17 11:28 ` janus at gcc dot gnu.org
2014-02-17 12:24 ` janus at gcc dot gnu.org
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: janus at gcc dot gnu.org @ 2014-02-17 11:28 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60234
janus at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |janus at gcc dot gnu.org
--- Comment #4 from janus at gcc dot gnu.org ---
The test case in comment 0 compiles cleanly when adding the following to the
patch in comment 2:
Index: gcc/fortran/class.c
===================================================================
--- gcc/fortran/class.c (revision 207804)
+++ gcc/fortran/class.c (working copy)
@@ -637,9 +637,10 @@ gfc_build_class_symbol (gfc_typespec *ts, symbol_a
if (!gfc_add_component (fclass, "_vptr", &c))
return false;
c->ts.type = BT_DERIVED;
- if (delayed_vtab
- || (ts->u.derived->f2k_derived
- && ts->u.derived->f2k_derived->finalizers))
+ if ((delayed_vtab
+ || (ts->u.derived->f2k_derived
+ && ts->u.derived->f2k_derived->finalizers))
+ && !ts->u.derived->attr.unlimited_polymorphic)
c->ts.u.derived = NULL;
else
{
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug fortran/60234] [4.9 Regression] [OOP] ICE in generate_finalization_wrapper at fortran/class.c:1883
2014-02-16 22:55 [Bug fortran/60234] New: OOP internal compiler error: in generate_finalization_wrapper antony at cosmologist dot info
` (3 preceding siblings ...)
2014-02-17 11:28 ` janus at gcc dot gnu.org
@ 2014-02-17 12:24 ` janus at gcc dot gnu.org
2014-02-17 13:46 ` janus at gcc dot gnu.org
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: janus at gcc dot gnu.org @ 2014-02-17 12:24 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60234
--- Comment #5 from janus at gcc dot gnu.org ---
(In reply to janus from comment #4)
> The test case in comment 0 compiles cleanly when adding the following to the
> patch in comment 2:
Unfortunately the combination fails on proc_ptr_comp_37 in the testsuite.
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug fortran/60234] [4.9 Regression] [OOP] ICE in generate_finalization_wrapper at fortran/class.c:1883
2014-02-16 22:55 [Bug fortran/60234] New: OOP internal compiler error: in generate_finalization_wrapper antony at cosmologist dot info
` (4 preceding siblings ...)
2014-02-17 12:24 ` janus at gcc dot gnu.org
@ 2014-02-17 13:46 ` janus at gcc dot gnu.org
2014-02-17 14:19 ` janus at gcc dot gnu.org
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: janus at gcc dot gnu.org @ 2014-02-17 13:46 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60234
--- Comment #6 from janus at gcc dot gnu.org ---
(In reply to janus from comment #5)
> Unfortunately the combination fails on proc_ptr_comp_37 in the testsuite.
To fix this, another hunk in class.c is needed, so that the patch becomes:
Index: gcc/fortran/class.c
===================================================================
--- gcc/fortran/class.c (revision 207823)
+++ gcc/fortran/class.c (working copy)
@@ -637,9 +637,10 @@ gfc_build_class_symbol (gfc_typespec *ts, symbol_a
if (!gfc_add_component (fclass, "_vptr", &c))
return false;
c->ts.type = BT_DERIVED;
- if (delayed_vtab
- || (ts->u.derived->f2k_derived
- && ts->u.derived->f2k_derived->finalizers))
+ if ((delayed_vtab
+ || (ts->u.derived->f2k_derived
+ && ts->u.derived->f2k_derived->finalizers))
+ && !ts->u.derived->attr.unlimited_polymorphic)
c->ts.u.derived = NULL;
else
{
@@ -790,7 +791,9 @@ has_finalizer_component (gfc_symbol *derived)
static bool
comp_is_finalizable (gfc_component *comp)
{
- if (comp->attr.allocatable && comp->ts.type != BT_CLASS)
+ if (comp->attr.proc_pointer)
+ return false;
+ else if (comp->attr.allocatable && comp->ts.type != BT_CLASS)
return true;
else if (comp->ts.type == BT_DERIVED && !comp->attr.pointer
&& (comp->ts.u.derived->attr.alloc_comp
Index: gcc/fortran/decl.c
===================================================================
--- gcc/fortran/decl.c (revision 207823)
+++ gcc/fortran/decl.c (working copy)
@@ -1199,7 +1199,7 @@ build_sym (const char *name, gfc_charlen *cl, bool
sym->attr.implied_index = 0;
if (sym->ts.type == BT_CLASS)
- return gfc_build_class_symbol (&sym->ts, &sym->attr, &sym->as, false);
+ return gfc_build_class_symbol (&sym->ts, &sym->attr, &sym->as, true);
return true;
}
This should be free of testsuite failures.
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug fortran/60234] [4.9 Regression] [OOP] ICE in generate_finalization_wrapper at fortran/class.c:1883
2014-02-16 22:55 [Bug fortran/60234] New: OOP internal compiler error: in generate_finalization_wrapper antony at cosmologist dot info
` (5 preceding siblings ...)
2014-02-17 13:46 ` janus at gcc dot gnu.org
@ 2014-02-17 14:19 ` janus at gcc dot gnu.org
2014-02-21 9:07 ` janus at gcc dot gnu.org
2014-02-21 9:09 ` janus at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: janus at gcc dot gnu.org @ 2014-02-17 14:19 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60234
--- Comment #7 from janus at gcc dot gnu.org ---
I think it should be possible (and preferable) to always defer the building of
the vtab, and not only partially as in comment 6. Will try to do that ...
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug fortran/60234] [4.9 Regression] [OOP] ICE in generate_finalization_wrapper at fortran/class.c:1883
2014-02-16 22:55 [Bug fortran/60234] New: OOP internal compiler error: in generate_finalization_wrapper antony at cosmologist dot info
` (6 preceding siblings ...)
2014-02-17 14:19 ` janus at gcc dot gnu.org
@ 2014-02-21 9:07 ` janus at gcc dot gnu.org
2014-02-21 9:09 ` janus at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: janus at gcc dot gnu.org @ 2014-02-21 9:07 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60234
--- Comment #8 from janus at gcc dot gnu.org ---
Author: janus
Date: Fri Feb 21 09:06:57 2014
New Revision: 207986
URL: http://gcc.gnu.org/viewcvs?rev=207986&root=gcc&view=rev
Log:
2014-02-21 Janus Weil <janus@gcc.gnu.org>
PR fortran/60234
* gfortran.h (gfc_build_class_symbol): Removed argument.
* class.c (gfc_add_component_ref): Fix up missing vtype if necessary.
(gfc_build_class_symbol): Remove argument 'delayed_vtab'. vtab is always
delayed now, except for unlimited polymorphics.
(comp_is_finalizable): Procedure pointer components are not finalizable.
* decl. (build_sym, build_struct, attr_decl1): Removed argument of
'gfc_build_class_symbol'.
* match.c (copy_ts_from_selector_to_associate, select_type_set_tmp):
Ditto.
* symbol.c (gfc_set_default_type): Ditto.
2014-02-21 Janus Weil <janus@gcc.gnu.org>
PR fortran/60234
* gfortran.dg/finalize_23.f90: New.
Added:
trunk/gcc/testsuite/gfortran.dg/finalize_23.f90
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/class.c
trunk/gcc/fortran/decl.c
trunk/gcc/fortran/gfortran.h
trunk/gcc/fortran/match.c
trunk/gcc/fortran/symbol.c
trunk/gcc/testsuite/ChangeLog
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug fortran/60234] [4.9 Regression] [OOP] ICE in generate_finalization_wrapper at fortran/class.c:1883
2014-02-16 22:55 [Bug fortran/60234] New: OOP internal compiler error: in generate_finalization_wrapper antony at cosmologist dot info
` (7 preceding siblings ...)
2014-02-21 9:07 ` janus at gcc dot gnu.org
@ 2014-02-21 9:09 ` janus at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: janus at gcc dot gnu.org @ 2014-02-21 9:09 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60234
janus at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #9 from janus at gcc dot gnu.org ---
Fixed with r207986. Closing.
^ permalink raw reply [flat|nested] 10+ messages in thread