public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "abel at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug rtl-optimization/60268] [4.9 regression] ICE: in rank_for_schedule, at haifa-sched.c:2557 Date: Thu, 20 Feb 2014 11:59:00 -0000 [thread overview] Message-ID: <bug-60268-4-NxYNX9lRVK@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-60268-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60268 --- Comment #4 from Andrey Belevantsev <abel at gcc dot gnu.org> --- (In reply to Jakub Jelinek from comment #2) I forgot the single block regions case, so the nr_regions_initial init should be moved to the bottom of sched_rgn_init. The check before free_global_sched_pressure_data can be moved before if() like in the below patch, this way we do not call it each time after we have reset sched_pressure to NONE for the new regions, or I can drop it altogether, as you prefer. diff --git a/gcc/sched-rgn.c b/gcc/sched-rgn.c index 0573b6a..dc6fa16 100644 --- a/gcc/sched-rgn.c +++ b/gcc/sched-rgn.c @@ -1067,7 +1067,6 @@ haifa_find_rgns (void) BLOCK_TO_BB (bb->index) = 0; } - nr_regions_initial = nr_regions; free (max_hdr); free (degree); free (stack); @@ -2997,10 +2996,10 @@ schedule_region (int rgn) /* Do not support register pressure sensitive scheduling for the new regions as we don't update the liveness info for them. */ - if (rgn >= nr_regions_initial) + if (sched_pressure != SCHED_PRESSURE_NONE + && rgn >= nr_regions_initial) { - if (sched_pressure != SCHED_PRESSURE_NONE) - free_global_sched_pressure_data (); + free_global_sched_pressure_data (); sched_pressure = SCHED_PRESSURE_NONE; } @@ -3166,6 +3165,7 @@ sched_rgn_init (bool single_blocks_p) RGN_BLOCKS (nr_regions) = (RGN_BLOCKS (nr_regions - 1) + RGN_NR_BLOCKS (nr_regions - 1)); + nr_regions_initial = nr_regions; } /* Free data structures for region scheduling. */
next prev parent reply other threads:[~2014-02-20 11:59 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-02-19 5:23 [Bug rtl-optimization/60268] New: " dimhen at gmail dot com 2014-02-19 6:53 ` [Bug rtl-optimization/60268] " jakub at gcc dot gnu.org 2014-02-19 7:03 ` jakub at gcc dot gnu.org 2014-02-19 9:08 ` rguenth at gcc dot gnu.org 2014-02-19 9:31 ` abel at gcc dot gnu.org 2014-02-20 11:59 ` abel at gcc dot gnu.org [this message] 2014-02-24 5:57 ` abel at gcc dot gnu.org 2014-02-24 6:03 ` abel at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-60268-4-NxYNX9lRVK@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).