public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/60270] New: [C++1y] std::quoted is too eager to clear the string
@ 2014-02-19 10:33 redi at gcc dot gnu.org
  2014-03-12 21:33 ` [Bug libstdc++/60270] " redi at gcc dot gnu.org
  2014-03-31 18:47 ` redi at gcc dot gnu.org
  0 siblings, 2 replies; 3+ messages in thread
From: redi at gcc dot gnu.org @ 2014-02-19 10:33 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60270

            Bug ID: 60270
           Summary: [C++1y] std::quoted is too eager to clear the string
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: redi at gcc dot gnu.org

Lars Gullik Bjønnes pointed out that we clear the string too early in
std::quoted, which causes this to fail:

#include <string>
#include <sstream>
#include <iomanip>
#include <cassert>

int main()
{
  std::istringstream in;
  std::string s = "xxx";
  in >> s;
  assert( !s.empty() );
  in >> std::quoted(s);
  assert( !s.empty() );  // fails
}
>From gcc-bugs-return-444192-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Feb 19 10:44:52 2014
Return-Path: <gcc-bugs-return-444192-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 20149 invoked by alias); 19 Feb 2014 10:44:51 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 20127 invoked by uid 48); 19 Feb 2014 10:44:47 -0000
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/60271] New: [C++1y] std::max(initializer_list<T>) cannot use std::max_element
Date: Wed, 19 Feb 2014 10:44:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: redi at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-60271-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-02/txt/msg01949.txt.bz2
Content-length: 644

http://gcc.gnu.org/bugzilla/show_bug.cgi?id`271

            Bug ID: 60271
           Summary: [C++1y] std::max(initializer_list<T>) cannot use
                    std::max_element
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: redi at gcc dot gnu.org

http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n3893.html#2350
(approved in Issaquah) adds constexpr to std::max(initializer_list<T>), which
means we can't use std::max_element to implement it.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug libstdc++/60270] [C++1y] std::quoted is too eager to clear the string
  2014-02-19 10:33 [Bug libstdc++/60270] New: [C++1y] std::quoted is too eager to clear the string redi at gcc dot gnu.org
@ 2014-03-12 21:33 ` redi at gcc dot gnu.org
  2014-03-31 18:47 ` redi at gcc dot gnu.org
  1 sibling, 0 replies; 3+ messages in thread
From: redi at gcc dot gnu.org @ 2014-03-12 21:33 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60270

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2014-03-12
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Approved patch:
http://gcc.gnu.org/ml/gcc-patches/2014-02/msg01275.html


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug libstdc++/60270] [C++1y] std::quoted is too eager to clear the string
  2014-02-19 10:33 [Bug libstdc++/60270] New: [C++1y] std::quoted is too eager to clear the string redi at gcc dot gnu.org
  2014-03-12 21:33 ` [Bug libstdc++/60270] " redi at gcc dot gnu.org
@ 2014-03-31 18:47 ` redi at gcc dot gnu.org
  1 sibling, 0 replies; 3+ messages in thread
From: redi at gcc dot gnu.org @ 2014-03-31 18:47 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60270

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Mon Mar 31 18:46:23 2014
New Revision: 208966

URL: http://gcc.gnu.org/viewcvs?rev=208966&root=gcc&view=rev
Log:
2014-03-31  Lars Gullik Bjønnes  <larsbj@gullik.org>
        Jonathan Wakely  <jwakely@redhat.com>

    PR libstdc++/60270
    * include/std/iomanip (_Quoted_string operator>>): Do not clear
    string if input is not quoted.
    * testsuite/27_io/manipulators/standard/char/60270.cc: New.

Added:
    trunk/libstdc++-v3/testsuite/27_io/manipulators/standard/char/60270.cc
Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/std/iomanip
>From gcc-bugs-return-447975-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Mar 31 18:47:49 2014
Return-Path: <gcc-bugs-return-447975-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 32629 invoked by alias); 31 Mar 2014 18:47:49 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 32084 invoked by uid 48); 31 Mar 2014 18:47:44 -0000
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/60270] [C++1y] std::quoted is too eager to clear the string
Date: Mon, 31 Mar 2014 18:47:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords: patch
X-Bugzilla-Severity: normal
X-Bugzilla-Who: redi at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: redi at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution
Message-ID: <bug-60270-4-FtR4bvNYy3@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-60270-4@http.gcc.gnu.org/bugzilla/>
References: <bug-60270-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-03/txt/msg02844.txt.bz2
Content-length: 422

http://gcc.gnu.org/bugzilla/show_bug.cgi?id`270

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
fixed


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-03-31 18:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-19 10:33 [Bug libstdc++/60270] New: [C++1y] std::quoted is too eager to clear the string redi at gcc dot gnu.org
2014-03-12 21:33 ` [Bug libstdc++/60270] " redi at gcc dot gnu.org
2014-03-31 18:47 ` redi at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).