public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/60272] atomic<>::compare_exchange_weak has spurious store and can cause race conditions Date: Wed, 19 Feb 2014 12:27:00 -0000 [thread overview] Message-ID: <bug-60272-4-Rvxkvxkamn@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-60272-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60272 Jakub Jelinek <jakub at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jakub at gcc dot gnu.org, | |rth at gcc dot gnu.org, | |torvald at gcc dot gnu.org --- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> --- Even our __atomic_compare_exchange* documentation states that: If they are not equal, the current contents of @code{*@var{ptr}} is written into @code{*@var{expected}}. But then expand_builtin_atomic_compare_exchange doesn't care: oldval = expect; if (!expand_atomic_compare_and_swap ((target == const0_rtx ? NULL : &target), &oldval, mem, oldval, desired, is_weak, success, failure)) return NULL_RTX; if (oldval != expect) emit_move_insn (expect, oldval); That effectively means that expect will be stored unconditionally. So, either we'd need to change this function, so that it sets oldval to NULL_RTX first, and passes ..., &oldval, mem, expected, ... and needs to also always ask for target, then conditionally on target store to expected, or perhaps add extra parameter to expand_atomic_compare_and_swap and do the store only conditionally in that case. Richard/Torvald?
next prev parent reply other threads:[~2014-02-19 12:27 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-02-19 11:04 [Bug c++/60272] New: " anthony.ajw at gmail dot com 2014-02-19 11:19 ` [Bug c++/60272] " redi at gcc dot gnu.org 2014-02-19 12:27 ` jakub at gcc dot gnu.org [this message] 2014-02-19 18:19 ` torvald at gcc dot gnu.org 2014-02-19 18:34 ` rth at gcc dot gnu.org 2014-02-20 17:44 ` rth at gcc dot gnu.org 2014-02-21 0:12 ` rth at gcc dot gnu.org 2014-02-21 0:14 ` rth at gcc dot gnu.org 2014-02-21 0:17 ` rth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-60272-4-Rvxkvxkamn@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).