[Bug c++/60347] New: [4.9 Regression] r208152 breaks Firefox build

[Bug c++/60347] New: [4.9 Regression] r208152 breaks Firefox build

[trippels at gcc dot gnu.org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 4005 bytes --]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60347

            Bug ID: 60347
           Summary: [4.9 Regression] r208152 breaks Firefox build
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: trippels at gcc dot gnu.org
                CC: jason at gcc dot gnu.org

markus@x4 html % g++ -c -w -march=amdfam10 -std=gnu++0x -O2
Unified_cpp_parser_html1.ii
In file included from ../../dist/include/nsHashKeys.h:12:0,
                 from
/var/tmp/mozilla-central/parser/html/nsHtml5AtomTable.h:8,
                 from
/var/tmp/mozilla-central/parser/html/nsHtml5AttributeName.h:32,
                 from
/var/tmp/mozilla-central/parser/html/nsHtml5ReleasableAttributeName.h:8,
                 from
/var/tmp/mozilla-central/parser/html/nsHtml5ReleasableAttributeName.cpp:5,
                 from
/var/tmp/moz-build-dir/parser/html/Unified_cpp_parser_html1.cpp:2:
../../dist/include/nsAutoPtr.h: In instantiation of ‘nsRefPtr<T>::~nsRefPtr()
[with T = mozilla::dom::ShadowRoot]’:
/var/tmp/mozilla-central/parser/html/../../content/base/src/nsGenericDOMDataNode.h:247:9:
  required from here
../../dist/include/nsAutoPtr.h:900:13: error: invalid use of incomplete type
‘class mozilla::dom::ShadowRoot’
             mRawPtr->Release();
             ^
In file included from
/var/tmp/mozilla-central/parser/html/nsHtml5AttributeName.h:35:0,
                 from
/var/tmp/mozilla-central/parser/html/nsHtml5ReleasableAttributeName.h:8,
                 from
/var/tmp/mozilla-central/parser/html/nsHtml5ReleasableAttributeName.cpp:5,
                 from
/var/tmp/moz-build-dir/parser/html/Unified_cpp_parser_html1.cpp:2:
../../dist/include/nsIContent.h:25:7: error: forward declaration of ‘class
mozilla::dom::ShadowRoot’
 class ShadowRoot;
       ^
>From gcc-bugs-return-444875-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Feb 26 19:24:54 2014
Return-Path: <gcc-bugs-return-444875-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 17929 invoked by alias); 26 Feb 2014 19:24:54 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 17899 invoked by uid 48); 26 Feb 2014 19:24:51 -0000
From: "trippels at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/60347] [4.9 Regression] r208152 breaks Firefox build
Date: Wed, 26 Feb 2014 19:24:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: trippels at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: attachments.created
Message-ID: <bug-60347-4-gMFG37c29J@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-60347-4@http.gcc.gnu.org/bugzilla/>
References: <bug-60347-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-02/txt/msg02632.txt.bz2
Content-length: 240

http://gcc.gnu.org/bugzilla/show_bug.cgi?id`347

--- Comment #1 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
Created attachment 32219
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id2219&actioníit
Unreduced testcase

[Bug c++/60347] [4.9 Regression] r208153 breaks Firefox build

[trippels at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60347

Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.9 Regression] r208152    |[4.9 Regression] r208153
                   |breaks Firefox build        |breaks Firefox build

--- Comment #2 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
Sorry off by one in revision. 
It started with r208153.

[Bug c++/60347] [4.9 Regression] r208153 breaks Firefox build

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60347

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2014-02-26
           Assignee|unassigned at gcc dot gnu.org      |jason at gcc dot gnu.org
     Ever confirmed|0                           |1

[Bug c++/60347] [4.9 Regression] r208153 breaks Firefox build

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60347

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2014-02-26
           Assignee|unassigned at gcc dot gnu.org      |jason at gcc dot gnu.org
     Ever confirmed|0                           |1

[Bug c++/60347] [4.9 Regression] r208153 breaks Firefox build

[trippels at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60347

Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P1                          |P3
             Status|ASSIGNED                    |UNCONFIRMED
   Last reconfirmed|2014-02-26 00:00:00         |
           Assignee|jason at gcc dot gnu.org           |unassigned at gcc dot gnu.org
     Ever confirmed|1                           |0

--- Comment #3 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
markus@x4 html % cat test.ii
template <class T> class nsRefPtr {
  T *mRawPtr;

public:
  typedef T element_type;
  ~nsRefPtr() { mRawPtr->Release; }
};

class nsSlots {
public:
  virtual ~nsSlots();
};
class A;
class B : nsSlots {
  nsRefPtr<A> mContainingShadow;
};

markus@x4 html % g++ -O2 -c test.ii
test.ii: In instantiation of ‘nsRefPtr<T>::~nsRefPtr() [with T = A]’:
test.ii:14:7:   required from here
test.ii:6:17: error: invalid use of incomplete type ‘class A’
   ~nsRefPtr() { mRawPtr->Release; }
                 ^
test.ii:13:7: error: forward declaration of ‘class A’
 class A;
       ^
>From gcc-bugs-return-444891-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Feb 26 20:47:48 2014
Return-Path: <gcc-bugs-return-444891-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 31492 invoked by alias); 26 Feb 2014 20:47:47 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 31438 invoked by uid 48); 26 Feb 2014 20:47:44 -0000
From: "hjl.tools at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/60336] empty struct value is passed differently in C and C++
Date: Wed, 26 Feb 2014 20:47:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.8.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: hjl.tools at gmail dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-60336-4-WbExiWmMc8@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-60336-4@http.gcc.gnu.org/bugzilla/>
References: <bug-60336-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-02/txt/msg02648.txt.bz2
Content-length: 755

http://gcc.gnu.org/bugzilla/show_bug.cgi?id`336

--- Comment #14 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to H.J. Lu from comment #13)
> Passing
>
> struct dummy { };
>
> is still odd for g++.  It is supposed to have a single member of type char,
> which should be passed in register, not on stack.

This passes it in register:

diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
index 00773d8..6975ff1 100644
--- a/gcc/config/i386/i386.c
+++ b/gcc/config/i386/i386.c
@@ -6613,6 +6613,8 @@ classify_argument (enum machine_mode mode, const_tree
type,
         return 0;
       }
   }
+      if (mode == QImode && words == 1 && classes[0] == X86_64_NO_CLASS)
+  classes[0] = X86_64_INTEGERSI_CLASS;
       return words;
     }

[Bug c++/60347] [4.9 Regression] r208153 breaks Firefox build

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60347

--- Comment #4 from Jason Merrill <jason at gcc dot gnu.org> ---
Author: jason
Date: Wed Feb 26 21:32:41 2014
New Revision: 208184

URL: http://gcc.gnu.org/viewcvs?rev=208184&root=gcc&view=rev
Log:
    PR c++/60347
    PR lto/53808
    * class.c (clone_function_decl): Don't note_vague_linkage_fn.
    * init.c (build_vtbl_address): Do it here.

Added:
    trunk/gcc/testsuite/g++.dg/template/dtor9.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/class.c
    trunk/gcc/cp/init.c

[Bug c++/60347] [4.9 Regression] r208153 breaks Firefox build

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60347

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |4.9.0

--- Comment #5 from Jason Merrill <jason at gcc dot gnu.org> ---
Fixed.

[Bug c++/60347] [4.9 Regression] r208153 breaks Firefox build

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60347

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
Maybe add the testcases to the testsuite?

[Bug c++/60347] [4.9 Regression] r208153 breaks Firefox build

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60347

--- Comment #7 from Jason Merrill <jason at gcc dot gnu.org> ---
I did add a testcase, which is not significantly different from the one in
comment #3.