[Bug c/60351] New: Incorrect column number for warning on "right shift count is negative"

[Bug c/60351] New: Incorrect column number for warning on "right shift count is negative"

[chengniansun at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60351

            Bug ID: 60351
           Summary: Incorrect column number for warning on "right shift
                    count is negative"
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: chengniansun at gmail dot com

$: cat s.c 
void g(int);
void f(void) {
    int i = 1;
    g(      i>>-1);
}
$: gcc-trunk -c s.c 
s.c: In function ‘f’:
s.c:4:2: warning: right shift count is negative
  g(      i>>-1);
  ^
$:
>From gcc-bugs-return-444915-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Feb 27 00:37:18 2014
Return-Path: <gcc-bugs-return-444915-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 19235 invoked by alias); 27 Feb 2014 00:37:18 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 19179 invoked by uid 48); 27 Feb 2014 00:37:12 -0000
From: "richlowe at richlowe dot net" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/53902] make install fails on SunOS 5.11
Date: Thu, 27 Feb 2014 00:37:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: bootstrap
X-Bugzilla-Version: 4.7.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: richlowe at richlowe dot net
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-53902-4-iCiUOMq1o0@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-53902-4@http.gcc.gnu.org/bugzilla/>
References: <bug-53902-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-02/txt/msg02672.txt.bz2
Content-length: 617

http://gcc.gnu.org/bugzilla/show_bug.cgi?idS902

Rich Lowe <richlowe at richlowe dot net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |richlowe at richlowe dot net

--- Comment #7 from Rich Lowe <richlowe at richlowe dot net> ---
I'm pretty sure this is a result of using an older binutils.  As best as I can
tell, s11 shipped with 2.19, and s11u1 with 2.21.  I know that 2.19 will fail
in this manner, and that 2.22 appears to work.  I have not personally tried
2.21

[Bug c/60351] Incorrect column number for warning on "right shift count is negative"

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60351

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2014-02-27
                 CC|                            |mpolacek at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |mpolacek at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #1 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Mine.

[Bug c/60351] Incorrect column number for warning on "right shift count is negative"

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60351

--- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Wed Apr 30 06:08:17 2014
New Revision: 209925

URL: http://gcc.gnu.org/viewcvs?rev=209925&root=gcc&view=rev
Log:
    PR c/60351
    * c-typeck.c (build_binary_op): Use location when warning about
    shift count.

    * gcc.dg/pr60351.c: New test.

Added:
    trunk/gcc/testsuite/gcc.dg/pr60351.c
Modified:
    trunk/gcc/c/ChangeLog
    trunk/gcc/c/c-typeck.c
    trunk/gcc/testsuite/ChangeLog

[Bug c/60351] Incorrect column number for warning on "right shift count is negative"

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60351

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Fixed.