From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id CDFEA3858D35; Tue, 23 May 2023 12:14:11 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CDFEA3858D35
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1684844051;
	bh=jX9wfoVtbM9Ekugorg5ls0kq5zFv4ZT7yHpy/T1jJbM=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=cVA8nf5Qz0eOQ/kvGifNYzMyk7f6Td86zkn0QNlZt3XE+6mYjdSv21eC8+HpfB1uK
	 vTu7q+UORs1L+FZR+pzUhkUctex4zt8gQ6hT6iy51zDc5I7MwAwL8JDuUq/Z2Isb/P
	 YPH2HhzZ/yWi/65WJlAMszuFtoEMxfvM1lSXoQ9I=
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/60441] Incorrect textual representation for
 std::mersenne_twister_engine
Date: Tue, 23 May 2023 12:14:11 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 4.8.1
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: redi at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cf_reconfirmed_on
Message-ID: <bug-60441-4-acK9aAJp49@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-60441-4@http.gcc.gnu.org/bugzilla/>
References: <bug-60441-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D60441

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2018-08-07 00:00:00         |2023-5-23

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
The fix is quite simple, but it breaks compatibility between releases:

diff --git a/libstdc++-v3/include/bits/random.tcc
b/libstdc++-v3/include/bits/random.tcc
index 24a5987db0d..8f53d5c5f53 100644
--- a/libstdc++-v3/include/bits/random.tcc
+++ b/libstdc++-v3/include/bits/random.tcc
@@ -486,9 +486,10 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
       __os.flags(__ios_base::dec | __ios_base::fixed | __ios_base::left);
       __os.fill(__space);

-      for (size_t __i =3D 0; __i < __n; ++__i)
+      for (size_t __i =3D __x._M_p; __i < __n; ++__i)
+       __os << __x._M_x[__i] << __space;
+      for (size_t __i =3D 0; __i < __x._M_p; ++__i)
        __os << __x._M_x[__i] << __space;
-      __os << __x._M_p;

       __os.flags(__flags);
       __os.fill(__fill);
@@ -512,7 +513,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION

       for (size_t __i =3D 0; __i < __n; ++__i)
        __is >> __x._M_x[__i];
-      __is >> __x._M_p;
+      __x._M_p =3D 0;

       __is.flags(__flags);
       return __is;=