[Bug c++/60516] New: cc1plus crashes compiling a method with a huge struct as argument

[Bug c++/60516] New: cc1plus crashes compiling a method with a huge struct as argument

[zaskar_84 at yahoo dot com.ar]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60516

            Bug ID: 60516
           Summary: cc1plus crashes compiling a method with a huge struct
                    as argument
           Product: gcc
           Version: 4.8.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zaskar_84 at yahoo dot com.ar

cc1plus crashes when trying to compile a class method that receives a very big
argument (a 65kb struct) in Windows (reproducible with mingw32, no problems on
linux versions). I know that we are not supposed to make so big static
variables, but the compiler should compile and let the resulting program crash
or complaint about that instead of crashing itself. Here's the minimal code
that generates the error:

    struct huge {
        char c[256][256]; 
    };
    class Bar {
        void foo(huge x);
    };
    void Bar::foo (huge x) {
    }

I've noted that there's no problem if the method is implemented inline.

And here are versions and compiler output

    C:\Users\usuario\Desktop>g++ --version
    g++ (GCC) 4.8.1
    Copyright (C) 2013 Free Software Foundation, Inc.
    This is free software; see the source for copying conditions.  There is NO
    warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

    C:\Users\usuario\Desktop>ld -v
    GNU ld (GNU Binutils) 2.24

    C:\Users\usuario\Desktop>g++ -c problema_mingw.cpp
    problema_mingw.cpp: In member function 'void
GestionMaquina::AgregarMaquina(Maquinas)':
    problema_mingw.cpp:11:1: internal compiler error: Segmentation fault
     }
     ^

    This application has requested the Runtime to terminate it in an unusual
way.
    Please contact the application's support team for more information.

    problema_mingw.cpp:11:1: internal compiler error: Aborted

    This application has requested the Runtime to terminate it in an unusual
way.
    Please contact the application's support team for more information.
    g++: internal compiler error: Aborted (program cc1plus)
    libbacktrace could not find executable to open
    Please submit a full bug report,
    with preprocessed source if appropriate.
    See <http://gcc.gnu.org/bugs.html> for instructions.

Tested on win7 ultimate 64bits, g++ was mannually installed, just by
decompressing the following packages from mingw32:
binutils-2.24-1-mingw32-bin.tar.xz expat-2.1.0-1-mingw32-dll.tar
gcc-c++-4.8.1-4-mingw32-bin.tar gcc-c++-4.8.1-4-mingw32-dll.tar
gcc-core-4.8.1-4-mingw32-bin.tar gcc-core-4.8.1-4-mingw32-dll.tar
gdb-7.6.1-1-mingw32-bin.tar gmp-5.1.2-1-mingw32-dll.tar
libiconv-1.14-3-mingw32-dll.tar mingwrt-4.0.3-1-mingw32-dev.tar
mingwrt-4.0.3-1-mingw32-dll.tar mpc-1.0.1-2-mingw32-dll.tar
mpfr-3.1.2-2-mingw32-dll.tar w32api-4.0.3-1-mingw32-dev.tar

The same problem was reproduce by someone else with 4.8.2, see
http://sourceforge.net/p/mingw/bugs/2195/

[Bug c++/60516] [4.9/4.8 regression]: cc1plus crashes compiling a method with a huge struct as argument

[ktietz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60516

Kai Tietz <ktietz at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

[Bug c++/60516] [4.9/4.8 regression]: cc1plus crashes compiling a method with a huge struct as argument

[ktietz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60516

Kai Tietz <ktietz at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-03-16
                 CC|                            |ktietz at gcc dot gnu.org
            Summary|cc1plus crashes compiling a |[4.9/4.8 regression]:
                   |method with a huge struct   |cc1plus crashes compiling a
                   |as argument                 |method with a huge struct
                   |                            |as argument
     Ever confirmed|0                           |1

--- Comment #2 from Kai Tietz <ktietz at gcc dot gnu.org> ---
Confirmed.

[Bug c++/60516] [4.9/4.8 regression]: cc1plus crashes compiling a method with a huge struct as argument

[ktietz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60516

--- Comment #3 from Kai Tietz <ktietz at gcc dot gnu.org> ---
Issue is that copy_rtx gets feed with invalid insn.

As (gdb) fr 1
#1  0x007ce0bf in ix86_expand_epilogue (style=style@entry=1)
    at ../../gcc/gcc/config/i386/i386.c:11712
11712                           copy_rtx (XVECEXP (PATTERN (insn), 0, 1)));
(gdb) call debug_rtx(insn)
(insn 15 14 0 (set (reg:SI 2 cx)
        (mem:SI (post_inc:SI (reg/f:SI 7 sp)) [0  S4 A8])) -1
     (nil))
(gdb) print (insn->u.fld[4]).rt_rtx
$2 = (rtx) 0xffe25630
(gdb) call debug_rtx((insn->u.fld[4]).rt_rtx)
(set (reg:SI 2 cx)
    (mem:SI (post_inc:SI (reg/f:SI 7 sp)) [0  S4 A8]))
(gdb) print ((insn->u.fld[4]).rt_rtx->u.fld[0]).rt_rtvec->elem[1]
$3 = (rtx_def *) 0x2

[Bug c++/60516] [4.9/4.8 regression]: cc1plus crashes compiling a method with a huge struct as argument

[mikpelinux at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60516

--- Comment #4 from Mikael Pettersson <mikpelinux at gmail dot com> ---
Started with r171890.

[Bug target/60516] [4.7/4.8/4.9 regression]: cc1plus crashes compiling a method with a huge struct as argument

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60516

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jakub at gcc dot gnu.org
          Component|c++                         |target
   Target Milestone|---                         |4.7.4
            Summary|[4.9/4.8 regression]:       |[4.7/4.8/4.9 regression]:
                   |cc1plus crashes compiling a |cc1plus crashes compiling a
                   |method with a huge struct   |method with a huge struct
                   |as argument                 |as argument

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Kai Tietz from comment #3)
> Issue is that copy_rtx gets feed with invalid insn.

No, it is fed completely valid insn, but just the note creation hasn't been
adjusted for the r163679 change.

(In reply to Mikael Pettersson from comment #4)
> Started with r171890.

With an improved C testcase actually with r163679.

struct S { char c[65536]; };

__attribute__((ms_abi, thiscall)) void
foo (void *x, struct S y)
{
}

[Bug target/60516] [4.7/4.8/4.9 regression]: cc1plus crashes compiling a method with a huge struct as argument

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60516

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 32367
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32367&action=edit
gcc49-pr60516.patch

Untested fix.

[Bug target/60516] [4.7/4.8/4.9 regression]: cc1plus crashes compiling a method with a huge struct as argument

[ktietz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60516

--- Comment #7 from Kai Tietz <ktietz at gcc dot gnu.org> ---
Thanks for the patch.  I am about to do a full-regression test for it.  This
will take some time.
Quick test has shown that issue isn't 'thiscall' specific at all.  stdcall, and
fastcall calling-convention do have the same issues. So I would suggest to add
these two testcases to the patch, too.

/* PR target/60516 */
/* { dg-do compile } */
/* { dg-options "-O2" } */
struct S { char c[65536]; };

__attribute__((ms_abi, thiscall)) void
foo (void *x, struct S y)
{
}

--------------------

/* PR target/60516 */
/* { dg-do compile } */
/* { dg-options "-O2" } */
struct S { char c[65536]; };

__attribute__((ms_abi, fastcall)) void
foo (void *x, void *xx, struct S y)
{
}

[Bug target/60516] [4.7/4.8/4.9 regression]: cc1plus crashes compiling a method with a huge struct as argument

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60516

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32367|0                           |1
        is obsolete|                            |

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 32368
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32368&action=edit
gcc49-pr60516.patch

Ok, testcase adjusted.

[Bug target/60516] [4.7/4.8/4.9 regression]: cc1plus crashes compiling a method with a huge struct as argument

[ktietz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60516

--- Comment #9 from Kai Tietz <ktietz at gcc dot gnu.org> ---
Did regression-test for 32-bit mingw for C, C++, and Fortran.  No new
regressions occurred.
So patch is from my POV ok for trunk and branches

[Bug target/60516] [4.7/4.8/4.9 regression]: cc1plus crashes compiling a method with a huge struct as argument

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60516

--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Mon Mar 17 19:03:04 2014
New Revision: 208623

URL: http://gcc.gnu.org/viewcvs?rev=208623&root=gcc&view=rev
Log:
    PR target/60516
    * config/i386/i386.c (ix86_expand_epilogue): Adjust REG_CFA_ADJUST_CFA
    note creation for the 2010-08-31 changes.

    * gcc.target/i386/pr60516.c: New test.

Added:
    trunk/gcc/testsuite/gcc.target/i386/pr60516.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/i386.c
    trunk/gcc/testsuite/ChangeLog

[Bug target/60516] [4.7/4.8 regression]: cc1plus crashes compiling a method with a huge struct as argument

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60516

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.7/4.8/4.9 regression]:   |[4.7/4.8 regression]:
                   |cc1plus crashes compiling a |cc1plus crashes compiling a
                   |method with a huge struct   |method with a huge struct
                   |as argument                 |as argument

--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed on the trunk so far.

[Bug target/60516] [4.7/4.8 regression]: cc1plus crashes compiling a method with a huge struct as argument

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60516

--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Thu Apr 10 07:49:02 2014
New Revision: 209264

URL: http://gcc.gnu.org/viewcvs?rev=209264&root=gcc&view=rev
Log:
    Backport from mainline
    2014-03-17  Jakub Jelinek  <jakub@redhat.com>

    PR target/60516
    * config/i386/i386.c (ix86_expand_epilogue): Adjust REG_CFA_ADJUST_CFA
    note creation for the 2010-08-31 changes.

    * gcc.target/i386/pr60516.c: New test.

Added:
    branches/gcc-4_8-branch/gcc/testsuite/gcc.target/i386/pr60516.c
Modified:
    branches/gcc-4_8-branch/gcc/ChangeLog
    branches/gcc-4_8-branch/gcc/config/i386/i386.c
    branches/gcc-4_8-branch/gcc/testsuite/ChangeLog

[Bug target/60516] [4.7 regression]: cc1plus crashes compiling a method with a huge struct as argument

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60516

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.7/4.8 regression]:       |[4.7 regression]: cc1plus
                   |cc1plus crashes compiling a |crashes compiling a method
                   |method with a huge struct   |with a huge struct as
                   |as argument                 |argument

--- Comment #13 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed also for 4.8.3+.

[Bug target/60516] [4.7 regression]: cc1plus crashes compiling a method with a huge struct as argument

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60516

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Known to work|                            |4.8.3
         Resolution|---                         |FIXED
   Target Milestone|4.7.4                       |4.8.3
      Known to fail|                            |4.7.4

--- Comment #14 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed for 4.8.3.