[Bug libstdc++/60519] Debug mode should check comparators for irreflexivity

["fdumont at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60519

--- Comment #5 from François Dumont <fdumont at gcc dot gnu.org> ---
Author: fdumont
Date: Tue Aug 25 20:27:03 2015
New Revision: 227189

URL: https://gcc.gnu.org/viewcvs?rev=227189&root=gcc&view=rev
Log:
2015-08-24  François Dumont  <fdumont@gcc.gnu.org>

        PR libstdc++/60519
        * include/debug/formatter.h
(_Debug_msg_id::__msg_irreflexive_ordering):
        New enum entry.
        * include/debug/functions.h (_Irreflexive_checker): New.
        (__is_irreflexive, __is_irreflexive_pred): New.
        * include/debug/macros.h
        (__glibcxx_check_irreflexive, __glibcxx_check_irreflexive_pred): New
        macros.
        (__glibcxx_check_irreflexive2, __glibcxx_check_irreflexive_pred2): New
        macros limited to post-C++11 mode.
        * include/debug/debug.h
        (__glibcxx_requires_irreflexive, __glibcxx_requires_irreflexive_pred):
        New macros, use latter.
        (__glibcxx_requires_irreflexive2,
__glibcxx_requires_irreflexive_pred2):
        Likewise.
        * include/bits/stl_algo.h
        (partial_sort_copy): Add irreflexive debug check.
        (partial_sort_copy): Likewise.
        (lower_bound): Likewise.
        (upper_bound): Likewise.
        (equal_range): Likewise.
        (binary_search): Likewise.
        (inplace_merge): Likewise.
        (includes): Likewise.
        (next_permutation): Likewise.
        (prev_permutation): Likewise.
        (is_sorted_until): Likewise.
        (minmax_element): Likewise.
        (partial_sort): Likewise.
        (nth_element): Likewise.
        (sort): Likewise.
        (merge): Likewise.
        (stable_sort): Likewise.
        (set_union): Likewise.
        (set_intersection): Likewise.
        (set_difference): Likewise.
        (set_symmetric_difference): Likewise.
        (min_element): Likewise.
        (max_element): Likewise.
        * include/bits/stl_algobase.h
        (lower_bound): Likewise.
        (lexicographical_compare): Likewise.
        * include/bits/stl_heap.h
        (push_heap): Likewise.
        (pop_heap): Likewise.
        (make_heap): Likewise.
        (sort_heap): Likewise.
        (is_heap_until): Likewise.
        * testsuite/25_algorithms/lexicographical_compare/debug/
        irreflexive_neg.cc: New.
        * testsuite/25_algorithms/lower_bound/debug/irreflexive.cc: New.
        * testsuite/25_algorithms/partial_sort_copy/debug/irreflexive_neg.cc:
        New.

Added:
    trunk/libstdc++-v3/testsuite/25_algorithms/lexicographical_compare/debug/
   
trunk/libstdc++-v3/testsuite/25_algorithms/lexicographical_compare/debug/irreflexive_neg.cc
    trunk/libstdc++-v3/testsuite/25_algorithms/lower_bound/debug/
    trunk/libstdc++-v3/testsuite/25_algorithms/lower_bound/debug/irreflexive.cc
    trunk/libstdc++-v3/testsuite/25_algorithms/partial_sort_copy/debug/
   
trunk/libstdc++-v3/testsuite/25_algorithms/partial_sort_copy/debug/irreflexive_neg.cc
Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/bits/stl_algo.h
    trunk/libstdc++-v3/include/bits/stl_algobase.h
    trunk/libstdc++-v3/include/bits/stl_heap.h
    trunk/libstdc++-v3/include/debug/debug.h
    trunk/libstdc++-v3/include/debug/formatter.h
    trunk/libstdc++-v3/include/debug/functions.h
    trunk/libstdc++-v3/include/debug/macros.h
    trunk/libstdc++-v3/src/c++11/debug.cc
>From gcc-bugs-return-495647-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Aug 25 20:29:35 2015
Return-Path: <gcc-bugs-return-495647-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 11275 invoked by alias); 25 Aug 2015 20:29:35 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 11225 invoked by uid 55); 25 Aug 2015 20:29:31 -0000
From: "mpolacek at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/67330] ICE handling weak attributes
Date: Tue, 25 Aug 2015 20:29:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords: ice-on-invalid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: mpolacek at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: mpolacek at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 6.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-67330-4-7UvF0MzmkU@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-67330-4@http.gcc.gnu.org/bugzilla/>
References: <bug-67330-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-08/txt/msg01789.txt.bz2
Content-length: 718

https://gcc.gnu.org/bugzilla/show_bug.cgi?idg330

--- Comment #6 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Tue Aug 25 20:28:59 2015
New Revision: 227190

URL: https://gcc.gnu.org/viewcvs?rev"7190&root=gcc&view=rev
Log:
        PR middle-end/67330
        * varasm.c (declare_weak): Return after giving an error.

        * c-common.c (handle_weak_attribute): Don't check whether the
        visibility can be changed here.

        * gcc.dg/weak/weak-18.c: New test.

Added:
    trunk/gcc/testsuite/gcc.dg/weak/weak-18.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/c-family/ChangeLog
    trunk/gcc/c-family/c-common.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/varasm.c