public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug middle-end/60534] New: ICE: in expand_GOMP_SIMD_VF, at internal-fn.c:142 with -fopenmp -O -fno-tree-loop-optimize and #pragma omp simd reduction
@ 2014-03-15  8:15 zsojka at seznam dot cz
  2014-03-17  8:19 ` [Bug middle-end/60534] " mpolacek at gcc dot gnu.org
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: zsojka at seznam dot cz @ 2014-03-15  8:15 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60534

            Bug ID: 60534
           Summary: ICE: in expand_GOMP_SIMD_VF, at internal-fn.c:142 with
                    -fopenmp -O -fno-tree-loop-optimize and #pragma omp
                    simd reduction
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz

Created attachment 32358
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32358&action=edit
reduced testcase

Compiler output:
$ gcc -fopenmp -O -fno-tree-loop-optimize testcase.c         
testcase.c: In function 'foo':
testcase.c:4:1: internal compiler error: in expand_GOMP_SIMD_VF, at
internal-fn.c:142
 foo (int a)
 ^
0x946367 expand_GOMP_SIMD_VF
        /mnt/svn/gcc-trunk/gcc/internal-fn.c:142
0x7561f9 expand_call_stmt
        /mnt/svn/gcc-trunk/gcc/cfgexpand.c:2190
0x7561f9 expand_gimple_stmt_1
        /mnt/svn/gcc-trunk/gcc/cfgexpand.c:3160
0x7561f9 expand_gimple_stmt
        /mnt/svn/gcc-trunk/gcc/cfgexpand.c:3312
0x757667 expand_gimple_basic_block
        /mnt/svn/gcc-trunk/gcc/cfgexpand.c:5152
0x759a0e gimple_expand_cfg
        /mnt/svn/gcc-trunk/gcc/cfgexpand.c:5731
0x759a0e execute
        /mnt/svn/gcc-trunk/gcc/cfgexpand.c:5951
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.

Tested revisions:
r208561 - ICE
4.8 - ignoring #pragma omp simd


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug middle-end/60534] ICE: in expand_GOMP_SIMD_VF, at internal-fn.c:142 with -fopenmp -O -fno-tree-loop-optimize and #pragma omp simd reduction
  2014-03-15  8:15 [Bug middle-end/60534] New: ICE: in expand_GOMP_SIMD_VF, at internal-fn.c:142 with -fopenmp -O -fno-tree-loop-optimize and #pragma omp simd reduction zsojka at seznam dot cz
@ 2014-03-17  8:19 ` mpolacek at gcc dot gnu.org
  2014-03-17  8:23 ` mpolacek at gcc dot gnu.org
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-03-17  8:19 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60534

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-03-17
                 CC|                            |mpolacek at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #1 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Confirmed.  expand_omp_simd has for this case:

 6837       /* If not -fno-tree-loop-vectorize, hint that we want to vectorize
 6838          the loop.  */
 6839       if ((flag_tree_loop_vectorize
 6840            || (!global_options_set.x_flag_tree_loop_vectorize
 6841                && !global_options_set.x_flag_tree_vectorize))
 6842           && loop->safelen > 1)
 6843         {
 6844           loop->force_vect = true;
 6845           cfun->has_force_vect_loops = true;
 6846         }

but gate_tree_loop_vectorize isn't called at all, because gate_tree_loop
returns false.  So maybe:

--- gcc/tree-ssa-loop.c
+++ gcc/tree-ssa-loop.c
@@ -47,7 +47,7 @@ along with GCC; see the file COPYING3.  If not see
 static bool
 gate_tree_loop (void)
 {
-  return flag_tree_loop_optimize != 0;
+  return flag_tree_loop_optimize != 0 || cfun->has_force_vect_loops;
 }

 namespace {


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug middle-end/60534] ICE: in expand_GOMP_SIMD_VF, at internal-fn.c:142 with -fopenmp -O -fno-tree-loop-optimize and #pragma omp simd reduction
  2014-03-15  8:15 [Bug middle-end/60534] New: ICE: in expand_GOMP_SIMD_VF, at internal-fn.c:142 with -fopenmp -O -fno-tree-loop-optimize and #pragma omp simd reduction zsojka at seznam dot cz
  2014-03-17  8:19 ` [Bug middle-end/60534] " mpolacek at gcc dot gnu.org
@ 2014-03-17  8:23 ` mpolacek at gcc dot gnu.org
  2014-03-17  9:03 ` jakub at gcc dot gnu.org
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-03-17  8:23 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60534

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |mpolacek at gcc dot gnu.org


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug middle-end/60534] ICE: in expand_GOMP_SIMD_VF, at internal-fn.c:142 with -fopenmp -O -fno-tree-loop-optimize and #pragma omp simd reduction
  2014-03-15  8:15 [Bug middle-end/60534] New: ICE: in expand_GOMP_SIMD_VF, at internal-fn.c:142 with -fopenmp -O -fno-tree-loop-optimize and #pragma omp simd reduction zsojka at seznam dot cz
  2014-03-17  8:19 ` [Bug middle-end/60534] " mpolacek at gcc dot gnu.org
  2014-03-17  8:23 ` mpolacek at gcc dot gnu.org
@ 2014-03-17  9:03 ` jakub at gcc dot gnu.org
  2014-03-17 14:16 ` mpolacek at gcc dot gnu.org
  2014-03-17 14:18 ` mpolacek at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: jakub at gcc dot gnu.org @ 2014-03-17  9:03 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60534

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
No, instead we should treat !flag_tree_loop_optimize the same as we treat
explicit -fno-tree-vectorize in omp-low.c (there are two spots).


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug middle-end/60534] ICE: in expand_GOMP_SIMD_VF, at internal-fn.c:142 with -fopenmp -O -fno-tree-loop-optimize and #pragma omp simd reduction
  2014-03-15  8:15 [Bug middle-end/60534] New: ICE: in expand_GOMP_SIMD_VF, at internal-fn.c:142 with -fopenmp -O -fno-tree-loop-optimize and #pragma omp simd reduction zsojka at seznam dot cz
                   ` (2 preceding siblings ...)
  2014-03-17  9:03 ` jakub at gcc dot gnu.org
@ 2014-03-17 14:16 ` mpolacek at gcc dot gnu.org
  2014-03-17 14:18 ` mpolacek at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-03-17 14:16 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60534

--- Comment #3 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Mon Mar 17 14:15:51 2014
New Revision: 208616

URL: http://gcc.gnu.org/viewcvs?rev=208616&root=gcc&view=rev
Log:
    PR middle-end/60534
    * omp-low.c (omp_max_vf): Treat -fno-tree-loop-optimize the same
    as -fno-tree-loop-vectorize.
    (expand_omp_simd): Likewise.
testsuite/
    * gcc.dg/gomp/pr60534.c: New test.

Added:
    trunk/gcc/testsuite/gcc.dg/gomp/pr60534.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/omp-low.c
    trunk/gcc/testsuite/ChangeLog


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug middle-end/60534] ICE: in expand_GOMP_SIMD_VF, at internal-fn.c:142 with -fopenmp -O -fno-tree-loop-optimize and #pragma omp simd reduction
  2014-03-15  8:15 [Bug middle-end/60534] New: ICE: in expand_GOMP_SIMD_VF, at internal-fn.c:142 with -fopenmp -O -fno-tree-loop-optimize and #pragma omp simd reduction zsojka at seznam dot cz
                   ` (3 preceding siblings ...)
  2014-03-17 14:16 ` mpolacek at gcc dot gnu.org
@ 2014-03-17 14:18 ` mpolacek at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-03-17 14:18 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60534

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |4.9.0

--- Comment #4 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Fixed.


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-03-17 14:18 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-15  8:15 [Bug middle-end/60534] New: ICE: in expand_GOMP_SIMD_VF, at internal-fn.c:142 with -fopenmp -O -fno-tree-loop-optimize and #pragma omp simd reduction zsojka at seznam dot cz
2014-03-17  8:19 ` [Bug middle-end/60534] " mpolacek at gcc dot gnu.org
2014-03-17  8:23 ` mpolacek at gcc dot gnu.org
2014-03-17  9:03 ` jakub at gcc dot gnu.org
2014-03-17 14:16 ` mpolacek at gcc dot gnu.org
2014-03-17 14:18 ` mpolacek at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).