public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug lto/60567] [4.9 Regression] lto1 ICE in add_symbol_to_partition, at lto/lto-partition.c:233 with -fno-use-linker-plugin
Date: Wed, 09 Apr 2014 15:42:00 -0000	[thread overview]
Message-ID: <bug-60567-4-HyIGsMqmWh@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-60567-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60567

--- Comment #13 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
--- gcc/symtab.c.jj    2014-03-21 22:23:43.000000000 +0100
+++ gcc/symtab.c    2014-04-09 17:37:40.709523997 +0200
@@ -1312,9 +1312,13 @@ symtab_get_symbol_partitioning_class (sy
   /* Linker discardable symbols are duplicated to every use unless they are
      keyed.
      Keyed symbols or those.  */
-  if (DECL_ONE_ONLY (node->decl)
+  if ((HAVE_LTO_PLUGIN
+       && (flag_use_linker_plugin
+       || (HAVE_LTO_PLUGIN == 2
+           && !global_options_set.x_flag_use_linker_plugin))
+       ? (DECL_ONE_ONLY (node->decl) && !node->forced_by_abi)
+       : DECL_COMDAT (node->decl))
       && !node->force_output
-      && !node->forced_by_abi
       && !symtab_used_from_object_file_p (node))
     return SYMBOL_DUPLICATE;


seems to make the ICE go away with -fno-use-linker-plugin or when the linker
doesn't support the plugin at all, didn't have to change ipa.c similarly.
But why is this happening and why this helps needs analyzing.


  parent reply	other threads:[~2014-04-09 15:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-18 17:35 [Bug lto/60567] New: lto1 ICE in add_symbol_to_partition, at lto/lto-partition.c:233 burnus at gcc dot gnu.org
2014-03-19 12:21 ` [Bug lto/60567] " burnus at gcc dot gnu.org
2014-03-19 17:42 ` burnus at gcc dot gnu.org
2014-03-19 19:01 ` burnus at gcc dot gnu.org
2014-03-19 19:20 ` burnus at gcc dot gnu.org
2014-03-20 19:13 ` [Bug lto/60567] lto1 ICE in add_symbol_to_partition, at lto/lto-partition.c:233 - when no -fresolution= is available burnus at gcc dot gnu.org
2014-03-21  9:58 ` [Bug lto/60567] [4.9 Regression] lto1 ICE in add_symbol_to_partition, at lto/lto-partition.c:233 with -fno-use-linker-plugin rguenth at gcc dot gnu.org
2014-03-21 10:00 ` rguenth at gcc dot gnu.org
2014-03-25  0:33 ` hubicka at gcc dot gnu.org
2014-03-31  9:45 ` rguenth at gcc dot gnu.org
2014-04-09  8:51 ` jakub at gcc dot gnu.org
2014-04-09 15:42 ` jakub at gcc dot gnu.org [this message]
2014-04-09 15:59 ` hubicka at gcc dot gnu.org
2014-04-09 16:03 ` hubicka at gcc dot gnu.org
2014-04-09 17:20 ` jason at gcc dot gnu.org
2014-04-10  8:48 ` jakub at gcc dot gnu.org
2014-04-10  9:03 ` jakub at gcc dot gnu.org
2014-04-10 16:45 ` jakub at gcc dot gnu.org
2014-04-10 18:55 ` jakub at gcc dot gnu.org
2014-04-10 18:58 ` jakub at gcc dot gnu.org
2014-04-10 19:02 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-60567-4-HyIGsMqmWh@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).