[Bug other/60589] New: Parallel install fails

[Bug other/60589] New: Parallel install fails

[y.gribov at samsung dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60589

            Bug ID: 60589
           Summary: Parallel install fails
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
          Assignee: unassigned at gcc dot gnu.org
          Reporter: y.gribov at samsung dot com
                CC: burnus at gcc dot gnu.org

GCC parallel install has been broken for a couple of days. Symptoms:

test -z
"/home/ygribov/install/gcc-master/lib/gcc/x86_64-unknown-linux-gnu/4.9.0/include/cilk"
|| /bin/mkdir -p
"/home/ygribov/install/gcc-master/lib/gcc/x86_64-unknown-linux-gnu/4.9.0/include/cilk"
test -z
"/home/ygribov/install/gcc-master/lib/gcc/x86_64-unknown-linux-gnu/4.9.0/include/cilk"
|| /bin/mkdir -p
"/home/ygribov/install/gcc-master/lib/gcc/x86_64-unknown-linux-gnu/4.9.0/include/cilk"
 /usr/bin/install -c -m 644
/home/ygribov/src/gcc-master/libcilkrts/include/cilk/cilk_api.h
/home/ygribov/src/gcc-master/libcilkrts/include/cilk/cilk_api_linux.h
/home/ygribov/src/gcc-master/libcilkrts/include/cilk/cilk.h
/home/ygribov/src/gcc-master/libcilkrts/include/cilk/cilk_stub.h
/home/ygribov/src/gcc-master/libcilkrts/include/cilk/cilk_undocumented.h
/home/ygribov/src/gcc-master/libcilkrts/include/cilk/common.h
/home/ygribov/src/gcc-master/libcilkrts/include/cilk/holder.h
/home/ygribov/src/gcc-master/libcilkrts/include/cilk/hyperobject_base.h
/home/ygribov/src/gcc-master/libcilkrts/include/cilk/metaprogramming.h
/home/ygribov/src/gcc-master/libcilkrts/include/cilk/reducer_file.h
/home/ygribov/src/gcc-master/libcilkrts/include/cilk/reducer.h
/home/ygribov/src/gcc-master/libcilkrts/include/cilk/reducer_list.h
/home/ygribov/src/gcc-master/libcilkrts/include/cilk/reducer_max.h
/home/ygribov/src/gcc-master/libcilkrts/include/cilk/reducer_min.h
/home/ygribov/src/gcc-master/libcilkrts/include/cilk/reducer_min_max.h
/home/ygribov/src/gcc-master/libcilkrts/include/cilk/reducer_opadd.h
/home/ygribov/src/gcc-master/libcilkrts/include/cilk/reducer_opand.h
/home/ygribov/src/gcc-master/libcilkrts/include/cilk/reducer_opmul.h
/home/ygribov/src/gcc-master/libcilkrts/include/cilk/reducer_opor.h
/home/ygribov/src/gcc-master/libcilkrts/include/cilk/reducer_opxor.h
/home/ygribov/src/gcc-master/libcilkrts/include/cilk/reducer_ostream.h
/home/ygribov/src/gcc-master/libcilkrts/include/cilk/reducer_string.h
'/home/ygribov/install/gcc-master/lib/gcc/x86_64-unknown-linux-gnu/4.9.0/include/cilk'
 /usr/bin/install -c -m 644
/home/ygribov/src/gcc-master/libcilkrts/include/cilk/cilk.h
'/home/ygribov/install/gcc-master/lib/gcc/x86_64-unknown-linux-gnu/4.9.0/include/cilk'
/usr/bin/install: cannot change permissions of
`/home/ygribov/install/gcc-master/lib/gcc/x86_64-unknown-linux-gnu/4.9.0/include/cilk/cilk.h':
No such file or directory
make[3]: *** [install-nodist_cilkincludeHEADERS] Error 1
make[3]: *** Waiting for unfinished jobs....

It looks like libcilkrts Makefile tries to install cilk.h twice in parallel (in
install-nodist_cilkinclude_HEADERS and install-cilkincludeHEADERS) and runs
into a conflict.

The error was probably introduced in r208440.

BTW could someone add libcilkrts to list of components?

[Bug other/60589] Parallel install fails

[y.gribov at samsung dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60589

Yury Gribov <y.gribov at samsung dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |y.gribov at samsung dot com

--- Comment #1 from Yury Gribov <y.gribov at samsung dot com> ---
Created attachment 32394
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32394&action=edit
Draft patch

Perhaps it's enough to simply remove cilk.h from cilkinclude_HEADERS? Attaching
draft patch.

[Bug other/60589] Parallel install fails due to multiple cilk.h installs

[y.gribov at samsung dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60589

--- Comment #3 from Yury Gribov <y.gribov at samsung dot com> ---
(In reply to Tobias Burnus from comment #2)
> > BTW could someone add libcilkrts to list of components?
> 
> What do you mean by this?

No-no, I meant a bugzilla component so that I could fire bugs against Cilk
runtime (like we currently do for libgcc, sanitizers, etc.).

[Bug other/60589] Parallel install fails due to multiple cilk.h installs

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60589

--- Comment #4 from Tobias Burnus <burnus at gcc dot gnu.org> ---
(In reply to Tobias Burnus from comment #2)
> Probably the right choice is to simply revert r208440.

Unrelated to the revert: GCC currently installs cilk (and also ssp) under both
./lib/gcc/x86_64-unknown-linux-gnu/4.9.0/include and
./lib64/gcc/x86_64-unknown-linux-gnu/4.9.0/include; but it should do so only
under the latter path. Presumably, a "nodist_" is missing.

[Bug other/60589] Parallel install fails due to multiple cilk.h installs

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60589

--- Comment #5 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Author: burnus
Date: Thu Mar 20 19:50:51 2014
New Revision: 208736

URL: http://gcc.gnu.org/viewcvs?rev=208736&root=gcc&view=rev
Log:
2014-03-20  Tobias Burnus  <burnus@net-b.de>

        PR other/60589

        Reverted:
        2014-03-09  Tobias Burnus  <burnus@net-b.de>

        * Makefile.am: Install cilk.h.
        * Makefile.in: Regenerate.
        * aclocal.m4: Regenerate.


Modified:
    trunk/libcilkrts/ChangeLog
    trunk/libcilkrts/Makefile.am
    trunk/libcilkrts/Makefile.in
    trunk/libcilkrts/aclocal.m4

[Bug other/60589] Parallel install fails due to multiple cilk.h installs

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60589

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Close as FIXED. Comment 5 should have fixed the problem.

[Some other issues were fixed in commit r208847/r208847 (namely: the double
cilk.h and the automatic inclusion of -lcilkrts).]