public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/60599] New: [4.9 Regression] Testsuite's scan-module-absence no longer works
@ 2014-03-20 10:39 burnus at gcc dot gnu.org
2014-03-20 16:04 ` [Bug fortran/60599] " dominiq at lps dot ens.fr
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: burnus at gcc dot gnu.org @ 2014-03-20 10:39 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60599
Bug ID: 60599
Summary: [4.9 Regression] Testsuite's scan-module-absence no
longer works
Product: gcc
Version: 4.9.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: fortran
Assignee: unassigned at gcc dot gnu.org
Reporter: burnus at gcc dot gnu.org
CC: jb at gcc dot gnu.org
The test suite moved to zipped files. That broke the implicit_pure*f90 test
cases, which use, e.g.,
! { dg-final { scan-module-absence "m" "IMPLICIT_PURE" } }
That function defined in gcc/testsuite/lib/gcc-dg.exp:
set modfilename [string tolower [lindex $args 0]].mod
set fd [open $modfilename r]
set text [read $fd]
close $fd
That code obviously fails when the file is zipped.
Note that scan-module in the same file contains a "gzip" to handle this case.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug fortran/60599] [4.9 Regression] Testsuite's scan-module-absence no longer works
2014-03-20 10:39 [Bug fortran/60599] New: [4.9 Regression] Testsuite's scan-module-absence no longer works burnus at gcc dot gnu.org
@ 2014-03-20 16:04 ` dominiq at lps dot ens.fr
2014-03-20 23:17 ` burnus at gcc dot gnu.org
2014-03-20 23:18 ` burnus at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: dominiq at lps dot ens.fr @ 2014-03-20 16:04 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60599
Dominique d'Humieres <dominiq at lps dot ens.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2014-03-20
Ever confirmed|0 |1
--- Comment #1 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> Note that scan-module in the same file contains a "gzip" to handle this case.
Hence an obvious patch
--- ../_clean/gcc/testsuite/lib/gcc-dg.exp 2014-03-14 16:55:56.000000000
+0100
+++ gcc/testsuite/lib/gcc-dg.exp 2014-03-20 16:55:40.000000000 +0100
@@ -656,7 +656,7 @@ proc scan-module { args } {
# Argument 1 is the regexp to match
proc scan-module-absence { args } {
set modfilename [string tolower [lindex $args 0]].mod
- set fd [open $modfilename r]
+ set fd [open [list | gzip -dc $modfilename] r]
set text [read $fd]
close $fd
I have tested that with this patch the test gfortran.dg/implicit_pure_4.f90
succeeds after r209687, but fails before it (while it succeeds without the
above patch).
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug fortran/60599] [4.9 Regression] Testsuite's scan-module-absence no longer works
2014-03-20 10:39 [Bug fortran/60599] New: [4.9 Regression] Testsuite's scan-module-absence no longer works burnus at gcc dot gnu.org
2014-03-20 16:04 ` [Bug fortran/60599] " dominiq at lps dot ens.fr
@ 2014-03-20 23:17 ` burnus at gcc dot gnu.org
2014-03-20 23:18 ` burnus at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: burnus at gcc dot gnu.org @ 2014-03-20 23:17 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60599
--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Author: burnus
Date: Thu Mar 20 23:16:57 2014
New Revision: 208739
URL: http://gcc.gnu.org/viewcvs?rev=208739&root=gcc&view=rev
Log:
2014-03-21 Tobias Burnus <burnus@net-b.de>
PR fortran/60599
* lib/gcc-dg.exp (scan-module): Uncompress .mod files for
reading.
Modified:
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/lib/gcc-dg.exp
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug fortran/60599] [4.9 Regression] Testsuite's scan-module-absence no longer works
2014-03-20 10:39 [Bug fortran/60599] New: [4.9 Regression] Testsuite's scan-module-absence no longer works burnus at gcc dot gnu.org
2014-03-20 16:04 ` [Bug fortran/60599] " dominiq at lps dot ens.fr
2014-03-20 23:17 ` burnus at gcc dot gnu.org
@ 2014-03-20 23:18 ` burnus at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: burnus at gcc dot gnu.org @ 2014-03-20 23:18 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60599
Tobias Burnus <burnus at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #3 from Tobias Burnus <burnus at gcc dot gnu.org> ---
FIXED.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-03-20 23:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-20 10:39 [Bug fortran/60599] New: [4.9 Regression] Testsuite's scan-module-absence no longer works burnus at gcc dot gnu.org
2014-03-20 16:04 ` [Bug fortran/60599] " dominiq at lps dot ens.fr
2014-03-20 23:17 ` burnus at gcc dot gnu.org
2014-03-20 23:18 ` burnus at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).