[Bug rtl-optimization/60601] New: [4.9 Regression] profiledbootstrap fails with Ada

[Bug rtl-optimization/60601] New: [4.9 Regression] profiledbootstrap fails with Ada

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60601

            Bug ID: 60601
           Summary: [4.9 Regression] profiledbootstrap fails with Ada
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: rguenth at gcc dot gnu.org
              Host: x86_64-pc-linux-gnu

> /space/rguenther/src/svn/trunk2/configure --enable-languages=all,ada,obj-c++
> make -j6 profiledbootstrap
...
/abuild/rguenther/obj2/./prev-gcc/xgcc -B/abuild/rguenther/obj2/./prev-gcc/
-B/usr/local/x86_64-unknown-linux-gnu/bin/
-B/usr/local/x86_64-unknown-linux-gnu/bin/
-B/usr/local/x86_64-unknown-linux-gnu/lib/ -isystem
/usr/local/x86_64-unknown-linux-gnu/include -isystem
/usr/local/x86_64-unknown-linux-gnu/sys-include    -c -g -O2 -fprofile-use 
-gnatpg -gnata -W -Wall -nostdinc -I- -I. -Iada
-I/space/rguenther/src/svn/trunk2/gcc/ada
-I/space/rguenther/src/svn/trunk2/gcc/ada/gcc-interface
/space/rguenther/src/svn/trunk2/gcc/ada/sem_elab.adb -o ada/sem_elab.o
/space/rguenther/src/svn/trunk2/gcc/ada/sem_dim.adb: In function
‘Sem_Dim.Analyze_Dimension_Call’:
/space/rguenther/src/svn/trunk2/gcc/ada/sem_dim.adb:1649:8: error: fallthru
edge crosses section boundary in bb 130
/space/rguenther/src/svn/trunk2/gcc/ada/sem_dim.adb:1649:8: error: fallthru
edge crosses section boundary in bb 82
/space/rguenther/src/svn/trunk2/gcc/ada/sem_dim.adb:1649:8: error: fallthru
edge crosses section boundary in bb 40
+===========================GNAT BUG DETECTED==============================+
| 4.9.0 20140320 (experimental) [trunk revision 161655]
(x86_64-unknown-linux-gnu) GCC error:|
| verify_flow_info failed                                                  |
| Error detected around
/space/rguenther/src/svn/trunk2/gcc/ada/sem_dim.adb:1649:8|
| Please submit a bug report; see http://gcc.gnu.org/bugs.html.            |
| Use a subject line meaningful to you and us to track the bug.            |
| Include the entire contents of this bug box in the report.               |
| Include the exact gcc or gnatmake command that you entered.              |
| Also include sources listed below in gnatchop format                     |
| (concatenated together with no headers between files).                   |
+==========================================================================+
>From gcc-bugs-return-446988-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Mar 20 14:11:20 2014
Return-Path: <gcc-bugs-return-446988-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 6825 invoked by alias); 20 Mar 2014 14:11:20 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 6682 invoked by uid 48); 20 Mar 2014 14:11:16 -0000
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/60601] [4.9 Regression] profiledbootstrap fails with Ada
Date: Thu, 20 Mar 2014 14:11:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: target_milestone
Message-ID: <bug-60601-4-IcGXXSAnW1@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-60601-4@http.gcc.gnu.org/bugzilla/>
References: <bug-60601-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-03/txt/msg01857.txt.bz2
Content-length: 293

http://gcc.gnu.org/bugzilla/show_bug.cgi?id`601

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.9.0

[Bug rtl-optimization/60601] [4.9 Regression] profiledbootstrap fails with Ada

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60601

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-checking
             Target|                            |x86_64-*-*, i?86-*-*
           Priority|P3                          |P1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-03-21
     Ever confirmed|0                           |1

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed by Jakub.  Works for release checking.

[Bug rtl-optimization/60601] [4.9 Regression] profiledbootstrap fails with Ada

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60601

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|ebotcazou at gcc dot gnu.org       |
           Assignee|unassigned at gcc dot gnu.org      |ebotcazou at gcc dot gnu.org

--- Comment #2 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Investigating.

[Bug rtl-optimization/60601] [4.9 Regression] profiledbootstrap fails with Ada

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60601

--- Comment #3 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
fix_up_fall_thru_edges is apparently looking for EDGE_CAN_FALLTHRU edges but
this flag is only set during bb-reorder.  Testing trivial patch.

[Bug rtl-optimization/60601] [4.9 Regression] profiledbootstrap fails with Ada

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60601

--- Comment #4 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
The next error is:

In file included from /home/eric/svn/gcc/gcc/gcc.c:36:0:
/home/eric/svn/gcc/gcc/../include/obstack.h: In function 'const char*
handle_spec_function(const char*, bool*)':
/home/eric/svn/gcc/gcc/../include/obstack.h:337:52: error: 'save_growing_value'
may be used uninitialized in this function [-Werror=maybe-uninitialized]
    _obstack_memcpy (__o->next_free, (where), __len);   \
                                                    ^
/home/eric/svn/gcc/gcc/gcc.c:5484:9: note: 'save_growing_value' was declared
here
   void *save_growing_value;

[Bug rtl-optimization/60601] [4.9 Regression] profiledbootstrap fails with Ada

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60601

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
I guess it is not a big deal to do:
   save_growing_size = obstack_object_size (&obstack);
+  save_growing_value = NULL;
   if (save_growing_size > 0)
     save_growing_value = obstack_finish (&obstack);
to workaround the bogus warning.
Of course it would be nice to understand why uninit doesn't handle this, since
it should be the pretty much easiest case of predicated uninit analysis.

--- Comment #6 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Author: ebotcazou
Date: Sun Mar 23 11:29:42 2014
New Revision: 208770

URL: http://gcc.gnu.org/viewcvs?rev=208770&root=gcc&view=rev
Log:
    PR rtl-optimization/60601
    * bb-reorder.c (fix_up_fall_thru_edges): Test EDGE_FALLTHRU everywhere.

    * gcc.c (eval_spec_function): Initialize save_growing_value.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/bb-reorder.c
    trunk/gcc/gcc.c

[Bug rtl-optimization/60601] [4.9 Regression] profiledbootstrap fails with Ada

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60601

--- Comment #7 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Author: ebotcazou
Date: Sun Mar 23 11:30:57 2014
New Revision: 208771

URL: http://gcc.gnu.org/viewcvs?rev=208771&root=gcc&view=rev
Log:
    PR rtl-optimization/60601
    * bb-reorder.c (fix_up_fall_thru_edges): Test EDGE_FALLTHRU everywhere.

    * gcc.c (eval_spec_function): Initialize save_growing_value.

Modified:
    branches/gcc-4_8-branch/gcc/ChangeLog
    branches/gcc-4_8-branch/gcc/bb-reorder.c
    branches/gcc-4_8-branch/gcc/gcc.c

[Bug rtl-optimization/60601] [4.9 Regression] profiledbootstrap fails with Ada

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60601

--- Comment #8 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Author: ebotcazou
Date: Sun Mar 23 11:31:36 2014
New Revision: 208772

URL: http://gcc.gnu.org/viewcvs?rev=208772&root=gcc&view=rev
Log:
    PR rtl-optimization/60601
    * bb-reorder.c (fix_up_fall_thru_edges): Test EDGE_FALLTHRU everywhere.

Modified:
    branches/gcc-4_7-branch/gcc/ChangeLog
    branches/gcc-4_7-branch/gcc/bb-reorder.c

[Bug rtl-optimization/60601] [4.9 Regression] profiledbootstrap fails with Ada

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60601

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Apparently an old pasto.