[Bug bootstrap/60644] New: [4.9 Regression] Build of i686-pc-linux-android is broken

[Bug bootstrap/60644] New: [4.9 Regression] Build of i686-pc-linux-android is broken

[aivchenk at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60644

            Bug ID: 60644
           Summary: [4.9 Regression] Build of i686-pc-linux-android is
                    broken
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
          Assignee: unassigned at gcc dot gnu.org
          Reporter: aivchenk at gmail dot com

> ../gcc_mainline/configure --target=i686-linux-android --disable-bootstrap --enable-languages=c,c++ --with-sysroot=[..]ndk/android-ndk-r9d/platforms/android-19/arch-x86 --disable-shared --disable-libitm --disable-libsanitizer


> make
[..]
../../../gcc_mainline/libcilkrts/runtime/os-unix.c: In function ‘linux_gettid’:
../../../gcc_mainline/libcilkrts/runtime/os-unix.c:293:20: error: ‘SYS_gettid’
undeclared (first use in this function)
     return syscall(SYS_gettid);
                    ^
../../../gcc_mainline/libcilkrts/runtime/os-unix.c:293:20: note: each
undeclared identifier is reported only once for each function it appears in
../../../gcc_mainline/libcilkrts/runtime/os-unix.c: In function
‘__cilkrts_yield’:
../../../gcc_mainline/libcilkrts/runtime/os-unix.c:419:5: warning: implicit
declaration of function ‘pthread_yield’ [-Wimplicit-function-declaration]
     pthread_yield();
     ^
make[2]: *** [os-unix.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
mv -f .deps/spin_mutex.Tpo .deps/spin_mutex.Plo
mv -f .deps/worker_mutex.Tpo .deps/worker_mutex.Plo
mv -f .deps/stats.Tpo .deps/stats.Plo
mv -f .deps/signal_node.Tpo .deps/signal_node.Plo
mv -f .deps/symbol_test.Tpo .deps/symbol_test.Plo
mv -f .deps/sysdep-unix.Tpo .deps/sysdep-unix.Plo
make[2]: Leaving directory
`/export/users/aivchenk/src/android_gcc_obj/i686-linux-android/libcilkrts'
make[1]: *** [all-target-libcilkrts] Error 2
make[1]: Leaving directory `/export/users/aivchenk/src/android_gcc_obj'
make: *** [all] Error 2
>From gcc-bugs-return-447357-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Mar 25 06:40:44 2014
Return-Path: <gcc-bugs-return-447357-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 29060 invoked by alias); 25 Mar 2014 06:40:44 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 29030 invoked by uid 48); 25 Mar 2014 06:40:40 -0000
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/60644] [4.9 Regression] Build of i686-pc-linux-android is broken
Date: Tue, 25 Mar 2014 06:40:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: bootstrap
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: pinskia at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-60644-4-HaPDKSU6v3@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-60644-4@http.gcc.gnu.org/bugzilla/>
References: <bug-60644-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-03/txt/msg02226.txt.bz2
Content-length: 420

http://gcc.gnu.org/bugzilla/show_bug.cgi?id`644

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
If SYS_gettid is not defined, then it is a bug in the bionic libc headers as
NR_gettid is defined in the kernel headers.

Also pthread_yield should be defined in pthread.h if it is not then it is again
a bug in bionic.

For no you can use --disable-libcilkrts as a workaround for bionic being
broken.

[Bug bootstrap/60644] [4.9 Regression] Build of i686-pc-linux-android is broken

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60644

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Well pthread_yield should be replaced with the POSIX version: sched_yield()
instead.

[Bug bootstrap/60644] [4.9 Regression] Build of i686-pc-linux-android is broken

[aivchenk at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60644

--- Comment #4 from Alexander Ivchenko <aivchenk at gmail dot com> ---
That (In reply to Andrew Pinski from comment #2)
> Well pthread_yield should be replaced with the POSIX version: sched_yield()
> instead.

Right.. the attached patch cured the build

[Bug bootstrap/60644] [4.9 Regression] Build of i686-pc-linux-android is broken

[aivchenk at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60644

--- Comment #3 from Alexander Ivchenko <aivchenk at gmail dot com> ---
Created attachment 32443
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32443&action=edit
Renaming ANDROID to __ANDROID__

[Bug bootstrap/60644] [4.9 Regression] Build of i686-pc-linux-android is broken

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60644

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.9.0

[Bug bootstrap/60644] [4.9 Regression] Build of i686-pc-linux-android is broken

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60644

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Patches (once tested) should be posted to gcc-patches.
Please CC Balaji.

[Bug bootstrap/60644] [4.9 Regression] Build of i686-pc-linux-android is broken

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60644

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |i686-pc-linux-android
           Priority|P3                          |P4

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
i686-pc-linux-android is not primary/secondary.

[Bug bootstrap/60644] [4.9 Regression] Build of i686-pc-linux-android is broken

[aivchenk at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60644

--- Comment #7 from Alexander Ivchenko <aivchenk at gmail dot com> ---
The fix in gcc-patches:
http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01428.html

[Bug bootstrap/60644] [4.9/4.10 Regression] Build of i686-pc-linux-android is broken

[bviyer at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60644

--- Comment #8 from bviyer at gcc dot gnu.org ---
Author: bviyer
Date: Fri Apr 11 19:56:42 2014
New Revision: 209324

URL: http://gcc.gnu.org/viewcvs?rev=209324&root=gcc&view=rev
Log:
Fix for PR other/60644.
+2014-04-11  Barry Tannenbaum  <barry.m.tannenbaum@intel.com>
+
+       PR other/60644
+       * runtime/os-unix.c: Replaced all occurrances of ANDROID with
+       __ANDROID__.
+       * runtime/bug.h: Likewise.
+       * include/cilk/metaprogramming.h: Likewise.
+       * include/cilk/reducer_min_max.h: Likewise.
+


Modified:
    trunk/libcilkrts/ChangeLog
    trunk/libcilkrts/include/cilk/metaprogramming.h
    trunk/libcilkrts/include/cilk/reducer_min_max.h
    trunk/libcilkrts/runtime/bug.h
    trunk/libcilkrts/runtime/os-unix.c

[Bug bootstrap/60644] [4.9/4.10 Regression] Build of i686-pc-linux-android is broken

[aivchenk at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60644

--- Comment #9 from Alexander Ivchenko <aivchenk at gmail dot com> ---
Confirm fixing

[Bug bootstrap/60644] [4.9/4.10 Regression] Build of i686-pc-linux-android is broken

[kyukhin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60644

--- Comment #10 from Kirill Yukhin <kyukhin at gcc dot gnu.org> ---
Author: kyukhin
Date: Thu Apr 17 11:52:44 2014
New Revision: 209474

URL: http://gcc.gnu.org/viewcvs?rev=209474&root=gcc&view=rev
Log:
libcilkrts/
    PR other/60644
    * runtime/os-unix.c: Replaced all occurrances of ANDROID with
    __ANDROID__.
    * runtime/bug.h: Likewise.
    * include/cilk/metaprogramming.h: Likewise.
    * include/cilk/reducer_min_max.h: Likewise.

Modified:
    branches/gcc-4_9-branch/libcilkrts/ChangeLog
    branches/gcc-4_9-branch/libcilkrts/include/cilk/metaprogramming.h
    branches/gcc-4_9-branch/libcilkrts/include/cilk/reducer_min_max.h
    branches/gcc-4_9-branch/libcilkrts/runtime/bug.h
    branches/gcc-4_9-branch/libcilkrts/runtime/os-unix.c

[Bug bootstrap/60644] [4.9/4.10 Regression] Build of i686-pc-linux-android is broken

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60644

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.0                       |4.9.1

--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.0 has been released

[Bug bootstrap/60644] [4.9/4.10 Regression] Build of i686-pc-linux-android is broken

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60644

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.1                       |4.9.2

--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.1 has been released.

[Bug bootstrap/60644] [4.9/5 Regression] Build of i686-pc-linux-android is broken

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60644

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.2                       |4.9.3

--- Comment #13 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.2 has been released.

[Bug bootstrap/60644] [4.9/5/6 Regression] Build of i686-pc-linux-android is broken

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60644

--- Comment #14 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.3 has been released.

[Bug bootstrap/60644] [4.9/5/6 Regression] Build of i686-pc-linux-android is broken

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60644

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.3                       |4.9.4