[Bug rtl-optimization/60663] New: Errors out on valid inline asm

[Bug rtl-optimization/60663] New: Errors out on valid inline asm

[zhenqiang.chen at linaro dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60663

            Bug ID: 60663
           Summary: Errors out on valid inline asm
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zhenqiang.chen at linaro dot org

Found while building an arm32 kernel

//fail.c
int g(void)
{
  unsigned i, j;
  asm("// %0 %1" : "=r" (i), "=r"(j));
  return i;
}

arm-linux-gnueabihf-gcc -march=armv7-a -O2 -c fail.c
fail.c: In function ‘g’:
fail.c:4:3: error: invalid 'asm': operand number out of range

Root cause: "cse1" generates illegal asm instruction since check_asm_operands
does not check the number of expected operands.

i.e. "cse1" changes code from
(insn 5 2 6 2 (parallel [
            (set (reg:SI 114 [ i ])
                (asm_operands:SI ("// %0 %1") ("=r") 0 []
                     []
                     [] fail.c:4))
            (set (reg:SI 115 [ j ])
                (asm_operands:SI ("// %0 %1") ("=r") 1 []
                     []
                     [] fail.c:4))
        ]) fail.c:4 -1
     (nil))
(insn 6 5 8 2 (set (reg/v:SI 110 [ i ])
        (reg:SI 114 [ i ])) fail.c:4 664 {*thumb2_movsi_vfp}
     (nil))
to

(insn 12 2 13 2 (set (reg/i:SI 0 r0)
        (asm_operands:SI ("// %0 %1") ("=r") 0 []
             []
             [] fail.c:4)) fail.c:6 -1
     (nil))

No error for x86-64 and arm gcc-4.8. ARM rtx_cost changes in 4.9 trigger this
optimization.

A patch to enhance check_asm_operands is sent out for review.
>From gcc-bugs-return-447501-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Mar 26 06:35:12 2014
Return-Path: <gcc-bugs-return-447501-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 21640 invoked by alias); 26 Mar 2014 06:35:11 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 21615 invoked by uid 48); 26 Mar 2014 06:35:06 -0000
From: "timo.teras at iki dot fi" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/58489] ICE: in reload_cse_simplify_operands, at postreload.c:411
Date: Wed, 26 Mar 2014 06:35:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.8.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: timo.teras at iki dot fi
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-58489-4-CJSD6BdltL@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-58489-4@http.gcc.gnu.org/bugzilla/>
References: <bug-58489-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-03/txt/msg02370.txt.bz2
Content-length: 539

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58489

--- Comment #2 from Timo Teräs <timo.teras at iki dot fi> ---
I got this fixed. It seems genautomata does not work properly if it is built
with -fPIC. Since PIE/PIC get added automatically in alpine toolchain it caused
this.

For now I'm adding explicitly -fno-PIC to genautomata compilation. However, it
would be better if genautomata could be fixed to:
 - abort compilation if genautomata failed to do it's job properly
 - fix genautomata to work even if compiled with -fPIC
>From gcc-bugs-return-447502-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Mar 26 06:47:08 2014
Return-Path: <gcc-bugs-return-447502-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 26059 invoked by alias); 26 Mar 2014 06:47:08 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 26010 invoked by uid 55); 26 Mar 2014 06:47:04 -0000
From: "mpolacek at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug other/59545] Signed integer overflow issues
Date: Wed, 26 Mar 2014 06:47:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: other
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: mpolacek at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-59545-4-ATdg3AaV21@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59545-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59545-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-03/txt/msg02371.txt.bz2
Content-length: 440

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY545

--- Comment #9 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Wed Mar 26 06:46:27 2014
New Revision: 208834

URL: http://gcc.gnu.org/viewcvs?rev 8834&root=gcc&view=rev
Log:
    PR other/59545
    * ira-color.c (update_conflict_hard_regno_costs): Perform the
    multiplication in unsigned type.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ira-color.c

[Bug rtl-optimization/60663] [4.9 Regression] Errors out on valid inline asm

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60663

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-04-10
                 CC|                            |jakub at gcc dot gnu.org
   Target Milestone|---                         |4.9.0
            Summary|Errors out on valid inline  |[4.9 Regression] Errors out
                   |asm                         |on valid inline asm
     Ever confirmed|0                           |1

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Supposedly introduced by r203160 which made inline asm with no input operands
appear as having zero cost.

Alternate patch posted at
http://gcc.gnu.org/ml/gcc-patches/2014-04/msg00512.html

[Bug rtl-optimization/60663] [4.9 Regression] Errors out on valid inline asm

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60663

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Fri Apr 11 10:11:01 2014
New Revision: 209293

URL: http://gcc.gnu.org/viewcvs?rev=209293&root=gcc&view=rev
Log:
    PR rtl-optimization/60663
    * cse.c (cse_insn): Set src_volatile on ASM_OPERANDS in
    PARALLEL.

    * gcc.target/arm/pr60663.c: New test.

Added:
    trunk/gcc/testsuite/gcc.target/arm/pr60663.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cse.c
    trunk/gcc/testsuite/ChangeLog

[Bug rtl-optimization/60663] [4.9 Regression] Errors out on valid inline asm

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60663

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Should be fixed now.

[Bug rtl-optimization/60663] [4.9 Regression] Errors out on valid inline asm

[feedback at launchpad dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60663

--- Comment #4 from Launchpad <feedback at launchpad dot net> ---
Arnd Bergmann added the following comment to Launchpad bug report 1296942:

Looks good now, I have resumed ARM kernel build testing with gcc-4.9 now and
don't see this any more. There is one new bug that came up instead but it seems
unrelated. I'll open a new ticket for that.

-- 
http://launchpad.net/bugs/1296942

[Bug rtl-optimization/60663] [4.9 Regression] Errors out on valid inline asm

[ktkachov at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60663

--- Comment #5 from ktkachov at gcc dot gnu.org ---
Author: ktkachov
Date: Tue Apr 15 14:04:06 2014
New Revision: 209419

URL: http://gcc.gnu.org/viewcvs?rev=209419&root=gcc&view=rev
Log:

    PR rtl-optimization/60663
    * config/arm/arm.c (arm_new_rtx_costs): Improve ASM_OPERANDS case,
    avoid 0 cost.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/arm/arm.c

[Bug rtl-optimization/60663] [4.9 Regression] Errors out on valid inline asm

[yroux at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60663

--- Comment #6 from yroux at gcc dot gnu.org ---
Author: yroux
Date: Thu Jun 12 09:13:57 2014
New Revision: 211497

URL: http://gcc.gnu.org/viewcvs?rev=211497&root=gcc&view=rev
Log:
2014-05-23  Yvan Roux  <yvan.roux@linaro.org>

       Backport from trunk r209419.
       2014-04-15  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

       PR rtl-optimization/60663
       * config/arm/arm.c (arm_new_rtx_costs): Improve ASM_OPERANDS case,
       avoid 0 cost.


Modified:
    branches/linaro/gcc-4_9-branch/gcc/ChangeLog.linaro
    branches/linaro/gcc-4_9-branch/gcc/config/arm/arm.c

[Bug rtl-optimization/60663] [4.9 Regression] Errors out on valid inline asm

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60663

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Fri Jan 23 19:55:16 2015
New Revision: 220059

URL: https://gcc.gnu.org/viewcvs?rev=220059&root=gcc&view=rev
Log:
    PR rtl-optimization/63637
    PR rtl-optimization/60663
    * cse.c (merge_equiv_classes): Set new_elt->cost to MAX_COST
    if elt->cost is MAX_COST for ASM_OPERANDS.
    (find_sets_in_insn): Fix up comment typo.
    (cse_insn): Don't set src_volatile for all non-volatile
    ASM_OPERANDS in PARALLELs, but just those with multiple outputs
    or with "memory" clobber.  Set elt->cost to MAX_COST
    for ASM_OPERANDS in PARALLEL.  Set src_elt->cost to MAX_COST
    if new_src is ASM_OPERANDS and elt->cost is MAX_COST.

    * gcc.dg/pr63637-1.c: New test.
    * gcc.dg/pr63637-2.c: New test.
    * gcc.dg/pr63637-3.c: New test.
    * gcc.dg/pr63637-4.c: New test.
    * gcc.dg/pr63637-5.c: New test.
    * gcc.dg/pr63637-6.c: New test.
    * gcc.target/i386/pr63637-1.c: New test.
    * gcc.target/i386/pr63637-2.c: New test.
    * gcc.target/i386/pr63637-3.c: New test.
    * gcc.target/i386/pr63637-4.c: New test.
    * gcc.target/i386/pr63637-5.c: New test.
    * gcc.target/i386/pr63637-6.c: New test.

Added:
    trunk/gcc/testsuite/gcc.dg/pr63637-1.c
    trunk/gcc/testsuite/gcc.dg/pr63637-2.c
    trunk/gcc/testsuite/gcc.dg/pr63637-3.c
    trunk/gcc/testsuite/gcc.dg/pr63637-4.c
    trunk/gcc/testsuite/gcc.dg/pr63637-5.c
    trunk/gcc/testsuite/gcc.dg/pr63637-6.c
    trunk/gcc/testsuite/gcc.target/i386/pr63637-1.c
    trunk/gcc/testsuite/gcc.target/i386/pr63637-2.c
    trunk/gcc/testsuite/gcc.target/i386/pr63637-3.c
    trunk/gcc/testsuite/gcc.target/i386/pr63637-4.c
    trunk/gcc/testsuite/gcc.target/i386/pr63637-5.c
    trunk/gcc/testsuite/gcc.target/i386/pr63637-6.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cse.c
    trunk/gcc/testsuite/ChangeLog

[Bug rtl-optimization/60663] [4.9 Regression] Errors out on valid inline asm

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60663

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Sun Feb  1 17:33:19 2015
New Revision: 220323

URL: https://gcc.gnu.org/viewcvs?rev=220323&root=gcc&view=rev
Log:
    Backported from mainline
    2015-01-23  Jakub Jelinek  <jakub@redhat.com>

    PR rtl-optimization/63637
    PR rtl-optimization/60663
    * cse.c (merge_equiv_classes): Set new_elt->cost to MAX_COST
    if elt->cost is MAX_COST for ASM_OPERANDS.
    (find_sets_in_insn): Fix up comment typo.
    (cse_insn): Don't set src_volatile for all non-volatile
    ASM_OPERANDS in PARALLELs, but just those with multiple outputs
    or with "memory" clobber.  Set elt->cost to MAX_COST
    for ASM_OPERANDS in PARALLEL.  Set src_elt->cost to MAX_COST
    if new_src is ASM_OPERANDS and elt->cost is MAX_COST.

    * gcc.dg/pr63637-1.c: New test.
    * gcc.dg/pr63637-2.c: New test.
    * gcc.dg/pr63637-3.c: New test.
    * gcc.dg/pr63637-4.c: New test.
    * gcc.dg/pr63637-5.c: New test.
    * gcc.dg/pr63637-6.c: New test.
    * gcc.target/i386/pr63637-1.c: New test.
    * gcc.target/i386/pr63637-2.c: New test.
    * gcc.target/i386/pr63637-3.c: New test.
    * gcc.target/i386/pr63637-4.c: New test.
    * gcc.target/i386/pr63637-5.c: New test.
    * gcc.target/i386/pr63637-6.c: New test.

Added:
    branches/gcc-4_9-branch/gcc/testsuite/gcc.dg/pr63637-1.c
    branches/gcc-4_9-branch/gcc/testsuite/gcc.dg/pr63637-2.c
    branches/gcc-4_9-branch/gcc/testsuite/gcc.dg/pr63637-3.c
    branches/gcc-4_9-branch/gcc/testsuite/gcc.dg/pr63637-4.c
    branches/gcc-4_9-branch/gcc/testsuite/gcc.dg/pr63637-5.c
    branches/gcc-4_9-branch/gcc/testsuite/gcc.dg/pr63637-6.c
    branches/gcc-4_9-branch/gcc/testsuite/gcc.target/i386/pr63637-1.c
    branches/gcc-4_9-branch/gcc/testsuite/gcc.target/i386/pr63637-2.c
    branches/gcc-4_9-branch/gcc/testsuite/gcc.target/i386/pr63637-3.c
    branches/gcc-4_9-branch/gcc/testsuite/gcc.target/i386/pr63637-4.c
    branches/gcc-4_9-branch/gcc/testsuite/gcc.target/i386/pr63637-5.c
    branches/gcc-4_9-branch/gcc/testsuite/gcc.target/i386/pr63637-6.c
Modified:
    branches/gcc-4_9-branch/gcc/ChangeLog
    branches/gcc-4_9-branch/gcc/cse.c
    branches/gcc-4_9-branch/gcc/testsuite/ChangeLog

[Bug rtl-optimization/60663] [4.9 Regression] Errors out on valid inline asm

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60663
Bug 60663 depends on bug 63637, which changed state.

Bug 63637 Summary: [4.9 Regression] CSE on x86 asm()-s no longer working due to PR/60663 fix
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63637

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED