From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32102 invoked by alias); 1 Apr 2014 15:30:52 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Received: (qmail 32057 invoked by uid 48); 1 Apr 2014 15:30:49 -0000 From: "nicholas.ormrod at hotmail dot com" To: gcc-bugs@gcc.gnu.org Subject: [Bug preprocessor/60723] Line directives with incorrect system header flag Date: Tue, 01 Apr 2014 15:30:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: preprocessor X-Bugzilla-Version: 4.9.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: nicholas.ormrod at hotmail dot com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2014-04/txt/msg00064.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60723 Nicholas changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicholas.ormrod at hotmail dot com --- Comment #5 from Nicholas --- Thank you for the link, Manuel. This is my first contribution to gcc. I'll see if I can follow your instructions. As for the content of the patch, it fixes the second and more egregious error. In and of itself, token-line inconsistency is not the end of the world; the real problem is that the code that inserts the bad line directive has a bug. Specifically, it uses the macro's source file to determine the callsite file's properties. That is what the patch fixes. I do not have a patch for the line inconsistency, which is one of the reasons that I posted this to the bug forum.