[Bug testsuite/60794] New: 25 libstdc++ tests are missing '{ dg-require-debug-mode "" }'

[Bug testsuite/60794] New: 25 libstdc++ tests are missing '{ dg-require-debug-mode "" }'

[gnugcc at marino dot st]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60794

            Bug ID: 60794
           Summary: 25 libstdc++ tests are missing '{
                    dg-require-debug-mode "" }'
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gnugcc at marino dot st

Created attachment 32573
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32573&action=edit
Patch to add debug-mode requirement to 25 libstdc++ tests

Twenty-five (25) libstdc++ tests require the debug-mode option but this is not
specified.  I've carried the attached patch for years, time to try to get it
properly into the gcc testsuite base.

The tests are:
23_containers/deque/debug/assign4_neg.cc
23_containers/deque/debug/construct4_neg.cc
23_containers/deque/debug/insert4_neg.cc
23_containers/list/debug/assign4_neg.cc
23_containers/list/debug/construct4_neg.cc
23_containers/list/debug/insert4_neg.cc
23_containers/map/debug/construct4_neg.cc
23_containers/map/debug/insert4_neg.cc
23_containers/multimap/debug/construct4_neg.cc
23_containers/multimap/debug/insert4_neg.cc
23_containers/multiset/debug/construct4_neg.cc
23_containers/multiset/debug/insert4_neg.cc
23_containers/set/debug/construct4_neg.cc
23_containers/set/debug/insert4_neg.cc
23_containers/unordered_map/debug/construct4_neg.cc
23_containers/unordered_map/debug/insert4_neg.cc
23_containers/unordered_multimap/debug/construct4_neg.cc
23_containers/unordered_multimap/debug/insert4_neg.cc
23_containers/unordered_multiset/debug/construct4_neg.cc
23_containers/unordered_multiset/debug/insert4_neg.cc
23_containers/unordered_set/debug/construct4_neg.cc
23_containers/unordered_set/debug/insert4_neg.cc
23_containers/vector/debug/assign4_neg.cc
23_containers/vector/debug/construct4_neg.cc
23_containers/vector/debug/insert4_neg.cc

[Bug testsuite/60794] 25 libstdc++ tests are missing '{ dg-require-debug-mode "" }'

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60794

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Why do you think they require debug mode?

Those tests are supposed to run in normal mode, that's why they explicitly use
<debug/vector> and __gnu_debug::vector (which is how to use the debug
containers in normal mode)

[Bug testsuite/60794] 25 libstdc++ tests are missing '{ dg-require-debug-mode "" }'

[gnugcc at marino dot st]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60794

--- Comment #2 from John Marino <gnugcc at marino dot st> ---
Hmmm, only 3 of the 25 files use <debug/vector> and __gnu_debug::vector
  23_containers/vector/debug/assign4_neg.cc
  23_containers/vector/debug/construct4_neg.cc
  23_containers/vector/debug/insert4_neg.cc

That said, all 25 have some form of "#include <debug/X>" and __gnu_debug::X so
likely you were only applying an example for one subset.

I honestly can't remember the exact failure that this solved at the time (gcc
4.6 timeframe).  I want to say the first file I fixed back then was
deque/debug/assign4_neg.cc

It's possible that that I saw debug-mode used in the 1,2,3 versions and thought
it was oversight with the 4 versions, but I would have only looked at it upon a
failure.


All that said, if all 25 look right to you then I'll humbly accept it and a
closed/invalid bug status.

[Bug testsuite/60794] 25 libstdc++ tests are missing '{ dg-require-debug-mode "" }'

[gnugcc at marino dot st]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60794

John Marino <gnugcc at marino dot st> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from John Marino <gnugcc at marino dot st> ---
report was invalid, closing.