[Bug target/60817] New: gcc configure script misdetects TLS support on x86_64-pc-solaris* with gnu as

[Bug target/60817] New: gcc configure script misdetects TLS support on x86_64-pc-solaris* with gnu as

[redlizard at redlizard dot nl]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60817

            Bug ID: 60817
           Summary: gcc configure script misdetects TLS support on
                    x86_64-pc-solaris* with gnu as
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: minor
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: redlizard at redlizard dot nl

Created attachment 32584
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32584&action=edit
Proposed patch.

When building gcc >= 4.7 on x86_64-pc-solaris2.11 --with-gnu-as, the
gcc/configure script incorrectly decides that gnu as does not support real TLS,
and so unnecessarily decides to activate emutls instead.

The solaris-specific test checks this support by trying to assemble a piece of
TLS-using assembly code, and it uses the same 32-bit code for this test both on
32-bit and 64-bit platforms. The solaris assembler will accept this, but gnu as
fails on the 32 bit code when targeting x86_64-pc-solaris*, thus causing the
detection to fail.

Attached patch for 4.9 fixes the problem, and is trivially backported to 4.8
and 4.7.

[Bug target/60817] gcc configure script misdetects TLS support on x86_64-pc-solaris* with gnu as

[ro at CeBiTec dot Uni-Bielefeld.DE]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60817

--- Comment #1 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
I'll have a look.  The patch is completely bogus, though: it seems to
have been hand-edited to the point where it doesn't even apply.

That said, we need to make sure that several different configurations
correctly detect native TLS support, both for i386-*-solaris2* and
x86_64-*-solaris2* configurations:

    32-bit gas (not necessarily in x86_64 case)
    64-bit gas
    /bin/as

I'm pretty sure this won't make 4.9.0, though.

    Rainer

[Bug target/60817] gcc configure script misdetects TLS support on x86_64-pc-solaris* with gnu as

[redlizard at redlizard dot nl]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60817

--- Comment #2 from Ruud Koolen <redlizard at redlizard dot nl> ---
I generated the patch cleanly against trunk. What's wrong with it?

[Bug target/60817] gcc configure script misdetects TLS support on x86_64-pc-solaris* with gnu as

[ro at CeBiTec dot Uni-Bielefeld.DE]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60817

--- Comment #3 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #2 from Ruud Koolen <redlizard at redlizard dot nl> ---
> I generated the patch cleanly against trunk. What's wrong with it?

Seems to be a quirk of bugzilla: if you download the patch via

Diff -> Context: File -> Raw Unified

you get garbage.

As I said, I'll have a look and test in various different
configurations.  One think I dislike about your current patch is the
duplication of tls_section_flag.

    Rainer

[Bug target/60817] gcc configure script misdetects TLS support on x86_64-pc-solaris* with gnu as

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60817

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
                URL|                            |http://gcc.gnu.org/ml/gcc-p
                   |                            |atches/2014-04/msg00796.htm
                   |                            |l
   Last reconfirmed|                            |2014-04-15
   Target Milestone|---                         |4.10.0
     Ever confirmed|0                           |1

--- Comment #4 from Rainer Orth <ro at gcc dot gnu.org> ---
Patch submitted.

[Bug target/60817] gcc configure script misdetects TLS support on x86_64-pc-solaris* with gnu as

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60817

--- Comment #5 from Rainer Orth <ro at gcc dot gnu.org> ---
Author: ro
Date: Wed Apr 16 09:09:42 2014
New Revision: 209440

URL: http://gcc.gnu.org/viewcvs?rev=209440&root=gcc&view=rev
Log:
Correctly detect native TLS support with 64-bit gas on Solaris/x86 (PR
target/60817)

    PR target/60817
    * configure.ac (set_have_as_tls): Merge i[34567]86-*-* and
    x86_64-*-* cases.
    Pass necessary as flags on 64-bit Solaris/x86.
    Use lowercase relocs for x86_64-*-*.
    * configure: Regenerate.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/configure   (contents, props changed)
    trunk/gcc/configure.ac

[Bug target/60817] gcc configure script misdetects TLS support on x86_64-pc-solaris* with gnu as

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60817

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Rainer Orth <ro at gcc dot gnu.org> ---
Fixed for 4.10.0.