[Bug tree-optimization/60849] New: bogus comparison result type

[Bug tree-optimization/60849] New: bogus comparison result type

[dehao at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60849

            Bug ID: 60849
           Summary: bogus comparison result type
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dehao at gcc dot gnu.org

Created attachment 32605
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32605&action=edit
testcase

In execute_fold_all_builtins, the builtin is expanded to UNORDERED_EXPR, but
its lhs is not updated to boolean type.

#gcc -c test.cc -O2
test.cc: In function ‘void foo(float)’:
test.cc:10:1: error: bogus comparison result type
 }
 ^
int
_7 = _4 unord _4;
test.cc:10:1: internal compiler error: verify_gimple failed
0xbadd91 verify_gimple_in_cfg(function*)
    ../../gcc/tree-cfg.c:4942
0xad3d94 execute_function_todo
    ../../gcc/passes.c:1853
0xad47c3 execute_todo
    ../../gcc/passes.c:1887
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.
>From gcc-bugs-return-449089-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Apr 15 18:12:07 2014
Return-Path: <gcc-bugs-return-449089-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 26601 invoked by alias); 15 Apr 2014 18:12:06 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 26508 invoked by uid 48); 15 Apr 2014 18:12:03 -0000
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/60848] [4.7/4.8/4.9/4.10 Regression] Crash while experimenting with c++-0x initializer lists
Date: Tue, 15 Apr 2014 18:12:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.8.1
X-Bugzilla-Keywords: ice-on-invalid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: redi at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: keywords
Message-ID: <bug-60848-4-WbrBDcEWW9@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-60848-4@http.gcc.gnu.org/bugzilla/>
References: <bug-60848-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-04/txt/msg01109.txt.bz2
Content-length: 461

http://gcc.gnu.org/bugzilla/show_bug.cgi?id`848

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-invalid-code

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
This is of course totally invalid code, you can't define std::initializer_list
yourself.

[Bug tree-optimization/60849] bogus comparison result type

[ppluzhnikov at google dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60849

Paul Pluzhnikov <ppluzhnikov at google dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ppluzhnikov at google dot com

--- Comment #1 from Paul Pluzhnikov <ppluzhnikov at google dot com> ---
Google ref: b/13715169

[Bug tree-optimization/60849] [4.7/4.8/4.9/4.10 Regression] bogus comparison result type

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60849

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-04-15
                 CC|                            |mpolacek at gcc dot gnu.org
            Summary|bogus comparison result     |[4.7/4.8/4.9/4.10
                   |type                        |Regression] bogus
                   |                            |comparison result type
     Ever confirmed|0                           |1

--- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Started with r176563.

[Bug tree-optimization/60849] [4.7/4.8/4.9/4.10 Regression] bogus comparison result type

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60849

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
   Target Milestone|---                         |4.7.4

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
I will have a look.

[Bug tree-optimization/60849] [4.7/4.8/4.9 Regression] bogus comparison result type

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60849

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |4.10.0
            Summary|[4.7/4.8/4.9/4.10           |[4.7/4.8/4.9 Regression]
                   |Regression] bogus           |bogus comparison result
                   |comparison result type      |type
      Known to fail|                            |4.9.0

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed on trunk sofar.

[Bug tree-optimization/60849] [4.7/4.8/4.9/4.10 Regression] bogus comparison result type

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60849

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Author: rguenth
Date: Thu Apr 17 08:13:53 2014
New Revision: 209469

URL: http://gcc.gnu.org/viewcvs?rev=209469&root=gcc&view=rev
Log:
2014-04-17  Richard Biener  <rguenther@suse.de>

    PR middle-end/60849
    * tree-ssa-propagate.c (valid_gimple_rhs_p): Only allow effective
    boolean results for comparisons.

    * g++.dg/opt/pr60849.C: New testcase.

Added:
    trunk/gcc/testsuite/g++.dg/opt/pr60849.C
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-ssa-propagate.c

[Bug tree-optimization/60849] [4.7/4.8/4.9 Regression] bogus comparison result type

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60849

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
Author: rguenth
Date: Thu Apr 17 13:50:55 2014
New Revision: 209486

URL: http://gcc.gnu.org/viewcvs?rev=209486&root=gcc&view=rev
Log:
2014-04-17  Richard Biener  <rguenther@suse.de>

    PR middle-end/60849
    * tree-ssa-propagate.c (valid_gimple_rhs_p): Allow vector
    comparison results and add clarifying comment.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-ssa-propagate.c

[Bug tree-optimization/60849] [4.7/4.8/4.9 Regression] bogus comparison result type

[dehao at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60849

--- Comment #8 from dehao at gcc dot gnu.org ---
Richard,

Thanks for the quick fix. Are both patches needed? Could you backport your
patches to gcc-4_9 branch?

Thanks,
Dehao

[Bug tree-optimization/60849] [4.7/4.8/4.9 Regression] bogus comparison result type

[rguenther at suse dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60849

--- Comment #9 from rguenther at suse dot de <rguenther at suse dot de> ---
On Thu, 17 Apr 2014, dehao at gcc dot gnu.org wrote:

> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60849
> 
> --- Comment #8 from dehao at gcc dot gnu.org ---
> Richard,
> 
> Thanks for the quick fix. Are both patches needed? Could you backport your
> patches to gcc-4_9 branch?

Sure, after 4.9.0 is out.

[Bug tree-optimization/60849] [4.7/4.8 Regression] bogus comparison result type

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60849

--- Comment #11 from Richard Biener <rguenth at gcc dot gnu.org> ---
Author: rguenth
Date: Tue May  6 09:02:08 2014
New Revision: 210099

URL: http://gcc.gnu.org/viewcvs?rev=210099&root=gcc&view=rev
Log:
2014-05-06  Richard Biener  <rguenther@suse.de>

    Backport from mainline
    2014-04-17  Richard Biener  <rguenther@suse.de>

    PR middle-end/60849
    * tree-ssa-propagate.c (valid_gimple_rhs_p): Only allow effective
    boolean results for comparisons.

    * g++.dg/opt/pr60849.C: New testcase.

    2014-04-07  Richard Biener  <rguenther@suse.de>

    PR tree-optimization/60766
    * tree-ssa-loop-ivopts.c (cand_value_at): Compute in an
    unsigned type.
    (may_eliminate_iv): Convert cand_value_at result to desired
    type.

    * gcc.dg/torture/pr60766.c: New testcase.

    2014-04-23  Richard Biener  <rguenther@suse.de>

    PR tree-optimization/60903
    * tree-ssa-loop-im.c (execute_sm_if_changed): Properly apply
    IRREDUCIBLE_LOOP loop flags to newly created BBs and edges.

    * gcc.dg/torture/pr60903.c: New testcase.

Added:
    branches/gcc-4_8-branch/gcc/testsuite/g++.dg/opt/pr60849.C
    branches/gcc-4_8-branch/gcc/testsuite/gcc.dg/torture/pr60766.c
    branches/gcc-4_8-branch/gcc/testsuite/gcc.dg/torture/pr60903.c
Modified:
    branches/gcc-4_8-branch/gcc/ChangeLog
    branches/gcc-4_8-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_8-branch/gcc/tree-ssa-loop-im.c
    branches/gcc-4_8-branch/gcc/tree-ssa-loop-ivopts.c
    branches/gcc-4_8-branch/gcc/tree-ssa-propagate.c

[Bug tree-optimization/60849] [4.7 Regression] bogus comparison result type

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60849

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|4.7.4                       |4.8.3
      Known to fail|                            |4.7.4

--- Comment #12 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed for 4.8.3.