public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/60854] [4.9/4.10 Regression] inline constructor of extern template
Date: Wed, 16 Apr 2014 21:06:00 -0000	[thread overview]
Message-ID: <bug-60854-4-IW2a5x5PtX@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-60854-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60854

--- Comment #3 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
OK, the problem is that we see the reference to alias and decide to keep the
alias for future inlining. But when processing the refernce from alias to
function itself, we throw it away. We need to keep the body, too ;)

(the existing node->alias check actually cares about oposite case where we want
to keep weakrefs)

Index: ipa.c
===================================================================
--- ipa.c       (revision 209435)
+++ ipa.c       (working copy)
@@ -138,7 +138,7 @@ process_references (struct ipa_ref_list
       symtab_node *node = ref->referred;

       if (node->definition && !node->in_other_partition
-         && ((!DECL_EXTERNAL (node->decl) || node->alias)
+         && ((!DECL_EXTERNAL (node->decl) || node->alias || ref->use ==
IPA_REF_ALIAS)
              || (((before_inlining_p
                    && (cgraph_state < CGRAPH_STATE_IPA_SSA
                        || !lookup_attribute ("always_inline",


  parent reply	other threads:[~2014-04-16 21:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-15 21:21 [Bug c++/60854] New: " joachim.schoeberl at tuwien dot ac.at
2014-04-16  8:32 ` [Bug ipa/60854] [4.9/4.10 Regression] " rguenth at gcc dot gnu.org
2014-04-16 21:06 ` hubicka at gcc dot gnu.org [this message]
2014-04-17  2:23 ` hubicka at gcc dot gnu.org
2014-04-17  8:10 ` [Bug ipa/60854] [4.9 " rguenth at gcc dot gnu.org
2014-05-17 22:19 ` hubicka at gcc dot gnu.org
2014-06-26 13:01 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-60854-4-IW2a5x5PtX@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).