public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug go/60870] New: go interface methods broken on ppc64le (bug296.go)
@ 2014-04-17 5:27 anton at samba dot org
2014-04-17 10:42 ` [Bug go/60870] " uweigand at gcc dot gnu.org
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: anton at samba dot org @ 2014-04-17 5:27 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60870
Bug ID: 60870
Summary: go interface methods broken on ppc64le (bug296.go)
Product: gcc
Version: 4.10.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: go
Assignee: ian at airs dot com
Reporter: anton at samba dot org
bug296.go is failing on a checkout from today.
The caller is putting the 9th argument in r1+32 instead of r1+96 where we
expect:
0x000000001000195c <+140>: std r27,32(r1) <-----
0x0000000010001960 <+144>: li r10,22
0x0000000010001964 <+148>: std r2,24(r1)
0x0000000010001968 <+152>: addi r31,r31,1
0x000000001000196c <+156>: mtctr r11
The failure bisected to:
2c809f8f2584460a5207662cc8e064486cb0ec30 (Sync to current external repository)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug go/60870] go interface methods broken on ppc64le (bug296.go)
2014-04-17 5:27 [Bug go/60870] New: go interface methods broken on ppc64le (bug296.go) anton at samba dot org
@ 2014-04-17 10:42 ` uweigand at gcc dot gnu.org
2014-04-17 16:37 ` ian at airs dot com
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: uweigand at gcc dot gnu.org @ 2014-04-17 10:42 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60870
Ulrich Weigand <uweigand at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2014-04-17
CC| |uweigand at gcc dot gnu.org
Ever confirmed|0 |1
--- Comment #2 from Ulrich Weigand <uweigand at gcc dot gnu.org> ---
Confirmed.
This commit seems to have reverted the effects of the bug fix here:
http://gcc.gnu.org/ml/gcc-patches/2013-11/msg02994.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug go/60870] go interface methods broken on ppc64le (bug296.go)
2014-04-17 5:27 [Bug go/60870] New: go interface methods broken on ppc64le (bug296.go) anton at samba dot org
2014-04-17 10:42 ` [Bug go/60870] " uweigand at gcc dot gnu.org
@ 2014-04-17 16:37 ` ian at airs dot com
2014-04-17 16:38 ` ian at airs dot com
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: ian at airs dot com @ 2014-04-17 16:37 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60870
--- Comment #3 from Ian Lance Taylor <ian at airs dot com> ---
Created attachment 32626
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32626&action=edit
possible patch
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug go/60870] go interface methods broken on ppc64le (bug296.go)
2014-04-17 5:27 [Bug go/60870] New: go interface methods broken on ppc64le (bug296.go) anton at samba dot org
2014-04-17 10:42 ` [Bug go/60870] " uweigand at gcc dot gnu.org
2014-04-17 16:37 ` ian at airs dot com
@ 2014-04-17 16:38 ` ian at airs dot com
2014-04-17 19:04 ` uweigand at gcc dot gnu.org
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: ian at airs dot com @ 2014-04-17 16:38 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60870
Ian Lance Taylor <ian at airs dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #4 from Ian Lance Taylor <ian at airs dot com> ---
I don't have a PPC system. Can you see if the attached patch to
gcc/go/gofrontend/expressions.cc fixes the problem?
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug go/60870] go interface methods broken on ppc64le (bug296.go)
2014-04-17 5:27 [Bug go/60870] New: go interface methods broken on ppc64le (bug296.go) anton at samba dot org
` (2 preceding siblings ...)
2014-04-17 16:38 ` ian at airs dot com
@ 2014-04-17 19:04 ` uweigand at gcc dot gnu.org
2014-04-17 19:28 ` ian at gcc dot gnu.org
2014-04-17 19:28 ` ian at airs dot com
5 siblings, 0 replies; 7+ messages in thread
From: uweigand at gcc dot gnu.org @ 2014-04-17 19:04 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60870
--- Comment #5 from Ulrich Weigand <uweigand at gcc dot gnu.org> ---
(In reply to Ian Lance Taylor from comment #4)
> I don't have a PPC system. Can you see if the attached patch to
> gcc/go/gofrontend/expressions.cc fixes the problem?
Yes, this makes bug296.go PASS again on powerpc64le.
Thanks for the quick fix!
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug go/60870] go interface methods broken on ppc64le (bug296.go)
2014-04-17 5:27 [Bug go/60870] New: go interface methods broken on ppc64le (bug296.go) anton at samba dot org
` (3 preceding siblings ...)
2014-04-17 19:04 ` uweigand at gcc dot gnu.org
@ 2014-04-17 19:28 ` ian at gcc dot gnu.org
2014-04-17 19:28 ` ian at airs dot com
5 siblings, 0 replies; 7+ messages in thread
From: ian at gcc dot gnu.org @ 2014-04-17 19:28 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60870
--- Comment #6 from ian at gcc dot gnu.org <ian at gcc dot gnu.org> ---
Author: ian
Date: Thu Apr 17 19:27:22 2014
New Revision: 209494
URL: http://gcc.gnu.org/viewcvs?rev=209494&root=gcc&view=rev
Log:
PR go/60870
compiler: Don't convert function type for an interface method.
For an interface method the function type is the type without
the receiver, which is wrong since we are passing a receiver.
The interface method will always have the correct type in this
case, so no type conversion is necessary.
Also don't do the type conversion when calling a named
function, since in that case the type is also always correct.
The type can be wrong, and the conversion required, when the
function type refers to itself recursively.
Modified:
trunk/gcc/go/gofrontend/expressions.cc
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug go/60870] go interface methods broken on ppc64le (bug296.go)
2014-04-17 5:27 [Bug go/60870] New: go interface methods broken on ppc64le (bug296.go) anton at samba dot org
` (4 preceding siblings ...)
2014-04-17 19:28 ` ian at gcc dot gnu.org
@ 2014-04-17 19:28 ` ian at airs dot com
5 siblings, 0 replies; 7+ messages in thread
From: ian at airs dot com @ 2014-04-17 19:28 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60870
Ian Lance Taylor <ian at airs dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #7 from Ian Lance Taylor <ian at airs dot com> ---
Fixed.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-04-17 19:28 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-17 5:27 [Bug go/60870] New: go interface methods broken on ppc64le (bug296.go) anton at samba dot org
2014-04-17 10:42 ` [Bug go/60870] " uweigand at gcc dot gnu.org
2014-04-17 16:37 ` ian at airs dot com
2014-04-17 16:38 ` ian at airs dot com
2014-04-17 19:04 ` uweigand at gcc dot gnu.org
2014-04-17 19:28 ` ian at gcc dot gnu.org
2014-04-17 19:28 ` ian at airs dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).