[Bug go/60870] New: go interface methods broken on ppc64le (bug296.go)

[Bug go/60870] New: go interface methods broken on ppc64le (bug296.go)

[anton at samba dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60870

            Bug ID: 60870
           Summary: go interface methods broken on ppc64le (bug296.go)
           Product: gcc
           Version: 4.10.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: go
          Assignee: ian at airs dot com
          Reporter: anton at samba dot org

bug296.go is failing on a checkout from today.

The caller is putting the 9th argument in r1+32 instead of r1+96 where we
expect:

   0x000000001000195c <+140>:    std     r27,32(r1) <-----
   0x0000000010001960 <+144>:    li      r10,22
   0x0000000010001964 <+148>:    std     r2,24(r1)
   0x0000000010001968 <+152>:    addi    r31,r31,1
   0x000000001000196c <+156>:    mtctr   r11

The failure bisected to:

2c809f8f2584460a5207662cc8e064486cb0ec30 (Sync to current external repository)

[Bug go/60870] go interface methods broken on ppc64le (bug296.go)

[uweigand at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60870

Ulrich Weigand <uweigand at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-04-17
                 CC|                            |uweigand at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #2 from Ulrich Weigand <uweigand at gcc dot gnu.org> ---
Confirmed.

This commit seems to have reverted the effects of the bug fix here:
http://gcc.gnu.org/ml/gcc-patches/2013-11/msg02994.html

[Bug go/60870] go interface methods broken on ppc64le (bug296.go)

[ian at airs dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60870

--- Comment #3 from Ian Lance Taylor <ian at airs dot com> ---
Created attachment 32626
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32626&action=edit
possible patch

[Bug go/60870] go interface methods broken on ppc64le (bug296.go)

[ian at airs dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60870

Ian Lance Taylor <ian at airs dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #4 from Ian Lance Taylor <ian at airs dot com> ---
I don't have a PPC system.  Can you see if the attached patch to
gcc/go/gofrontend/expressions.cc fixes the problem?

[Bug go/60870] go interface methods broken on ppc64le (bug296.go)

[uweigand at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60870

--- Comment #5 from Ulrich Weigand <uweigand at gcc dot gnu.org> ---
(In reply to Ian Lance Taylor from comment #4)
> I don't have a PPC system.  Can you see if the attached patch to
> gcc/go/gofrontend/expressions.cc fixes the problem?

Yes, this makes bug296.go PASS again on powerpc64le.

Thanks for the quick fix!

[Bug go/60870] go interface methods broken on ppc64le (bug296.go)

[ian at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60870

--- Comment #6 from ian at gcc dot gnu.org <ian at gcc dot gnu.org> ---
Author: ian
Date: Thu Apr 17 19:27:22 2014
New Revision: 209494

URL: http://gcc.gnu.org/viewcvs?rev=209494&root=gcc&view=rev
Log:
    PR go/60870

compiler: Don't convert function type for an interface method.

For an interface method the function type is the type without
the receiver, which is wrong since we are passing a receiver.
The interface method will always have the correct type in this
case, so no type conversion is necessary.

Also don't do the type conversion when calling a named
function, since in that case the type is also always correct.

The type can be wrong, and the conversion required, when the
function type refers to itself recursively.

Modified:
    trunk/gcc/go/gofrontend/expressions.cc

[Bug go/60870] go interface methods broken on ppc64le (bug296.go)

[ian at airs dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60870

Ian Lance Taylor <ian at airs dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Ian Lance Taylor <ian at airs dot com> ---
Fixed.