[Bug tree-optimization/60871] New: internal compiler error: in possible_polymorphic_call_targets, at ipa-devirt.c:1510

[Bug tree-optimization/60871] New: internal compiler error: in possible_polymorphic_call_targets, at ipa-devirt.c:1510

[holger.hopp at sap dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60871

            Bug ID: 60871
           Summary: internal compiler error: in
                    possible_polymorphic_call_targets, at
                    ipa-devirt.c:1510
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: holger.hopp at sap dot com

Following code throws an internal compiler error with g++-4.9 -O2

$ g++ -O2 -c tst.c
tst.c: In static member function ‘static void C11::comp()’:
tst.c:88:1: internal compiler error: in possible_polymorphic_call_targets, at
ipa-devirt.c:1510
 }
 ^
0x9e77a8 possible_polymorphic_call_targets(tree_node*, long,
ipa_polymorphic_call_context, bool*, void**, int*)
    ../../gcc/ipa-devirt.c:1510
0x9a3b67 possible_polymorphic_call_targets(tree_node*, bool*, void**)
    ../../gcc/ipa-utils.h:142
0x9a0d56 gimple_fold_call
    ../../gcc/gimple-fold.c:1126
0x9a0d56 fold_stmt_1
    ../../gcc/gimple-fold.c:1239
0xbbc5b9 fold_marked_statements
    ../../gcc/tree-inline.c:4541
0xbc9b54 optimize_inline_calls(tree_node*)
    ../../gcc/tree-inline.c:4622
0x10639b9 early_inliner
    ../../gcc/ipa-inline.c:2303
0x10639b9 execute
    ../../gcc/ipa-inline.c:2366
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.

Source:

void *vptr;

class C2
{
public:
  static inline C2 * cbss()
  {
    singleton = (C2 *)vptr;
    return singleton;
  }

private:
  static C2 * singleton;
};

class C3
{
public:
  C3(void) {}
  virtual void sf();
protected:
  unsigned m_local:1;
};

class C4 : virtual public C3
{
public:
 C4(void) : C3() {}
protected:
  void sf() { }
  void uf() { }
};

class C5
{
private:
  C3 * m_g;
public:
  C5(C3 * g) : m_g(g)  { m_g->sf(); }
};

class C6
{
public:
  virtual ~C6() {}
};

class C7 : public C6
{
protected:
  C7(void) {}
};

class C8 : public C4, public C7
{
public:
 C8(void) : C3(), C4(), C7() { }
};

class C9 : public C8
{
public:
 C9(void) : C3(), C8() { }
};

class C10 : public C9
{
protected:
 C10(void) : C3(), C9() { }    
};

class C11 : public C10
{
protected:
 C11( const C2 * s ) : C3(), C10() { }

public:
  static void comp(void)
  {
    C11 a(C2::cbss());
    C5 uf(&a);
  }
};

void foo (void)
{
  C11::comp();
}
>From gcc-bugs-return-449250-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Apr 17 11:03:11 2014
Return-Path: <gcc-bugs-return-449250-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 9822 invoked by alias); 17 Apr 2014 11:03:11 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 9799 invoked by uid 48); 17 Apr 2014 11:03:08 -0000
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/60866] [4.7/4.8/4.9/4.10 Regression] ICE: in get_seqno_for_a_jump, at sel-sched-ir.c:4068 with -fselective-scheduling -fno-if-conversion
Date: Thu, 17 Apr 2014 11:03:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Version: 4.10.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.7.4
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cf_gcctarget bug_status cf_reconfirmed_on target_milestone everconfirmed
Message-ID: <bug-60866-4-IucSdH7k1d@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-60866-4@http.gcc.gnu.org/bugzilla/>
References: <bug-60866-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-04/txt/msg01270.txt.bz2
Content-length: 597

http://gcc.gnu.org/bugzilla/show_bug.cgi?id`866

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |x86_64-*-*
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-04-17
   Target Milestone|---                         |4.7.4
     Ever confirmed|0                           |1

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed.

[Bug ipa/60871] [4.9/4.10 Regression] internal compiler error: in possible_polymorphic_call_targets, at ipa-devirt.c:1510

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60871

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
      Known to work|                            |4.8.2
   Last reconfirmed|                            |2014-04-17
          Component|tree-optimization           |ipa
                 CC|                            |hubicka at gcc dot gnu.org
     Ever confirmed|0                           |1
            Summary|internal compiler error: in |[4.9/4.10 Regression]
                   |possible_polymorphic_call_t |internal compiler error: in
                   |argets, at                  |possible_polymorphic_call_t
                   |ipa-devirt.c:1510           |argets, at
                   |                            |ipa-devirt.c:1510
   Target Milestone|---                         |4.9.1

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed.

[Bug ipa/60871] [4.9/4.10 Regression] internal compiler error: in possible_polymorphic_call_targets, at ipa-devirt.c:1510

[trippels at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60871

Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |trippels at gcc dot gnu.org

--- Comment #2 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
A bit further reduced:

class A
{
public:
  virtual void m_fn1 ();
  int m_local;
};
class C : virtual public A
{
};
class B
{
  A *m_g;

public:
  B (A *p1) : m_g (p1) { m_g->m_fn1 (); }
};
class C7
{
public:
  virtual ~C7 ();
};
class D : public C, C7
{
};
class F : D
{
  F (int);

public:
  static void m_fn2 ()
  {
    F a (0);
    B b (&a);
  }
};
void fn1 () { F::m_fn2 (); }

[Bug ipa/60871] [4.9/4.10 Regression] internal compiler error: in possible_polymorphic_call_targets, at ipa-devirt.c:1510

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60871

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Started with r207451.  Tiny bit more reduced for -O2:
struct A
{
  virtual void m_fn1 ();
  int m_local;
};
class C : virtual public A
{
};
struct B
{
  A *m_g;

  B (A *p1) : m_g (p1) { m_g->m_fn1 (); }
};
struct C7
{
  virtual ~C7 ();
};
class D : public C, C7
{
};
struct F : D
{
  F (int);

  static void m_fn2 ()
  {
    F a (0);
    B b (&a);
  }
};
void fn1 () { F::m_fn2 (); }

[Bug ipa/60871] [4.9/4.10 Regression] internal compiler error: in possible_polymorphic_call_targets, at ipa-devirt.c:1510

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60871

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #4 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Mine. Looking into it.

[Bug ipa/60871] [4.9/4.10 Regression] internal compiler error: in possible_polymorphic_call_targets, at ipa-devirt.c:1510

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60871

--- Comment #5 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
This is yet another case where get_binfo_at_offset incorrectly returns NULL
(wich is in there for long time, but before we started sanity check it just led
to missed optimizations).

In class D there is base C7 and A (that is virtual base of C). They share vtbl
pointer, but get_binfo_at_offset is organized in an assumption that sharing of
pointer doesn't happen over sibling bases.

I guess easiest fix would be to recursively dive into all bases with a given
offset, but I will try to look through C++ FE implementation first to see if
there is more elegant way around.

This may affect ipa-devirt, too, that may need to push vtable into the stack
even in the sibling walk.

Honza

[Bug ipa/60871] [4.9/4.10 Regression] internal compiler error: in possible_polymorphic_call_targets, at ipa-devirt.c:1510

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60871

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |hubicka at gcc dot gnu.org

--- Comment #6 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
assigned.

[Bug ipa/60871] [4.9/4.10 Regression] internal compiler error: in possible_polymorphic_call_targets, at ipa-devirt.c:1510

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60871

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

[Bug ipa/60871] [4.9/4.10 Regression] internal compiler error: in possible_polymorphic_call_targets, at ipa-devirt.c:1510

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60871

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.1                       |4.9.2

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.1 has been released.

[Bug ipa/60871] [4.9/5 Regression] internal compiler error: in possible_polymorphic_call_targets, at ipa-devirt.c:1510

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60871

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.2                       |4.9.3

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.2 has been released.

[Bug ipa/60871] [4.9/5 Regression] internal compiler error: in possible_polymorphic_call_targets, at ipa-devirt.c:1510

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60871

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Honza, any progress on this?  People are regularly hitting this ICE in 4.9.x...

[Bug ipa/60871] [4.9/5 Regression] internal compiler error: in possible_polymorphic_call_targets, at ipa-devirt.c:1510

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60871

--- Comment #10 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Patch posted at https://gcc.gnu.org/ml/gcc-patches/2015-01/msg02426.html

[Bug ipa/60871] [4.9/5 Regression] internal compiler error: in possible_polymorphic_call_targets, at ipa-devirt.c:1510

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60871

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcb314 at hotmail dot com

--- Comment #11 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
*** Bug 64139 has been marked as a duplicate of this bug. ***

[Bug ipa/60871] [4.9/5 Regression] internal compiler error: in possible_polymorphic_call_targets, at ipa-devirt.c:1510

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60871

--- Comment #12 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
*** Bug 64538 has been marked as a duplicate of this bug. ***

[Bug ipa/60871] [4.9/5 Regression] internal compiler error: in possible_polymorphic_call_targets, at ipa-devirt.c:1510

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60871

--- Comment #13 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Author: hubicka
Date: Tue Jan 27 19:39:37 2015
New Revision: 220185

URL: https://gcc.gnu.org/viewcvs?rev=220185&root=gcc&view=rev
Log:

    PR ipa/60871
    PR ipa/64139
    * tree.c (lookup_binfo_at_offset): New function.
    (get_binfo_at_offset): Use it.

    * g++.dg/torture/pr64139.C: New testcase.
    * g++.dg/torture/pr60871.C: Likewise.

Added:
    trunk/gcc/testsuite/g++.dg/torture/pr60871.C
    trunk/gcc/testsuite/g++.dg/torture/pr64139.C
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree.c

[Bug ipa/60871] [4.9 Regression] internal compiler error: in possible_polymorphic_call_targets, at ipa-devirt.c:1510

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60871

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.9/5 Regression] internal |[4.9 Regression] internal
                   |compiler error: in          |compiler error: in
                   |possible_polymorphic_call_t |possible_polymorphic_call_t
                   |argets, at                  |argets, at
                   |ipa-devirt.c:1510           |ipa-devirt.c:1510

--- Comment #14 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Fixed on trunk

[Bug ipa/60871] [4.9 Regression] internal compiler error: in possible_polymorphic_call_targets, at ipa-devirt.c:1510

[boris at kolpackov dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60871

Boris Kolpackov <boris at kolpackov dot net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |boris at kolpackov dot net

--- Comment #15 from Boris Kolpackov <boris at kolpackov dot net> ---
I just tried gcc-4.9-20150204[1] which seems to have been packaged after your
commit, and I still get the ICE.

[1] https://gcc.gnu.org/ml/gcc/2015-02/msg00035.html

[Bug ipa/60871] [4.9 Regression] internal compiler error: in possible_polymorphic_call_targets, at ipa-devirt.c:1510

[hubicka at ucw dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60871

--- Comment #16 from Jan Hubicka <hubicka at ucw dot cz> ---
> I just tried gcc-4.9-20150204[1] which seems to have been packaged after your
> commit, and I still get the ICE.
This is probably because I commited the fix to mainline only (GCC-5), I will
backport
it to GCC-4.9

[Bug ipa/60871] [4.9 Regression] internal compiler error: in possible_polymorphic_call_targets, at ipa-devirt.c:1510

[jussilehtola at fedoraproject dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60871

Susi Lehtola <jussilehtola at fedoraproject dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jussilehtola@fedoraproject.
                   |                            |org

--- Comment #17 from Susi Lehtola <jussilehtola at fedoraproject dot org> ---
Any progress on the backport?

[Bug ipa/60871] [4.9 Regression] internal compiler error: in possible_polymorphic_call_targets, at ipa-devirt.c:1510

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60871

--- Comment #18 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.3 has been released.

[Bug ipa/60871] [4.9 Regression] internal compiler error: in possible_polymorphic_call_targets, at ipa-devirt.c:1510

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60871

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.3                       |4.9.4