[Bug tree-optimization/60896] New: [4.10 Regression] ICE: in vect_get_vec_def_for_operand, at tree-vect-stmts.c:1449

[Bug tree-optimization/60896] New: [4.10 Regression] ICE: in vect_get_vec_def_for_operand, at tree-vect-stmts.c:1449

[trippels at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60896

            Bug ID: 60896
           Summary: [4.10 Regression] ICE: in
                    vect_get_vec_def_for_operand, at
                    tree-vect-stmts.c:1449
           Product: gcc
           Version: 4.10.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: trippels at gcc dot gnu.org

markus@x4 skia % cat test.ii
struct A
{
  int m_fn1 ();
  short *m_fn2 ();
};
struct B
{
  void *fC;
};
int a, b;
unsigned char i;
void fn1 (unsigned char *p1, A &p2)
{
  int c = p2.m_fn1 ();
  for (int d = 0; c; d++)
    {
      short *e = p2.m_fn2 ();
      unsigned char *f = &p1[0];
      for (int g = 0; g < a; g++)
        {
          int h = e[0];
          b += h * f[g];
        }
    }
}

void fn2 (A &p1, A &p2, B &p3)
{
  int j = p2.m_fn1 ();
  for (int k = 0; j; k++)
    if (0)
      ;
    else
      fn1 (&i, p1);
  if (p3.fC)
    ;
  else
    ;
}

markus@x4 skia % g++ -c -O3 test.ii
test.ii: In function ‘void fn2(A&, A&, B&)’:
test.ii:27:6: internal compiler error: in vect_get_vec_def_for_operand, at
tree-vect-stmts.c:1449
 void fn2 (A &p1, A &p2, B &p3)
      ^
Please submit a full bug report,
>From gcc-bugs-return-449349-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Apr 19 18:09:25 2014
Return-Path: <gcc-bugs-return-449349-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 5564 invoked by alias); 19 Apr 2014 18:09:24 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 5546 invoked by uid 48); 19 Apr 2014 18:09:20 -0000
From: "trippels at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug gcov-profile/60897] New: Mangled function name in warning during -fprofile-use phase of Firefox build
Date: Sat, 19 Apr 2014 18:09:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: gcov-profile
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: trippels at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-60897-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-04/txt/msg01369.txt.bz2
Content-length: 3127

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60897

            Bug ID: 60897
           Summary: Mangled function name in warning during -fprofile-use
                    phase of Firefox build
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: gcov-profile
          Assignee: unassigned at gcc dot gnu.org
          Reporter: trippels at gcc dot gnu.org

During Firefox PGO build I noticed an mangled function name 
in a warning during -fprofile-use phase:

markus@x4 src % c++ -o Unified_cpp_js_src2.o -c  -I../../dist/system_wrappers
-include /var/tmp/mozilla-central/config/gcc_hidden.h -DENABLE_PARALLEL_JS
-DENABLE_BINARYDATA -DENABLE_SHARED_ARRAY_BUFFER -DEXPORT_JS_API
-DJS_HAS_CTYPES -DDLL_PREFIX='"lib"' -DDLL_SUFFIX='".so"' -DUSE_SYSTEM_MALLOC=1
-DENABLE_ASSEMBLER=1 -DENABLE_JIT=1 -DMOZ_GLUE_IN_PROGRAM -DNO_NSPR_10_SUPPORT
-DUSE_ZLIB -I/var/tmp/mozilla-central/js/src -I.
-I/usr/lib64/libffi-3.0.13/include 
-I/var/tmp/mozilla-central/js/src/../../mfbt/double-conversion 
-I../../dist/include  -I/usr/include/nspr        -fPIC   -DMOZILLA_CLIENT
-include ../../js/src/js-confdefs.h -MD -MP -MF .deps/Unified_cpp_js_src2.o.pp 
-Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type
-Werror=int-to-pointer-cast -Wtype-limits -Wempty-body -Werror=conversion-null
-Wsign-compare -Wno-invalid-offsetof -Wcast-align -fprofile-use
-fprofile-correction -ffunction-sections -fdata-sections -march=amdfam10
-fno-rtti -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe  -DNDEBUG
-DTRIMMED -O3 -fomit-frame-pointer    
/var/tmp/moz-build-dir/js/src/Unified_cpp_js_src2.cpp
In file included from
/var/tmp/moz-build-dir/js/src/Unified_cpp_js_src2.cpp:106:0:
/var/tmp/mozilla-central/js/src/jit/BaselineIC.cpp: In function ‘bool
js::jit::_ZN2js3jitL26TryAttachNativeGetPropStubEP9JSContextN2JS6HandleIP8JSScriptEEPhPNS0_18ICGetProp_FallbackENS4_IPNS_12PropertyNameEEENS4_INS3_5ValueEEESF_Pb.isra.1329(JSContext*,
JS::HandleScript, jsbytecode*, js::jit::ICGetProp_Fallback*,
js::HandlePropertyName, JS::HandleValue, bool*)’:
/var/tmp/mozilla-central/js/src/jit/BaselineIC.cpp:6215:13: warning:
‘domProxyHasGeneration’ may be used uninitialized in this function
[-Wmaybe-uninitialized]
             if (domProxyHasGeneration) {
             ^
/var/tmp/mozilla-central/js/src/jit/BaselineIC.cpp:6245:20: warning:
‘domProxyShadowsResult’ may be used uninitialized in this function
[-Wmaybe-uninitialized]
     if (isDOMProxy && domProxyShadowsResult == Shadows) {
                    ^

markus@x4 src % c++filt
_ZN2js3jitL26TryAttachNativeGetPropStubEP9JSContextN2JS6HandleIP8JSScriptEEPhPNS0_18ICGetProp_FallbackENS4_IPNS_12PropertyNameEEENS4_INS3_5ValueEEESF_Pb.isra.1329
js::jit::TryAttachNativeGetPropStub(JSContext*, JS::Handle<JSScript*>, unsigned
char*, js::jit::ICGetProp_Fallback*, JS::Handle<js::PropertyName*>,
JS::Handle<JS::Value>, JS::Handle<JS::Value>, bool*) [clone .isra.1329]
>From gcc-bugs-return-449350-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Apr 19 18:09:35 2014
Return-Path: <gcc-bugs-return-449350-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 6192 invoked by alias); 19 Apr 2014 18:09:35 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 6174 invoked by uid 48); 19 Apr 2014 18:09:32 -0000
From: "trippels at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug gcov-profile/60897] Mangled function name in warning during -fprofile-use phase of Firefox build
Date: Sat, 19 Apr 2014 18:09:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: gcov-profile
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: trippels at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.1
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: target_milestone
Message-ID: <bug-60897-4-cDqML47pFK@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-60897-4@http.gcc.gnu.org/bugzilla/>
References: <bug-60897-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-04/txt/msg01370.txt.bz2
Content-length: 299

http://gcc.gnu.org/bugzilla/show_bug.cgi?id`897

Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.9.1

[Bug tree-optimization/60896] [4.10 Regression] ICE: in vect_get_vec_def_for_operand, at tree-vect-stmts.c:1449

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60896

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-04-22
   Target Milestone|---                         |4.10.0
     Ever confirmed|0                           |1

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed.

[Bug tree-optimization/60896] [4.10 Regression] ICE: in vect_get_vec_def_for_operand, at tree-vect-stmts.c:1449

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60896

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mpolacek at gcc dot gnu.org

--- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Started with r209524.

[Bug tree-optimization/60896] [4.10 Regression] ICE: in vect_get_vec_def_for_operand, at tree-vect-stmts.c:1449

[congh at google dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60896

--- Comment #3 from Cong Hou <congh at google dot com> ---
Created attachment 32668
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32668&action=edit
The patch to fix PR60896

The reason of this issue is that those statements in PATTERN_DEF_SEQ in
pre-recognized widen-mult pattern are not forwarded to later recognized
dot-product pattern. I have created a patch to fix this.

Another issue is that the def types of statements in PATTERN_DEF_SEQ are
assigned with the def type of the pattern statement. This is incorrect for
reduction pattern statement, in which case all statements in PATTERN_DEF_SEQ
will all be vect_reduction_def, and none of them will be vectorized later. The
def type of statement in PATTERN_DEF_SEQ should always be vect_internal_def.

This patch will also be submitted to gcc-patch.

[Bug tree-optimization/60896] [4.10 Regression] ICE: in vect_get_vec_def_for_operand, at tree-vect-stmts.c:1449

[congh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60896

--- Comment #4 from Cong Hou <congh at gcc dot gnu.org> ---
Author: congh
Date: Fri Apr 25 00:20:44 2014
New Revision: 209773

URL: http://gcc.gnu.org/viewcvs?rev=209773&root=gcc&view=rev
Log:
2014-04-24  Cong Hou  <congh@google.com>

    PR tree-optimization/60896
    * tree-vect-patterns.c (vect_recog_dot_prod_pattern): Pick up
    all statements in PATTERN_DEF_SEQ in recognized widen-mult pattern.
    (vect_mark_pattern_stmts): Set the def type of all statements in
    PATTERN_DEF_SEQ as vect_internal_def.

2014-04-24  Cong Hou  <congh@google.com>

    PR tree-optimization/60896
    * g++.dg/vect/pr60896.cc: New test.


Added:
    trunk/gcc/testsuite/g++.dg/vect/pr60896.cc
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-vect-patterns.c