[Bug fortran/60898] [4.8/4.9/5 Regression] model compile error with gfortran 4.7 and gcc 4.9

["mikael at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60898

Mikael Morin <mikael at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikael at gcc dot gnu.org

--- Comment #17 from Mikael Morin <mikael at gcc dot gnu.org> ---
(In reply to Jerry DeLisle from comment #16)
> Is anyone working on this one?
Not before your comment. ;-)

Using Tobias' analysis in comment #14, there is an "obvious" fix, augmenting
the reference count of the symbols present in the vector (untested):

Index: symbol.c
===================================================================
--- symbol.c    (révision 220514)
+++ symbol.c    (copie de travail)
@@ -3634,17 +3634,25 @@ do_traverse_symtree (gfc_symtree *st, void (*st_fu
     {
       /* Clear marks.  */
       for (i = 0; i < nodes; i++)
-    st_vec[i]->n.sym->mark = 0;
+    {
+      st_vec[i]->n.sym->mark = 0;
+      st_vec[i]->n.sym->refs++;
+    }
       for (i = 0; i < nodes; i++)
-    if (!st_vec[i]->n.sym->mark)
+    if (!st_vec[i]->n.sym->mark && st_vec[i]->n.sym->refs > 1)
       {
         (*sym_func) (st_vec[i]->n.sym);
         st_vec[i]->n.sym->mark = 1;
       }
+
+      for (i = 0; i < nodes; i++)
+    gfc_release_symbol (st_vec[i]->n.sym);
      }
    else
       for (i = 0; i < nodes; i++)
     (*st_func) (st_vec[i]);
+
+   free (st_vec);
 }
>From gcc-bugs-return-476699-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Feb 10 15:27:16 2015
Return-Path: <gcc-bugs-return-476699-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 30743 invoked by alias); 10 Feb 2015 15:27:15 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 18832 invoked by uid 48); 10 Feb 2015 15:27:12 -0000
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/64326] [5 Regression] ICE at -O3 on x86_64-linux-gnu in check_probability, at basic-block.h:581
Date: Tue, 10 Feb 2015 15:27:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-64326-4-EABJ9agdTt@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64326-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64326-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-02/txt/msg01032.txt.bz2
Content-length: 128

https://gcc.gnu.org/bugzilla/show_bug.cgi?idd326

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
So fixed?