[Bug rtl-optimization/60901] New: [4.8/4.9/4.10 Regression] ICE: SIGSEGV in add_to_deps_list with -fsel-sched-pipelining-outer-loops

[Bug rtl-optimization/60901] New: [4.8/4.9/4.10 Regression] ICE: SIGSEGV in add_to_deps_list with -fsel-sched-pipelining-outer-loops

[zsojka at seznam dot cz]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60901

            Bug ID: 60901
           Summary: [4.8/4.9/4.10 Regression] ICE: SIGSEGV in
                    add_to_deps_list with
                    -fsel-sched-pipelining-outer-loops
           Product: gcc
           Version: 4.10.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz

Created attachment 32635
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32635&action=edit
reduced testcase

Compiler output (under valgrind):
$ gcc -O -fselective-scheduling -fschedule-insns -fsel-sched-pipelining
-fsel-sched-pipelining-outer-loops -fno-tree-dominator-opts testcase.c
==23085== Invalid read of size 8
==23085==    at 0x1394529: add_to_deps_list(_dep_link*, _deps_list*)
(sched-deps.c:247)
==23085==    by 0x13A1493: sd_add_dep(_dep*, bool) (sched-deps.c:1344)
==23085==    by 0x13A1B85: add_or_update_dep_1(_dep*, bool, rtx_def*, rtx_def*)
(sched-deps.c:1286)
==23085==    by 0x13A212C: haifa_note_dep(rtx_def*, unsigned int)
(sched-deps.c:1866)
==23085==    by 0x1394CB2: add_dependence_1(rtx_def*, rtx_def*, reg_note)
(sched-deps.c:1901)
==23085==    by 0x13992C3: add_dependence(rtx_def*, rtx_def*, reg_note)
(sched-deps.c:1557)
==23085==    by 0xDE227A: ix86_dependencies_evaluation_hook(rtx_def*, rtx_def*)
(i386.c:26191)
==23085==    by 0xADC311: sched_rgn_compute_dependencies(int)
(sched-rgn.c:2746)
==23085==    by 0xB0D4E3: sel_sched_region(int) (sel-sched.c:6933)
==23085==    by 0xB0F329: run_selective_scheduling() (sel-sched.c:7798)
==23085==    by 0xADF44D: (anonymous namespace)::pass_sched::execute(function*)
(sched-rgn.c:3618)
==23085==    by 0xA484E0: execute_one_pass(opt_pass*) (passes.c:2159)
==23085==    by 0xA48785: execute_pass_list(opt_pass*) (passes.c:2212)
==23085==    by 0xA48797: execute_pass_list(opt_pass*) (passes.c:2213)
==23085==    by 0x785208: expand_function(cgraph_node*) (cgraphunit.c:1774)
==23085==    by 0x7871EB: compile() (cgraphunit.c:1908)
==23085==    by 0x787954: finalize_compilation_unit() (cgraphunit.c:2329)
==23085==    by 0x63ADA3: c_write_global_declarations() (c-decl.c:10401)
==23085==    by 0xB3BF2C: compile_file() (toplev.c:562)
==23085==    by 0xB3DEFF: toplev_main(int, char**) (toplev.c:1914)
==23085==    by 0x5A46BF4: (below main) (in /lib64/libc-2.17.so)
==23085==  Address 0x0 is not stack'd, malloc'd or (recently) free'd
==23085== 

Tested revisions:
r209530 - ICE
4.9 r209346 - ICE
4.8 r209342 - ICE
4.7 r209345 - OK

[Bug rtl-optimization/60901] [4.8/4.9/4.10 Regression] ICE: SIGSEGV in add_to_deps_list with -fsel-sched-pipelining-outer-loops

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60901

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-04-22
                 CC|                            |abel at gcc dot gnu.org,
                   |                            |amonakov at gcc dot gnu.org,
                   |                            |jakub at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Started with r192957 but perhaps that just made a latent bug no longer latent.

[Bug rtl-optimization/60901] [4.8/4.9/4.10 Regression] ICE: SIGSEGV in add_to_deps_list with -fsel-sched-pipelining-outer-loops

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60901

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.8.3

[Bug rtl-optimization/60901] [4.8/4.9/4.10 Regression] ICE: SIGSEGV in add_to_deps_list with -fsel-sched-pipelining-outer-loops

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60901

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

[Bug rtl-optimization/60901] [4.8/4.9/4.10 Regression] ICE: SIGSEGV in add_to_deps_list with -fsel-sched-pipelining-outer-loops

[abel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60901

--- Comment #2 from Andrey Belevantsev <abel at gcc dot gnu.org> ---
I'm on Easter vacation this week, will take a look after that.

[Bug rtl-optimization/60901] [4.8/4.9/4.10 Regression] ICE: SIGSEGV in add_to_deps_list with -fsel-sched-pipelining-outer-loops

[abel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60901

Andrey Belevantsev <abel at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |abel at gcc dot gnu.org

--- Comment #3 from Andrey Belevantsev <abel at gcc dot gnu.org> ---
The ix86_dependencies_evaluation_hook has the following code:

26230                 /* Assume that region is SCC, i.e. all immediate
predecessors
26231                    of non-head block are in the same region.  */
26232                 FOR_EACH_EDGE (e, ei, bb->preds)
26233                   {

The comment is wrong for selective scheduling with pipelining of outer loops
enabled, as the regions then are formed started from the innermost loops and
going up to the outer loops.  So there could be a hole in the outer loop
region.

Fixed easily below like this, the comment has also to be adjusted of course.

diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
index 895ebbb..3f572fc 100644
--- a/gcc/config/i386/i386.c
+++ b/gcc/config/i386/i386.c
@@ -26233,7 +26233,8 @@ ix86_dependencies_evaluation_hook (rtx head, rtx tail)
                  {
                    /* Avoid creating of loop-carried dependencies through
                       using topological odering in region.  */
-                   if (BLOCK_TO_BB (bb->index) > BLOCK_TO_BB (e->src->index))
+                   if (rgn == CONTAINING_RGN (e->src->index)
+                       && BLOCK_TO_BB (bb->index) > BLOCK_TO_BB
(e->src->index))
                      add_dependee_for_func_arg (first_arg, e->src);
                  }
              }

[Bug rtl-optimization/60901] [4.8/4.9/4.10 Regression] ICE: SIGSEGV in add_to_deps_list with -fsel-sched-pipelining-outer-loops

[abel at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60901

--- Comment #4 from Andrey Belevantsev <abel at gcc dot gnu.org> ---
Author: abel
Date: Wed May 14 09:46:26 2014
New Revision: 210414

URL: http://gcc.gnu.org/viewcvs?rev=210414&root=gcc&view=rev
Log:
    PR rtl-optimization/60901
    * config/i386/i386.c (ix86_dependencies_evaluation_hook): Check that
    bb predecessor belongs to the same scheduling region.  Adjust comment.

    * gcc.target/i386/pr60901.c: New test.


Added:
    trunk/gcc/testsuite/gcc.target/i386/pr60901.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/i386.c
    trunk/gcc/testsuite/ChangeLog

[Bug rtl-optimization/60901] [4.8/4.9/4.10 Regression] ICE: SIGSEGV in add_to_deps_list with -fsel-sched-pipelining-outer-loops

[abel at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60901

Andrey Belevantsev <abel at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Andrey Belevantsev <abel at gcc dot gnu.org> ---
Fixed on trunk.

[Bug rtl-optimization/60901] [4.8/4.9 Regression] ICE: SIGSEGV in add_to_deps_list with -fsel-sched-pipelining-outer-loops

[rhill at gentoo dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60901

--- Comment #6 from Ryan Hill <rhill at gentoo dot org> ---
And you're leaving 4.8/4.9 broken?

[Bug rtl-optimization/60901] [4.8/4.9 Regression] ICE: SIGSEGV in add_to_deps_list with -fsel-sched-pipelining-outer-loops

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60901

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---
   Target Milestone|4.8.3                       |4.8.4

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
Re-opening as it's still broken on branches.

[Bug rtl-optimization/60901] [4.8/4.9 Regression] ICE: SIGSEGV in add_to_deps_list with -fsel-sched-pipelining-outer-loops

[abel at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60901

--- Comment #8 from Andrey Belevantsev <abel at gcc dot gnu.org> ---
Sorry, Uros asked me to wait a bit while the patch is on trunk and at the time
the 4.8 branch got freezed, so I've postponed backporting.  I will take care of
it.

[Bug rtl-optimization/60901] [4.8/4.9 Regression] ICE: SIGSEGV in add_to_deps_list with -fsel-sched-pipelining-outer-loops

[abel at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60901

--- Comment #9 from Andrey Belevantsev <abel at gcc dot gnu.org> ---
Author: abel
Date: Tue Jun  3 09:20:36 2014
New Revision: 211164

URL: http://gcc.gnu.org/viewcvs?rev=211164&root=gcc&view=rev
Log:
    Backport from mainline

    2014-05-14  Andrey Belevantsev  <abel@ispras.ru>
        PR rtl-optimization/60901

        * config/i386/i386.c (ix86_dependencies_evaluation_hook): Check that
        bb predecessor belongs to the same scheduling region.  Adjust comment.

        * gcc.target/i386/pr60901.c: New test.


Added:
    branches/gcc-4_8-branch/gcc/testsuite/gcc.target/i386/pr60901.c
Modified:
    branches/gcc-4_8-branch/gcc/ChangeLog
    branches/gcc-4_8-branch/gcc/config/i386/i386.c
    branches/gcc-4_8-branch/gcc/testsuite/ChangeLog

[Bug rtl-optimization/60901] [4.8/4.9 Regression] ICE: SIGSEGV in add_to_deps_list with -fsel-sched-pipelining-outer-loops

[abel at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60901

--- Comment #10 from Andrey Belevantsev <abel at gcc dot gnu.org> ---
Author: abel
Date: Tue Jun  3 10:06:39 2014
New Revision: 211168

URL: http://gcc.gnu.org/viewcvs?rev=211168&root=gcc&view=rev
Log:
    Backport from mainline

    2014-05-14  Andrey Belevantsev  <abel@ispras.ru>
        PR rtl-optimization/60901

        * config/i386/i386.c (ix86_dependencies_evaluation_hook): Check that
        bb predecessor belongs to the same scheduling region.  Adjust comment.

        * gcc.target/i386/pr60901.c: New test.

Added:
    branches/gcc-4_9-branch/gcc/testsuite/gcc.target/i386/pr60901.c
Modified:
    branches/gcc-4_9-branch/gcc/ChangeLog
    branches/gcc-4_9-branch/gcc/config/i386/i386.c
    branches/gcc-4_9-branch/gcc/testsuite/ChangeLog

[Bug rtl-optimization/60901] [4.8/4.9 Regression] ICE: SIGSEGV in add_to_deps_list with -fsel-sched-pipelining-outer-loops

[abel at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60901

Andrey Belevantsev <abel at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Andrey Belevantsev <abel at gcc dot gnu.org> ---
Fixed on branches.