[Bug libfortran/61049] New: [4.9/4.10 Regression] NIST test FM906 fails

[Bug libfortran/61049] New: [4.9/4.10 Regression] NIST test FM906 fails

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61049

            Bug ID: 61049
           Summary: [4.9/4.10 Regression] NIST test FM906 fails
           Product: gcc
           Version: 4.10.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libfortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dominiq at lps dot ens.fr
                CC: jvdelisle at gcc dot gnu.org

The NIST test FM906 fails with gfortran 4.9.0 and trunk with

At line 351 of file /Users/dominiq/Documents/Fortran/NISTtest/NIST/FM906.f
(unit = 5, file = 'stdin')
Fortran runtime error: Bad repeat count in item 5 of list input

Reduced test

character(len=30) :: buff = ", (2.0, 3.0),,6.0D0, 2*,"
DOUBLE PRECISION AVD, BVD, CVD, DVCORR 
COMPLEX AVC, BVC, CVC, ZVCORR

read(buff, *)  AVD, AVC, BVC, BVD, CVC, CVD

end

Revision r208599 is OK, r208775 is not. Likely r208629.

[Bug libfortran/61049] [4.9/4.10 Regression] NIST test FM906 fails

[jvdelisle at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61049

--- Comment #1 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
Also confirmed it is r208629.  Simple fix is to revert that patch and reopen
the original bug which is related to CTRL-D on stdin, PR46800

[Bug libfortran/61049] [4.9/4.10 Regression] NIST test FM906 fails

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61049

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-05-04
     Ever confirmed|0                           |1

--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> Also confirmed it is r208629.  Simple fix is to revert that patch and reopen
> the original bug which is related to CTRL-D on stdin, PR46800

I don't think there is any need to rush to revert.

[Bug libfortran/61049] [4.9/4.10 Regression] NIST test FM906 fails

[jvdelisle at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61049

--- Comment #3 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
Created attachment 32734
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32734&action=edit
Patch pending

This patch places eat_separator back in but leaves the portion below which was
added to finish_separator. i am still testing but it fixes this regression and
the fix to PR46800 is retained.

[Bug libfortran/61049] [4.9/4.10 Regression] NIST test FM906 fails

[jvdelisle at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61049

Jerry DeLisle <jvdelisle at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |jvdelisle at gcc dot gnu.org

--- Comment #4 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
Assigning to myself.  Will ad Dominiques reduced test case to the testsuite.

[Bug libfortran/61049] [4.9/4.10 Regression] NIST test FM906 fails

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61049

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
   Target Milestone|---                         |4.9.1

[Bug libfortran/61049] [4.9/4.10 Regression] NIST test FM906 fails

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61049

--- Comment #5 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
The following patch also fixes this PR (regtested and NIST suite)

--- ../_clean/libgfortran/io/list_read.c    2014-04-27 00:39:19.000000000 +0200
+++ libgfortran/io/list_read.c    2014-05-05 09:53:52.000000000 +0200
@@ -2066,6 +2066,7 @@ list_formatted_read_scalar (st_parameter
           && dtp->u.p.current_unit->decimal_status == DECIMAL_POINT))
         {
           dtp->u.p.comma_flag = 1;
+          eat_separator (dtp);
           goto cleanup;
         }


I have no opinion about which patch is better, i.e., I don't have any test
which succeeds with one patch, but fails with the other.

[Bug libfortran/61049] [4.9/4.10 Regression] NIST test FM906 fails

[jvdelisle at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61049

--- Comment #6 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
Author: jvdelisle
Date: Wed May  7 01:31:42 2014
New Revision: 210134

URL: http://gcc.gnu.org/viewcvs?rev=210134&root=gcc&view=rev
Log:
2014-05-06  Jerry DeLisle  <jvdelisle@gcc.gnu>

    PR libfortran/61049
    * io/list_read.c (list_formatted_read_scalar): Use eat_separator
    and delete extraneous code.

Modified:
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/io/list_read.c

[Bug libfortran/61049] [4.9/4.10 Regression] NIST test FM906 fails

[jvdelisle at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61049

--- Comment #7 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
Author: jvdelisle
Date: Wed May  7 01:46:03 2014
New Revision: 210135

URL: http://gcc.gnu.org/viewcvs?rev=210135&root=gcc&view=rev
Log:
2014-05-06  Jerry DeLisle  <jvdelisle@gcc.gnu>

    PR libfortran/61049
    * gfortran.dg/list_read_13.f: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/list_read_13.f
Modified:
    trunk/gcc/testsuite/ChangeLog

[Bug libfortran/61049] [4.9/4.10 Regression] NIST test FM906 fails

[jvdelisle at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61049

--- Comment #8 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
Author: jvdelisle
Date: Sun May 11 03:47:44 2014
New Revision: 210306

URL: http://gcc.gnu.org/viewcvs?rev=210306&root=gcc&view=rev
Log:
2014-05-10  Jerry DeLisle  <jvdelisle@gcc.gnu>

    Backport from Trunk.
    PR libfortran/61049
    * io/list_read.c (list_formatted_read_scalar): Use eat_separator
    and delete extraneous code.

Modified:
    branches/gcc-4_9-branch/libgfortran/ChangeLog
    branches/gcc-4_9-branch/libgfortran/io/list_read.c

[Bug libfortran/61049] [4.9/4.10 Regression] NIST test FM906 fails

[jvdelisle at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61049

--- Comment #9 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
Author: jvdelisle
Date: Sun May 11 03:53:00 2014
New Revision: 210307

URL: http://gcc.gnu.org/viewcvs?rev=210307&root=gcc&view=rev
Log:
2014-05-10  Jerry DeLisle  <jvdelisle@gcc.gnu>

    Backport from trunk.
    PR libfortran/61049
    * gfortran.dg/list_read_13.f: New test.

Added:
    branches/gcc-4_9-branch/gcc/testsuite/gfortran.dg/list_read_13.f
Modified:
    branches/gcc-4_9-branch/gcc/testsuite/ChangeLog

[Bug libfortran/61049] [4.9/4.10 Regression] NIST test FM906 fails

[jvdelisle at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61049

Jerry DeLisle <jvdelisle at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
Fixed on 4.9 and 4.10. Closing