public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "Ulrich.Windl at rz dot uni-regensburg.de" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c/61063] New: Improve -fstack-protector-all Date: Mon, 05 May 2014 11:20:00 -0000 [thread overview] Message-ID: <bug-61063-4@http.gcc.gnu.org/bugzilla/> (raw) http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61063 Bug ID: 61063 Summary: Improve -fstack-protector-all Product: gcc Version: 4.3.4 Status: UNCONFIRMED Severity: enhancement Priority: P3 Component: c Assignee: unassigned at gcc dot gnu.org Reporter: Ulrich.Windl at rz dot uni-regensburg.de I had made a programming error that I could not find with -fstack-protector-all, but I think it should have helped: My bug was related to pthread_join() when the thread return parameter received a pointer to an integer (as the thread actually returns an integer). Unfortunately on x86_64 sizeof(int) != sizeof(void *), so my program overwrote the stack. Interestingly with -O0 things seemed to work, but with -O2 things went grazy. When the program eventually caused a SIGSEGV the stack was completely unusable (program crashed on return). AFAIK, stack-protect pads some magic bytes around on the stack that are checked before return. As it didn't help much diagnosing my problem, I'd like to suggest the following enhancements: 1) Don't add some magic bytes at one place on the stack, but add magic bytes around _every_ variable on the stack. 2) Don't just call the integrity test for the magic bytes before return, but every time a variable on the stack is modified. I know it will hit performance hard, but I wasted several hours until I found why my code broke.
next reply other threads:[~2014-05-05 11:20 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-05-05 11:20 Ulrich.Windl at rz dot uni-regensburg.de [this message] 2014-05-05 11:28 ` [Bug c/61063] " jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-61063-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).