[Bug driver/61106] [4.8/4.9/4.10 Regression] impliedness of -Wunused-parameter depends on -W option ordering

["manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61106

--- Comment #4 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Matthias Klose from comment #3)
> this leads to:
> 
>       if (!opts_set->x_warn_unused_but_set_variable)
>         handle_generated_option (opts, opts_set,
>                                  OPT_Wunused_but_set_variable, NULL, (),
>                                  lang_mask, kind, loc, handlers, dc);
> 
> and lets the compiler complain about:
> 
> options.c:11506:71: error: expected primary-expression before ')' token
>                                   OPT_Wunused_but_set_variable, NULL, (),
>                                                                        ^

I guess it was too quick and dirty ;-) 
What about this variant (just reversed the if-else condition)?

Index: optc-gen.awk
===================================================================
--- optc-gen.awk        (revision 209347)
+++ optc-gen.awk        (working copy)
@@ -404,15 +404,17 @@ for (i = 0; i < n_enabledby; i++) {
     for (j = 1; j < n_enables; j++) {
         opt_var_name = var_name(flags[opt_numbers[thisenable[j]]]);
         if (opt_var_name != "") {
             condition = "!opts_set->x_" opt_var_name
             if (thisenableif[j] != "") {
-                condition = condition " && (" thisenableif[j] ")"
+                value = "(" thisenableif[j] ")"
+            } else {
+                value = "value"
             }
             print "      if (" condition ")"
             print "        handle_generated_option (opts, opts_set,"
-            print "                                 " opt_enum(thisenable[j])
", NULL, value,"
+            print "                                 " opt_enum(thisenable[j])
", NULL, " value ","
             print "                                 lang_mask, kind, loc,
handlers, dc);"
         } else {
             print "#error " thisenable[j] " does not have a Var() flag"
         }
     }
>From gcc-bugs-return-450969-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu May 08 11:22:26 2014
Return-Path: <gcc-bugs-return-450969-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 9633 invoked by alias); 8 May 2014 11:22:25 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 9596 invoked by uid 48); 8 May 2014 11:22:21 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/13981] Give message about incomplete class that might be implicitly upcasted.
Date: Thu, 08 May 2014 11:22:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 3.4.0
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: paolo.carlini at oracle dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-13981-4-rk43WWT2Rf@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-13981-4@http.gcc.gnu.org/bugzilla/>
References: <bug-13981-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg00661.txt.bz2
Content-length: 717

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13981

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |manu at gcc dot gnu.org

--- Comment #5 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Paolo Carlini from comment #4)
> *** Bug 61089 has been marked as a duplicate of this bug. ***

I see you posted a new patch here:

http://gcc.gnu.org/ml/gcc-patches/2014-05/msg00472.html

A minor comment is whether you could use DECL_SOURCE_LOCATION to point to the
declaration of B.
>From gcc-bugs-return-450970-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu May 08 11:27:11 2014
Return-Path: <gcc-bugs-return-450970-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 12892 invoked by alias); 8 May 2014 11:27:11 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 12415 invoked by uid 48); 8 May 2014 11:27:06 -0000
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/61108] [4.8 Regression] gcc 4.8.2 generates incorrect integer arithmetic at O3 (ok at O2)
Date: Thu, 08 May 2014 11:27:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.8.2
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.8.3
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-61108-4-24AcD1nFLH@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61108-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61108-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg00662.txt.bz2
Content-length: 415

http://gcc.gnu.org/bugzilla/show_bug.cgi?ida108

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Started with r188959, fixed by r209138.