[Bug other/61106] New: [4.8/4.9/4.10 Regression] impliedness of -Wunused-parameter depends on -W option ordering

[Bug other/61106] New: [4.8/4.9/4.10 Regression] impliedness of -Wunused-parameter depends on -W option ordering

[doko at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61106

            Bug ID: 61106
           Summary: [4.8/4.9/4.10 Regression] impliedness of
                    -Wunused-parameter depends on -W option ordering
           Product: gcc
           Version: 4.8.3
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
          Assignee: unassigned at gcc dot gnu.org
          Reporter: doko at gcc dot gnu.org

[forwarded from http://bugs.debian.org/747345]

Whether various combinations of options imply -Wunused-parameter in
the presence of -Wno-unused depends on where on the command line
-Wno-unused appears:

sid$ cat tt.c
void foo(int x) { }
sid$ gcc-4.8 -g -O2 -Wall -Wno-unused -W  -c tt.c
sid$ gcc-4.8 -g -O2 -Wall -W -Wno-unused  -c tt.c
tt.c: In function 'foo':
tt.c:1:14: warning: unused parameter 'x' [-Wunused-parameter]
 void foo(int x) { }
              ^
sid$

This is confusing, to say the least.  It doesn't appear to be
discussed in the documentation, and differs from 4.7.2:

wheezy$ gcc-4.7 -g -O2 -Wall -Wno-unused -W  -c tt.c
wheezy$ gcc-4.7 -g -O2 -Wall -W -Wno-unused  -c tt.c
wheezy$

I think this new behaviour is counterintuitive and I prefer the old
behaviour.  But if the new behaviour is considered desirable, the
exact semantics should be explained.  I did some quick experiments,
but I haven't been able to come up with a coherent explanation.

Consider, for example, this, which is all what I would have expected
but appears not to be consistent with the sid transcript above:

sid$ gcc-4.8 -g -O2 -Wunused -W  -c tt.c
tt.c: In function 'foo':
tt.c:1:14: warning: unused parameter 'x' [-Wunused-parameter]
 void foo(int x) { }
              ^
sid$ gcc-4.8 -g -O2 -W -Wunused  -c tt.c
tt.c: In function 'foo':
tt.c:1:14: warning: unused parameter 'x' [-Wunused-parameter]
 void foo(int x) { }
              ^
sid$ gcc-4.8 -g -O2 -W  -c tt.c
sid$ gcc-4.8 -g -O2 -W -Wunused -Wno-unused  -c tt.c
sid$ gcc-4.8 -g -O2 -Wunused -W -Wno-unused  -c tt.c
sid$

[Bug driver/61106] [4.8/4.9/4.10 Regression] impliedness of -Wunused-parameter depends on -W option ordering

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61106

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jsm28 at gcc dot gnu.org
          Component|other                       |driver
   Target Milestone|---                         |4.8.3

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
I think it works as intended.  Maybe Joseph can clarify and point to the
relevant portion in the manual.

[Bug driver/61106] [4.8/4.9/4.10 Regression] impliedness of -Wunused-parameter depends on -W option ordering

[manu at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61106

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-05-08
                 CC|                            |manu at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #2 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
I think this is a bug and, I'm sorry to say, very likely introduced by my
patches encoding options relationships in the *.opt files.

For -Wunused-parameter, we generate this code:

      if (!opts_set->x_warn_unused_parameter && (opts->x_warn_unused &&
opts->x_extra_warnings))
        handle_generated_option (opts, opts_set,
                                 OPT_Wunused_parameter, NULL, value,
                                 lang_mask, kind, loc, handlers, dc);

which enables it only if it wasn't set already and if both -Wunused && -Wextra
are given. This is what happens after handling "-Wall -Wextra", so
-Wunused-parameter is in effect. However, when handling a subsequent
-Wno-unused, then opts->x_warn_unused becomes false before reaching here, so
the -Wno-unused-parameter is never generated.

I think this patch should do the trick:

Index: optc-gen.awk
===================================================================
--- optc-gen.awk        (revision 209347)
+++ optc-gen.awk        (working copy)
@@ -404,15 +404,17 @@ for (i = 0; i < n_enabledby; i++) {
     for (j = 1; j < n_enables; j++) {
         opt_var_name = var_name(flags[opt_numbers[thisenable[j]]]);
         if (opt_var_name != "") {
             condition = "!opts_set->x_" opt_var_name
             if (thisenableif[j] != "") {
-                condition = condition " && (" thisenableif[j] ")"
+                value = "value"
+            } else {
+                value = "(" thisenableif[j] ")"
             }
             print "      if (" condition ")"
             print "        handle_generated_option (opts, opts_set,"
-            print "                                 " opt_enum(thisenable[j])
", NULL, value,"
+            print "                                 " opt_enum(thisenable[j])
", NULL, " value ","
             print "                                 lang_mask, kind, loc,
handlers, dc);"
         } else {
             print "#error " thisenable[j] " does not have a Var() flag"
         }
     }

but I haven't tested it. 

On the other hand, a behavior that may have changed is that:

"-Wall -Wextra -Wno-unused -Wall" should not generate the warning. I'm not sure
this was the case before GCC 4.8, but this is the desired behavior (options can
only affect other options when the latter are not set explicitly, that is,
-Wno-unused -Wall does not re-enable -Wunused. We should write these in the
manual.)
>From gcc-bugs-return-450964-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu May 08 08:44:32 2014
Return-Path: <gcc-bugs-return-450964-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 29840 invoked by alias); 8 May 2014 08:44:32 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 29796 invoked by uid 48); 8 May 2014 08:44:27 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/61081] excessive warnings: right-hand operand of comma expression has no effect
Date: Thu, 08 May 2014 08:44:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-61081-4-hQ9gUwrk8C@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61081-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61081-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg00656.txt.bz2
Content-length: 891

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61081

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |manu at gcc dot gnu.org

--- Comment #5 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Apple should mark their system headers as such using:

#pragma GCC system_header

Other compilers will ignore this pragma.

You could do that simply by adding a dummy header that includes the real
header. Or you can just disable the warning in your code with #pragma GCC
diagnostic ignore "Wwhatever".

We could also not warn if the right-hand operand comes from the macro
definition, but I am not sure how difficult is to do that and whether it is
really worth the effort.
>From gcc-bugs-return-450965-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu May 08 08:47:34 2014
Return-Path: <gcc-bugs-return-450965-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 31688 invoked by alias); 8 May 2014 08:47:33 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 31657 invoked by uid 48); 8 May 2014 08:47:30 -0000
From: "jgreenhalgh at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/61078] [4.10 Regression] ESA mode bootstrap failure since r209897
Date: Thu, 08 May 2014 08:47:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: bootstrap
X-Bugzilla-Version: 4.10.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jgreenhalgh at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.10.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61078-4-Xmst5pZBvS@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61078-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61078-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg00657.txt.bz2
Content-length: 504

http://gcc.gnu.org/bugzilla/show_bug.cgi?ida078

--- Comment #1 from jgreenhalgh at gcc dot gnu.org ---
I'm happy to take a look at this, but I have no access to an s390 ESA mode
environment, so will struggle to make much progress.

If it is the case that s390 relies on PUSH_ARGS_REVERSED == 0, then r209897
will need to be reverted as it is clearly erroneous.

Otherwise, any reduced testcase you can find where we do the wrong thing
preparing stack arguments will be of great help hunting the bug.

[Bug driver/61106] [4.8/4.9/4.10 Regression] impliedness of -Wunused-parameter depends on -W option ordering

[doko at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61106

--- Comment #3 from Matthias Klose <doko at gcc dot gnu.org> ---
this leads to:

      if (!opts_set->x_warn_unused_but_set_variable)
        handle_generated_option (opts, opts_set,
                                 OPT_Wunused_but_set_variable, NULL, (),
                                 lang_mask, kind, loc, handlers, dc);

and lets the compiler complain about:

options.c:11506:71: error: expected primary-expression before ')' token
                                  OPT_Wunused_but_set_variable, NULL, (),
                                                                       ^

[Bug driver/61106] [4.8/4.9/4.10 Regression] impliedness of -Wunused-parameter depends on -W option ordering

[manu at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61106

--- Comment #4 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Matthias Klose from comment #3)
> this leads to:
> 
>       if (!opts_set->x_warn_unused_but_set_variable)
>         handle_generated_option (opts, opts_set,
>                                  OPT_Wunused_but_set_variable, NULL, (),
>                                  lang_mask, kind, loc, handlers, dc);
> 
> and lets the compiler complain about:
> 
> options.c:11506:71: error: expected primary-expression before ')' token
>                                   OPT_Wunused_but_set_variable, NULL, (),
>                                                                        ^

I guess it was too quick and dirty ;-) 
What about this variant (just reversed the if-else condition)?

Index: optc-gen.awk
===================================================================
--- optc-gen.awk        (revision 209347)
+++ optc-gen.awk        (working copy)
@@ -404,15 +404,17 @@ for (i = 0; i < n_enabledby; i++) {
     for (j = 1; j < n_enables; j++) {
         opt_var_name = var_name(flags[opt_numbers[thisenable[j]]]);
         if (opt_var_name != "") {
             condition = "!opts_set->x_" opt_var_name
             if (thisenableif[j] != "") {
-                condition = condition " && (" thisenableif[j] ")"
+                value = "(" thisenableif[j] ")"
+            } else {
+                value = "value"
             }
             print "      if (" condition ")"
             print "        handle_generated_option (opts, opts_set,"
-            print "                                 " opt_enum(thisenable[j])
", NULL, value,"
+            print "                                 " opt_enum(thisenable[j])
", NULL, " value ","
             print "                                 lang_mask, kind, loc,
handlers, dc);"
         } else {
             print "#error " thisenable[j] " does not have a Var() flag"
         }
     }
>From gcc-bugs-return-450969-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu May 08 11:22:26 2014
Return-Path: <gcc-bugs-return-450969-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 9633 invoked by alias); 8 May 2014 11:22:25 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 9596 invoked by uid 48); 8 May 2014 11:22:21 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/13981] Give message about incomplete class that might be implicitly upcasted.
Date: Thu, 08 May 2014 11:22:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 3.4.0
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: paolo.carlini at oracle dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-13981-4-rk43WWT2Rf@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-13981-4@http.gcc.gnu.org/bugzilla/>
References: <bug-13981-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg00661.txt.bz2
Content-length: 717

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13981

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |manu at gcc dot gnu.org

--- Comment #5 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Paolo Carlini from comment #4)
> *** Bug 61089 has been marked as a duplicate of this bug. ***

I see you posted a new patch here:

http://gcc.gnu.org/ml/gcc-patches/2014-05/msg00472.html

A minor comment is whether you could use DECL_SOURCE_LOCATION to point to the
declaration of B.
>From gcc-bugs-return-450970-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu May 08 11:27:11 2014
Return-Path: <gcc-bugs-return-450970-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 12892 invoked by alias); 8 May 2014 11:27:11 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 12415 invoked by uid 48); 8 May 2014 11:27:06 -0000
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/61108] [4.8 Regression] gcc 4.8.2 generates incorrect integer arithmetic at O3 (ok at O2)
Date: Thu, 08 May 2014 11:27:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.8.2
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.8.3
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-61108-4-24AcD1nFLH@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61108-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61108-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg00662.txt.bz2
Content-length: 415

http://gcc.gnu.org/bugzilla/show_bug.cgi?ida108

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Started with r188959, fixed by r209138.

[Bug driver/61106] [4.8/4.9/4.10 Regression] impliedness of -Wunused-parameter depends on -W option ordering

[doko at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61106

--- Comment #5 from Matthias Klose <doko at gcc dot gnu.org> ---
this works and fixes the issue. running the full testsuite now.

[Bug driver/61106] [4.8/4.9/4.10 Regression] impliedness of -Wunused-parameter depends on -W option ordering

[manu at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61106

--- Comment #6 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Matthias Klose from comment #5)
> this works and fixes the issue. running the full testsuite now.

It would be nice to add this testcase ("-Wall -Wextra -Wno-unused" should not
give -Wunused-parameter warning). Perhaps if you grep for "unused parameter" in
the testsuite output, you can find a testcase testing something similar already
and add it there.

(It would be great if it was possible to say:
/* { dg-options "-Wall -Wno-unused -Wextra" } */
/* { dg-options "-Wall -Wextra -Wno-unused" } */

and the testsuite would compile one time for each value of dg-options. Is this
possible?)
>From gcc-bugs-return-450979-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu May 08 12:57:32 2014
Return-Path: <gcc-bugs-return-450979-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 30818 invoked by alias); 8 May 2014 12:57:32 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 30787 invoked by uid 48); 8 May 2014 12:57:29 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug driver/61106] [4.8/4.9/4.10 Regression] impliedness of -Wunused-parameter depends on -W option ordering
Date: Thu, 08 May 2014 12:57:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: driver
X-Bugzilla-Version: 4.8.3
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.8.3
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61106-4-qFQaeXTOcE@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61106-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61106-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg00671.txt.bz2
Content-length: 326

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61106

--- Comment #7 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Please take the patch as yours. I don't have time at the moment to do all the
submission+pinging. (And perhaps it could be backported to GCC 4.9 and 4.8. It
is really a regression.)
>From gcc-bugs-return-450980-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu May 08 13:13:54 2014
Return-Path: <gcc-bugs-return-450980-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 8515 invoked by alias); 8 May 2014 13:13:52 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 8462 invoked by uid 48); 8 May 2014 13:13:42 -0000
From: "paul at scruby dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/59472] Many warnings "type of 'X' does not match original declaration" when linking with libstdc++ static library compiled with -flto
Date: Thu, 08 May 2014 13:13:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords: diagnostic, lto
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: paul at scruby dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-59472-4-O1ZcrnpD5Y@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59472-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59472-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg00672.txt.bz2
Content-length: 600

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY472

Paul Scruby <paul at scruby dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul at scruby dot com

--- Comment #2 from Paul Scruby <paul at scruby dot com> ---
I have the same issue with my build of gcc4.8.2

I built libstdc++-v3 with '-flto -O3'.  Now when my makefiles link to libstdc++
statically eg '-static-libstdc++ -flto -O3 -fuse-linker-plugin', I see these
warnings too.

Thanks,

Paul

[Bug driver/61106] [4.8/4.9/4.10 Regression] impliedness of -Wunused-parameter depends on -W option ordering

[doko at gcc dot gnu.org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 7189 bytes --]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61106

--- Comment #8 from Matthias Klose <doko at gcc dot gnu.org> ---
Author: doko
Date: Thu May  8 22:17:43 2014
New Revision: 210246

URL: http://gcc.gnu.org/viewcvs?rev=210246&root=gcc&view=rev
Log:
gcc/

2014-05-08  Manuel López-Ibáñez  <manu@gcc.gnu.org>
            Matthias Klose  <doko@ubuntu.com>

        PR driver/61106
        * optc-gen.awk: Fix option handling for -Wunused-parameter.

gcc/testsuite/

2014-05-08  Matthias Klose  <doko@ubuntu.com>

        PR driver/61106
        * gcc-dg/unused-8a.c: New.
        * gcc-dg/unused-8b.c: Likewise.

Added:
    trunk/gcc/testsuite/gcc.dg/unused-8a.c
    trunk/gcc/testsuite/gcc.dg/unused-8b.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/optc-gen.awk
    trunk/gcc/testsuite/ChangeLog
>From gcc-bugs-return-451059-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu May 08 22:31:07 2014
Return-Path: <gcc-bugs-return-451059-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 3524 invoked by alias); 8 May 2014 22:31:07 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 3461 invoked by uid 55); 8 May 2014 22:31:04 -0000
From: "doko at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug driver/61106] [4.8/4.9/4.10 Regression] impliedness of -Wunused-parameter depends on -W option ordering
Date: Thu, 08 May 2014 22:31:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: driver
X-Bugzilla-Version: 4.8.3
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: doko at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.8.3
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61106-4-npN5HcaEjz@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61106-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61106-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg00751.txt.bz2
Content-length: 910

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61106

--- Comment #9 from Matthias Klose <doko at gcc dot gnu.org> ---
Author: doko
Date: Thu May  8 22:30:32 2014
New Revision: 210247

URL: http://gcc.gnu.org/viewcvs?rev=210247&root=gcc&view=rev
Log:
gcc/

2014-05-08  Manuel López-Ibáñez  <manu@gcc.gnu.org>
            Matthias Klose  <doko@ubuntu.com>

        PR driver/61106
        * optc-gen.awk: Fix option handling for -Wunused-parameter.

gcc/testsuite/

2014-05-08  Matthias Klose  <doko@ubuntu.com>

        PR driver/61106
        * gcc-dg/unused-8a.c: New.
        * gcc-dg/unused-8b.c: Likewise.

Added:
    branches/gcc-4_9-branch/gcc/testsuite/gcc.dg/unused-8a.c
    branches/gcc-4_9-branch/gcc/testsuite/gcc.dg/unused-8b.c
Modified:
    branches/gcc-4_9-branch/gcc/ChangeLog
    branches/gcc-4_9-branch/gcc/optc-gen.awk
    branches/gcc-4_9-branch/gcc/testsuite/ChangeLog
>From gcc-bugs-return-451060-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu May 08 22:45:48 2014
Return-Path: <gcc-bugs-return-451060-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 21738 invoked by alias); 8 May 2014 22:45:47 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 21699 invoked by uid 48); 8 May 2014 22:45:43 -0000
From: "rhaas at caltech dot edu" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/61119] New: gcc miscompiles code using cexp when using --fast-math
Date: Thu, 08 May 2014 22:45:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 4.8.2
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rhaas at caltech dot edu
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter attachments.created
Message-ID: <bug-61119-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg00752.txt.bz2
Content-length: 1799

http://gcc.gnu.org/bugzilla/show_bug.cgi?ida119

            Bug ID: 61119
           Summary: gcc miscompiles code using cexp when using --fast-math
           Product: gcc
           Version: 4.8.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: rhaas at caltech dot edu

Created attachment 32764
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id2764&actioníit
sample code demonstrating effect

The attached short C99 code shows strange behaviour when compiled with
gcc 4.8.2, 4.4.7 . The expected output is

call: 1
2.71828

however I get

call: 1
call: 2
2.71828

ie the sentinel function is called twice. I have compiled with just -E
to check if possibly cexp is implemented as a macro, which does not
seem to be the case. I have inspected the assembly code generated (see
comments at the top of the file) and -Ofast produces some strange code
on top of the code that is produced without -Ofast.

If I use cexp(fun()*I) then fun is even called 4 times instead of just
twice. This showed up when instead of "fun()" I had used "i++" which
incremented "i" more often than expected.

Compile instructions are in the file itself, basically:

gcc -lm -Wall -O0 -ffast-math sincos.c
./a.out

A colleague of mine had a look at the assembler code and reported:
--8<--
The generated assembler code contains this sequence:
    call    _fun
    cvtsi2sd    %eax, %xmm3
    movd    %xmm3, %rax
    movd    %rax, %xmm0
    call    _exp
    movd    %xmm0, %rbx
    call    _fun
    movabsq    $4607182418800017408, %rax

That is:
- call fun
- convert int to double
- call (real) exp (a legitimate optimization)
- call fun again (?)
- overwrite the return value (???)
--8<--

[Bug driver/61106] [4.8/4.9/4.10 Regression] impliedness of -Wunused-parameter depends on -W option ordering

[doko at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61106

--- Comment #10 from Matthias Klose <doko at gcc dot gnu.org> ---
Author: doko
Date: Thu May  8 22:57:55 2014
New Revision: 210248

URL: http://gcc.gnu.org/viewcvs?rev=210248&root=gcc&view=rev
Log:
gcc/

2014-05-08  Manuel López-Ibáñez  <manu@gcc.gnu.org>
            Matthias Klose  <doko@ubuntu.com>

        PR driver/61106
        * optc-gen.awk: Fix option handling for -Wunused-parameter.

gcc/testsuite/

2014-05-08  Matthias Klose  <doko@ubuntu.com>

        PR driver/61106
        * gcc-dg/unused-8a.c: New.
        * gcc-dg/unused-8b.c: Likewise.

Added:
    branches/gcc-4_8-branch/gcc/testsuite/gcc.dg/unused-8a.c
    branches/gcc-4_8-branch/gcc/testsuite/gcc.dg/unused-8b.c
Modified:
    branches/gcc-4_8-branch/gcc/ChangeLog
    branches/gcc-4_8-branch/gcc/optc-gen.awk
    branches/gcc-4_8-branch/gcc/testsuite/ChangeLog
>From gcc-bugs-return-451062-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu May 08 22:58:15 2014
Return-Path: <gcc-bugs-return-451062-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 838 invoked by alias); 8 May 2014 22:58:15 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 815 invoked by uid 48); 8 May 2014 22:58:12 -0000
From: "glisse at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/61119] gcc miscompiles code using cexp when using --fast-math
Date: Thu, 08 May 2014 22:58:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: 4.8.2
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: glisse at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status cf_reconfirmed_on everconfirmed cf_known_to_fail
Message-ID: <bug-61119-4-gNl5V01WNf@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61119-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61119-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg00754.txt.bz2
Content-length: 560

http://gcc.gnu.org/bugzilla/show_bug.cgi?ida119

Marc Glisse <glisse at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-05-08
     Ever confirmed|0                           |1
      Known to fail|                            |4.10.0

--- Comment #2 from Marc Glisse <glisse at gcc dot gnu.org> ---
fold_builtin_cexp not calling save_expr?

[Bug driver/61106] [4.8/4.9/4.10 Regression] impliedness of -Wunused-parameter depends on -W option ordering

[doko at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61106

Matthias Klose <doko at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Matthias Klose <doko at gcc dot gnu.org> ---
fixed

[Bug driver/61106] [4.8/4.9/4.10 Regression] impliedness of -Wunused-parameter depends on -W option ordering

[schwab@linux-m68k.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61106

--- Comment #12 from Andreas Schwab <schwab@linux-m68k.org> ---
FAIL: gfortran.dg/wextra_1.f  -O   (test for warnings, line 4)

[Bug driver/61106] [4.8/4.9/4.10 Regression] impliedness of -Wunused-parameter depends on -W option ordering

[manu at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61106

--- Comment #13 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Andreas Schwab from comment #12)
> FAIL: gfortran.dg/wextra_1.f  -O   (test for warnings, line 4)

PR61126
>From gcc-bugs-return-451187-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri May 09 22:15:42 2014
Return-Path: <gcc-bugs-return-451187-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 16527 invoked by alias); 9 May 2014 22:15:39 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 16255 invoked by uid 48); 9 May 2014 22:15:33 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/61126] gfortran does not enable -Wununused-parameter with -Wextra
Date: Fri, 09 May 2014 22:15:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 4.10.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-61126-4-UDqKham5XJ@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61126-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61126-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg00879.txt.bz2
Content-length: 1884

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61126

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jsm28 at gcc dot gnu.org

--- Comment #12 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Manuel López-Ibáñez from comment #10)
> If you want to have the same behavior in Fortran as in the rest of GCC, then
> delete the above. The above was enabling -Wunused-parameter just with
> -Wextra (only in Fortran), and because of the existing bug fixed by r210246,
> this was never overriden by the general machinery.

On the other hand, if you want to have a different behavior, then in the ideal
case this should work:


Index: lang.opt
===================================================================
--- lang.opt    (revision 210292)
+++ lang.opt    (working copy)
@@ -299,10 +299,14 @@ Warn if a user-procedure has the same na

 Wunused-dummy-argument
 Fortran Warning
 Warn about unused dummy arguments.

+Wunused-parameter
+LangEnabledBy(Fortran,Wextra)
+; Documented in common.opt
+
 Wzerotrip
 Fortran Warning
 Warn about zero-trip DO loops

 cpp


Unfortunately, the handlers for the options are set up such that the language
specific handlers are executed before the common_handler (which is executed
before the target-specific handler). 

Joseph, why is that so? I think it makes sense that the FEs can override the
common settings, like the targets can.

The alternative is to duplicate the option in every FE and remove it from
common.opt. That seems quite ugly to me.
>From gcc-bugs-return-451188-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri May 09 22:18:51 2014
Return-Path: <gcc-bugs-return-451188-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 31425 invoked by alias); 9 May 2014 22:18:50 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 31062 invoked by uid 48); 9 May 2014 22:18:45 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/61126] gfortran does not enable -Wununused-parameter with -Wextra
Date: Fri, 09 May 2014 22:18:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 4.10.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61126-4-VSnPb9vQ3S@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61126-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61126-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg00880.txt.bz2
Content-length: 1962

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61126

--- Comment #13 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
This builds gfortran and fixes the testcase, but I haven't tested it beyond
that.


Index: lang.opt
===================================================================
--- lang.opt    (revision 210292)
+++ lang.opt    (working copy)
@@ -299,10 +299,14 @@ Warn if a user-procedure has the same na

 Wunused-dummy-argument
 Fortran Warning
 Warn about unused dummy arguments.

+Wunused-parameter
+LangEnabledBy(Fortran,Wextra)
+; Documented in common.opt
+
 Wzerotrip
 Fortran Warning
 Warn about zero-trip DO loops

 cpp
Index: opts-global.c
===================================================================
--- opts-global.c       (revision 210292)
+++ opts-global.c       (working copy)
@@ -271,14 +271,14 @@ void
 set_default_handlers (struct cl_option_handlers *handlers)
 {
   handlers->unknown_option_callback = unknown_option_callback;
   handlers->wrong_lang_callback = complain_wrong_lang;
   handlers->num_handlers = 3;
-  handlers->handlers[0].handler = lang_handle_option;
-  handlers->handlers[0].mask = initial_lang_mask;
-  handlers->handlers[1].handler = common_handle_option;
-  handlers->handlers[1].mask = CL_COMMON;
+  handlers->handlers[0].handler = common_handle_option;
+  handlers->handlers[0].mask = CL_COMMON;
+  handlers->handlers[1].handler = lang_handle_option;
+  handlers->handlers[1].mask = initial_lang_mask;
   handlers->handlers[2].handler = target_handle_option;
   handlers->handlers[2].mask = CL_TARGET;
 }

 /* Parse command line options and set default flag values.  Do minimal
>From gcc-bugs-return-451189-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri May 09 22:19:30 2014
Return-Path: <gcc-bugs-return-451189-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 2076 invoked by alias); 9 May 2014 22:19:30 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 1773 invoked by uid 48); 9 May 2014 22:19:26 -0000
From: "ppluzhnikov at google dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/61134] New: [4.7/4.8/4.9/4.10 Regression][C++11] bogus "no matching function for call..."
Date: Fri, 09 May 2014 22:19:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ppluzhnikov at google dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-61134-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg00881.txt.bz2
Content-length: 2029

http://gcc.gnu.org/bugzilla/show_bug.cgi?ida134

            Bug ID: 61134
           Summary: [4.7/4.8/4.9/4.10 Regression][C++11] bogus "no
                    matching function for call..."
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ppluzhnikov at google dot com

Google ref: b/14657431

The test case compiles with Clang and gcc-4.6, fails with -DBUG on all later
versions including current trunk (r210292):

g++ -c -std=gnu++11 t.cc && echo OK && g++ -c -std=gnu++11 t.cc -DBUG
OK
t.cc: In function 'void Fn()':
t.cc:22:55: error: no matching function for call to 'CreateMetric(const char
[5], const char [4], Base)'
   CreateMetric<int, const char*>("abcd", "def", Base());
                                                       ^
t.cc:22:55: note: candidate is:
t.cc:15:6: note: template<class VT, class ... Fields> void CreateMetric(const
char*, typename Fixed<Fields>::name ..., const Base&)
 void CreateMetric(const char* name,
      ^
t.cc:15:6: note:   template argument deduction/substitution failed:
t.cc:22:55: note:   cannot convert '"def"' (type 'const char [4]') to type
'const Base&'
   CreateMetric<int, const char*>("abcd", "def", Base());
                                                       ^

// --- cut ---
struct Base { };

template <typename>
struct Fixed {
  typedef const char* name;
};

#if BUG
template <typename VT, typename... Fields>
void New(const char* name,
         typename Fixed<Fields>::name... field_names);
#endif

template <typename VT, typename... Fields>
void CreateMetric(const char* name,
                  typename Fixed<Fields>::name... field_names,
                  const Base&) { }


void Fn()
{
  CreateMetric<int, const char*>("abcd", "def", Base());
}
// --- cut ---


Note: The 'New()' function is not referenced outside the #ifdef block.
      It's mere presense triggers the bug.

[Bug driver/61106] [4.8/4.9/4.10 Regression] impliedness of -Wunused-parameter depends on -W option ordering

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61106

--- Comment #14 from Matthias Klose <doko at gcc dot gnu.org> ---
Author: doko
Date: Wed May 14 16:18:12 2014
New Revision: 210432

URL: http://gcc.gnu.org/viewcvs?rev=210432&root=gcc&view=rev
Log:
gcc/

2014-05-14  Matthias Klose  <doko@ubuntu.com>

    Revert:
    2014-05-08  Manuel López-Ibáñez  <manu@gcc.gnu.org>
            Matthias Klose  <doko@ubuntu.com>

    PR driver/61106
    * optc-gen.awk: Fix option handling for -Wunused-parameter.

gcc/testsuite/

2014-05-14  Matthias Klose  <doko@ubuntu.com>

    PR driver/61106
    * gcc-dg/unused-8a.c: Remove.

Removed:
    branches/gcc-4_8-branch/gcc/testsuite/gcc.dg/unused-8a.c
Modified:
    branches/gcc-4_8-branch/gcc/ChangeLog
    branches/gcc-4_8-branch/gcc/optc-gen.awk
    branches/gcc-4_8-branch/gcc/testsuite/ChangeLog
>From gcc-bugs-return-451624-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed May 14 16:22:55 2014
Return-Path: <gcc-bugs-return-451624-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 17123 invoked by alias); 14 May 2014 16:22:55 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 17075 invoked by uid 55); 14 May 2014 16:22:52 -0000
From: "doko at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug driver/61106] [4.8/4.9/4.10 Regression] impliedness of -Wunused-parameter depends on -W option ordering
Date: Wed, 14 May 2014 16:22:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: driver
X-Bugzilla-Version: 4.8.3
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: doko at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.8.3
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61106-4-4xto1Vrjve@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61106-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61106-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg01316.txt.bz2
Content-length: 895

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61106

--- Comment #15 from Matthias Klose <doko at gcc dot gnu.org> ---
Author: doko
Date: Wed May 14 16:22:20 2014
New Revision: 210434

URL: http://gcc.gnu.org/viewcvs?rev=210434&root=gcc&view=rev
Log:
gcc/

2014-05-14  Matthias Klose  <doko@ubuntu.com>

        Revert:
        2014-05-08  Manuel López-Ibáñez  <manu@gcc.gnu.org>
                    Matthias Klose  <doko@ubuntu.com>

        PR driver/61106
        * optc-gen.awk: Fix option handling for -Wunused-parameter.

gcc/testsuite/

2014-05-14  Matthias Klose  <doko@ubuntu.com>

        PR driver/61106
        * gcc-dg/unused-8a.c: Remove.

Removed:
    branches/gcc-4_9-branch/gcc/testsuite/gcc.dg/unused-8a.c
Modified:
    branches/gcc-4_9-branch/gcc/ChangeLog
    branches/gcc-4_9-branch/gcc/optc-gen.awk
    branches/gcc-4_9-branch/gcc/testsuite/ChangeLog
>From gcc-bugs-return-451625-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed May 14 16:25:31 2014
Return-Path: <gcc-bugs-return-451625-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 20229 invoked by alias); 14 May 2014 16:25:30 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 20174 invoked by uid 48); 14 May 2014 16:25:27 -0000
From: "doko at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug driver/61106] [4.8/4.9/4.10 Regression] impliedness of -Wunused-parameter depends on -W option ordering
Date: Wed, 14 May 2014 16:25:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: driver
X-Bugzilla-Version: 4.8.3
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: doko at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.8.3
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution
Message-ID: <bug-61106-4-3dywUIrVPO@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61106-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61106-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg01317.txt.bz2
Content-length: 516

https://gcc.gnu.org/bugzilla/show_bug.cgi?ida106

Matthias Klose <doko at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |NEW
         Resolution|FIXED                       |---

--- Comment #16 from Matthias Klose <doko at gcc dot gnu.org> ---
reverted the change for the branches and removed the unused-8a.c testcase as
requested by richi and jakub.

[Bug driver/61106] [4.8/4.9/4.10 Regression] impliedness of -Wunused-parameter depends on -W option ordering

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61106

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.8.3                       |4.8.4

--- Comment #17 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 4.8.3 is being released, adjusting target milestone.

[Bug driver/61106] [4.8/4.9/4.10 Regression] impliedness of -Wunused-parameter depends on -W option ordering

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61106
Bug 61106 depends on bug 61126, which changed state.

Bug 61126 Summary: [4.10 Regression] gfortran does not enable -Wununused-parameter with -Wextra
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61126

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

[Bug driver/61106] [4.8/4.9/4.10 Regression] impliedness of -Wunused-parameter depends on -W option ordering

[manu at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61106

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org,
                   |                            |rguenth at gcc dot gnu.org

--- Comment #18 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Richard, Jakub,

Now that the fortran issued was fixed, can Matthias commit the patch again? in
all branches?

I think this issue may affect other options, not just -Wunused-parameter.
>From gcc-bugs-return-454466-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Jun 18 09:45:13 2014
Return-Path: <gcc-bugs-return-454466-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 17747 invoked by alias); 18 Jun 2014 09:45:12 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 17482 invoked by uid 48); 18 Jun 2014 09:45:08 -0000
From: "ramana at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/61536] [4.10 regression] g++ and libstdc++ regressions on arm-none-linux-gnueabihf with missing typeinfo
Date: Wed, 18 Jun 2014 09:45:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 4.10.0
X-Bugzilla-Keywords: link-failure
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ramana at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: paolo.carlini at oracle dot com
X-Bugzilla-Target-Milestone: 4.10.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution
Message-ID: <bug-61536-4-mYiYP3zaYK@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61536-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61536-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-06/txt/msg01548.txt.bz2
Content-length: 443

https://gcc.gnu.org/bugzilla/show_bug.cgi?ida536

Ramana Radhakrishnan <ramana at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #15 from Ramana Radhakrishnan <ramana at gcc dot gnu.org> ---
Fixed now.

[Bug driver/61106] [4.8/4.9/4.10 Regression] impliedness of -Wunused-parameter depends on -W option ordering

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61106

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

[Bug driver/61106] [4.8/4.9] impliedness of -Wunused-parameter depends on -W option ordering

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61106

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.8.4                       |4.8.5

--- Comment #23 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.8.4 has been released.

[Bug driver/61106] [4.8/4.9] impliedness of -Wunused-parameter depends on -W option ordering

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61106

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.8.5                       |4.9.3

--- Comment #24 from Richard Biener <rguenth at gcc dot gnu.org> ---
The gcc-4_8-branch is being closed, re-targeting regressions to 4.9.3.

[Bug driver/61106] [4.8/4.9] impliedness of -Wunused-parameter depends on -W option ordering

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61106

--- Comment #25 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.3 has been released.

[Bug driver/61106] [4.8/4.9] impliedness of -Wunused-parameter depends on -W option ordering

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61106

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.3                       |4.9.4