From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17733 invoked by alias); 10 Feb 2015 02:24:29 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Received: (qmail 17579 invoked by uid 55); 10 Feb 2015 02:24:23 -0000 From: "collison at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/61114] Scalar evolution hides a big-endian const-folding bug. Date: Tue, 10 Feb 2015 02:24:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: tree-optimization X-Bugzilla-Version: 4.9.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: collison at gcc dot gnu.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 5.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2015-02/txt/msg00905.txt.bz2 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61114 --- Comment #12 from collison at gcc dot gnu.org --- Author: collison Date: Tue Feb 10 02:23:40 2015 New Revision: 220562 URL: https://gcc.gnu.org/viewcvs?rev=220562&root=gcc&view=rev Log: 2015-02-09 Michael Collison Backport from trunk r216779. 2014-10-28 Alan Lawrence * expr.c (expand_expr_real_2): Remove code handling VEC_LSHIFT_EXPR. * fold-const.c (const_binop): Likewise. * cfgexpand.c (expand_debug_expr): Likewise. * tree-inline.c (estimate_operator_cost): Likewise. * tree-vect-generic.c (expand_vector_operations_1): Likewise. * optabs.c (optab_for_tree_code): Likewise. (expand_vec_shift_expr): Likewise, update comment. * tree.def: Delete VEC_LSHIFT_EXPR, remove comment. * optabs.h (expand_vec_shift_expr): Remove comment re. VEC_LSHIFT_EXPR. * optabs.def: Remove vec_shl_optab. * doc/md.texi: Remove references to vec_shr_m. 2015-02-09 Michael Collison Backport from trunk r216742. 2014-10-27 Alan Lawrence * config/aarch64/aarch64.c (TARGET_GIMPLE_FOLD_BUILTIN): Define again. * config/aarch64/aarch64-builtins.c (aarch64_gimple_fold_builtin): Restore, enable for bigendian, update to use __builtin..._scal... 2015-02-09 Michael Collison Backport from trunk r216741. 2014-10-27 Alan Lawrence * config/aarch64/aarch64-simd-builtins.def (reduc_smax_, reduc_smin_, reduc_umax_, reduc_umin_, reduc_smax_nan_, reduc_smin_nan_): Remove. (reduc_smax_scal_, reduc_smin_scal_, reduc_umax_scal_, reduc_umin_scal_, reduc_smax_nan_scal_, reduc_smin_nan_scal_): New. * config/aarch64/aarch64-simd.md (reduc__): Rename VDQV_S variant to... (reduc__internal): ...this. (reduc__): New (VDQ_BHSI). (reduc__scal_): New (*2). (reduc__v2si): Combine with below, renaming... (reduc__): Combine V2F with above, renaming... (reduc__internal_): ...to this (VDQF). * config/aarch64/arm_neon.h (vmaxv_f32, vmaxv_s8, vmaxv_s16, vmaxv_s32, vmaxv_u8, vmaxv_u16, vmaxv_u32, vmaxvq_f32, vmaxvq_f64, vmaxvq_s8, vmaxvq_s16, vmaxvq_s32, vmaxvq_u8, vmaxvq_u16, vmaxvq_u32, vmaxnmv_f32, vmaxnmvq_f32, vmaxnmvq_f64, vminv_f32, vminv_s8, vminv_s16, vminv_s32, vminv_u8, vminv_u16, vminv_u32, vminvq_f32, vminvq_f64, vminvq_s8, vminvq_s16, vminvq_s32, vminvq_u8, vminvq_u16, vminvq_u32, vminnmv_f32, vminnmvq_f32, vminnmvq_f64): Update to use __builtin_aarch64_reduc_..._scal; remove vget_lane wrapper. 2015-02-09 Michael Collison Backport from trunk r216738. 2014-10-27 Alan Lawrence * config/aarch64/aarch64-simd-builtins.def (reduc_splus_/VDQF, reduc_uplus_/VDQF, reduc_splus_v4sf): Remove. (reduc_plus_scal_, reduc_plus_scal_v4sf): New. * config/aarch64/aarch64-simd.md (reduc_plus_mode): Remove. (reduc_splus_, reduc_uplus_, reduc_plus_scal_): New. (reduc_plus_mode): Change SUADDV -> UNSPEC_ADDV, rename to... (aarch64_reduc_plus_internal): ...this. (reduc_plus_v2si): Change SUADDV -> UNSPEC_ADDV, rename to... (aarch64_reduc_plus_internalv2si): ...this. (reduc_splus_/V2F): Rename to... (aarch64_reduc_plus_internal): ...this. * config/aarch64/iterators.md (UNSPEC_SADDV, UNSPEC_UADDV, SUADDV): Remove. (UNSPEC_ADDV): New. (sur): Remove elements for UNSPEC_SADDV and UNSPEC_UADDV. * config/aarch64/arm_neon.h (vaddv_s8, vaddv_s16, vaddv_s32, vaddv_u8, vaddv_u16, vaddv_u32, vaddvq_s8, vaddvq_s16, vaddvq_s32, vaddvq_s64, vaddvq_u8, vaddvq_u16, vaddvq_u32, vaddvq_u64, vaddv_f32, vaddvq_f32, vaddvq_f64): Change __builtin_aarch64_reduc_[us]plus_... to __builtin_aarch64_reduc_plus_scal, remove vget_lane wrapper. 2015-02-09 Michael Collison Backport from trunk r216737. 2014-10-27 Alan Lawrence PR tree-optimization/61114 * doc/md.texi (Standard Names): Add reduc_(plus,[us](min|max))|scal optabs, and note in reduc_[us](plus|min|max) to prefer the former. * expr.c (expand_expr_real_2): Use reduc_..._scal if available, fall back to old reduc_... BIT_FIELD_REF only if not. * optabs.c (optab_for_tree_code): for REDUC_(MAX,MIN,PLUS)_EXPR, return the reduce-to-scalar (reduc_..._scal) optab. (scalar_reduc_to_vector): New. * optabs.def (reduc_smax_scal_optab, reduc_smin_scal_optab, reduc_plus_scal_optab, reduc_umax_scal_optab, reduc_umin_scal_optab): New. * optabs.h (scalar_reduc_to_vector): Declare. * tree-vect-loop.c (vectorizable_reduction): Look for optabs reducing to either scalar or vector. 2015-02-09 Michael Collison Backport from trunk r216736. 2014-10-27 Alan Lawrence PR tree-optimization/61114 * expr.c (expand_expr_real_2): For REDUC_{MIN,MAX,PLUS}_EXPR, add extract_bit_field around optab result. * fold-const.c (fold_unary_loc): For REDUC_{MIN,MAX,PLUS}_EXPR, produce scalar not vector. * tree-cfg.c (verify_gimple_assign_unary): Check result vs operand type for REDUC_{MIN,MAX,PLUS}_EXPR. * tree-vect-loop.c (vect_analyze_loop): Update comment. (vect_create_epilog_for_reduction): For direct vector reduction, use result of tree code directly without extract_bit_field. * tree.def (REDUC_MAX_EXPR, REDUC_MIN_EXPR, REDUC_PLUS_EXPR): Update comment. 2015-02-09 Michael Collison Backport from trunk r216734. 2014-10-27 Alan Lawrence * config/aarch64/aarch64.c (TARGET_GIMPLE_FOLD_BUILTIN): Comment out. * config/aarch64/aarch64-builtins.c (aarch64_gimple_fold_builtin): Remove using preprocessor directis. Modified: branches/linaro/gcc-4_9-branch/gcc/ChangeLog.linaro branches/linaro/gcc-4_9-branch/gcc/cfgexpand.c branches/linaro/gcc-4_9-branch/gcc/config/aarch64/aarch64-builtins.c branches/linaro/gcc-4_9-branch/gcc/config/aarch64/aarch64-simd-builtins.def branches/linaro/gcc-4_9-branch/gcc/config/aarch64/aarch64-simd.md branches/linaro/gcc-4_9-branch/gcc/config/aarch64/arm_neon.h branches/linaro/gcc-4_9-branch/gcc/config/aarch64/iterators.md branches/linaro/gcc-4_9-branch/gcc/doc/md.texi branches/linaro/gcc-4_9-branch/gcc/expr.c branches/linaro/gcc-4_9-branch/gcc/fold-const.c branches/linaro/gcc-4_9-branch/gcc/optabs.c branches/linaro/gcc-4_9-branch/gcc/optabs.def branches/linaro/gcc-4_9-branch/gcc/optabs.h branches/linaro/gcc-4_9-branch/gcc/tree-cfg.c branches/linaro/gcc-4_9-branch/gcc/tree-inline.c branches/linaro/gcc-4_9-branch/gcc/tree-pretty-print.c branches/linaro/gcc-4_9-branch/gcc/tree-vect-generic.c branches/linaro/gcc-4_9-branch/gcc/tree-vect-loop.c branches/linaro/gcc-4_9-branch/gcc/tree.def