[Bug fortran/61126] New: gfortran does not enable -Wununused-parameter with -Wextra

[Bug fortran/61126] New: gfortran does not enable -Wununused-parameter with -Wextra

[fweimer at redhat dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61126

            Bug ID: 61126
           Summary: gfortran does not enable -Wununused-parameter with
                    -Wextra
           Product: gcc
           Version: 4.10.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: fweimer at redhat dot com

The gfortran.dg/wextra_1.f test case assumes that -Wextra enables
-Wununused-parameter, but this does not happen.  No warning is printed on line
4, leading to a test failure.

[Bug fortran/61126] gfortran does not enable -Wununused-parameter with -Wextra

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61126

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-05-09
                 CC|                            |doko at cs dot tu-berlin.de
     Ever confirmed|0                           |1

--- Comment #1 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Likely caused by r210246 (see
http://gcc.gnu.org/ml/gcc-regression/2014-05/msg00091.html).

[Bug fortran/61126] gfortran does not enable -Wununused-parameter with -Wextra

[fweimer at redhat dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61126

--- Comment #3 from Florian Weimer <fweimer at redhat dot com> ---
(In reply to Matthias Klose from comment #2)
> -Wunused-parameter is enabled by -Wall. I'm surprised that -Wextra is used
> without -Wall, but it happens in the testsuite in more places.

This is not what the documentation says:

@item -Wextra
@opindex @code{Wextra}
@cindex extra warnings
@cindex warnings, extra
Enables some warning options for usages of language features which
may be problematic. This currently includes @option{-Wcompare-reals}
and @option{-Wunused-parameter}.

[Bug fortran/61126] gfortran does not enable -Wununused-parameter with -Wextra

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61126

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu.org

--- Comment #4 from Tobias Burnus <burnus at gcc dot gnu.org> ---
(In reply to Matthias Klose from comment #2)
> -Wunused-parameter is enabled by -Wall.

No, according to the manual it isn't. I think one reason for confusion is the
naming of things in the different languages.

Named constants are called in Fortran "PARAMETER" and the thing you pass to a
procedure (function, subroutine) are called "(actual) arguments" - those get
associated with "dummy arguments"/"formal arguments".

In C, you call arguments "parameters". Thus, taking about "parameter" is highly
confusing. I think it neither really fits to named constants nor to arguments,
but since languages have chosen the term ...

From the gfortran man page:

"-Wunused-parameter
Contrary to gcc’s meaning of -Wunused-parameter, gfortran’s implementation of
this option does not warn about unused dummy arguments (see
-Wunused-dummy-argument), but about unused "PARAMETER" values.
-Wunused-parameter is not included in -Wall but is implied by -Wall -Wextra."
>From gcc-bugs-return-451138-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri May 09 15:34:28 2014
Return-Path: <gcc-bugs-return-451138-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 24172 invoked by alias); 9 May 2014 15:34:28 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 24125 invoked by uid 48); 9 May 2014 15:34:25 -0000
From: "doko at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/61126] gfortran does not enable -Wununused-parameter with -Wextra
Date: Fri, 09 May 2014 15:34:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 4.10.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: doko at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61126-4-3LsORRTsbh@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61126-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61126-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg00830.txt.bz2
Content-length: 272

http://gcc.gnu.org/bugzilla/show_bug.cgi?ida126

--- Comment #5 from Matthias Klose <doko at gcc dot gnu.org> ---
"-Wunused-parameter is not included in -Wall but is implied by -Wall -Wextra"
would mean that the test case assumes that it it is implied by -Wextra only.

[Bug fortran/61126] gfortran does not enable -Wununused-parameter with -Wextra

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61126

--- Comment #6 from Tobias Burnus <burnus at gcc dot gnu.org> ---
(In reply to Florian Weimer from comment #3)
> (In reply to Matthias Klose from comment #2)
> > -Wunused-parameter is enabled by -Wall. I'm surprised that -Wextra is used
> > without -Wall, but it happens in the testsuite in more places.

Actually, looking at gcc/common.opt, one finds:
  Wunused-parameter
  Common Var(warn_unused_parameter) Warning EnabledBy(Wunused && Wextra)

Thus, in GCC - whether Fortran or C - it is enabled with -Wextra, but only if
also -Wunused is used. The latter is implied by -Wall.

[Bug fortran/61126] gfortran does not enable -Wununused-parameter with -Wextra

[manu at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61126

--- Comment #7 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Florian Weimer from comment #0)
> The gfortran.dg/wextra_1.f test case assumes that -Wextra enables
> -Wununused-parameter, but this does not happen.  No warning is printed on
> line 4, leading to a test failure.

I don't understand how it was working before. What is exactly the command-line
passed to that testcase?
>From gcc-bugs-return-451144-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri May 09 16:04:51 2014
Return-Path: <gcc-bugs-return-451144-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 21376 invoked by alias); 9 May 2014 16:04:51 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 21098 invoked by uid 48); 9 May 2014 16:04:47 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/61126] gfortran does not enable -Wununused-parameter with -Wextra
Date: Fri, 09 May 2014 16:04:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 4.10.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61126-4-AfYG93hPTN@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61126-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61126-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg00836.txt.bz2
Content-length: 619

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61126

--- Comment #8 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Tobias Burnus from comment #6)
> Thus, in GCC - whether Fortran or C - it is enabled with -Wextra, but only
> if also -Wunused is used. The latter is implied by -Wall.

This is not necessarily true for gfortran, since it doesn't use the common
options machinery and it fiddles with the options directly. I'm not sure if
this is the case or not for this particular option, but it could be a
possibility (one more reason to move gfortran to use the common machinery).
>From gcc-bugs-return-451145-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri May 09 16:08:43 2014
Return-Path: <gcc-bugs-return-451145-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 8582 invoked by alias); 9 May 2014 16:08:41 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 8374 invoked by uid 55); 9 May 2014 16:08:33 -0000
From: "doko at ubuntu dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/61126] gfortran does not enable -Wununused-parameter with -Wextra
Date: Fri, 09 May 2014 16:08:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 4.10.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: doko at ubuntu dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61126-4-7vKwWrJwhV@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61126-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61126-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg00837.txt.bz2
Content-length: 373

http://gcc.gnu.org/bugzilla/show_bug.cgi?ida126

--- Comment #9 from Matthias Klose <doko at ubuntu dot com> ---
Am 09.05.2014 18:02, schrieb manu at gcc dot gnu.org:
> I don't understand how it was working before. What is exactly the
> command-line passed to that testcase?

the test passes just -Wextra, adding either a -Wunused or a -Wall lets the
warning re-appear.

[Bug fortran/61126] gfortran does not enable -Wununused-parameter with -Wextra

[manu at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61126

--- Comment #10 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Manuel López-Ibáñez from comment #7)
> (In reply to Florian Weimer from comment #0)
> > The gfortran.dg/wextra_1.f test case assumes that -Wextra enables
> > -Wununused-parameter, but this does not happen.  No warning is printed on
> > line 4, leading to a test failure.
> 
> I don't understand how it was working before. What is exactly the
> command-line passed to that testcase?

I think in Fortran, -Wextra just generates -Wunused-parameter because of this:

Index: options.c
===================================================================
--- options.c   (revision 209347)
+++ options.c   (working copy)
@@ -672,16 +672,11 @@ gfc_handle_option (size_t scode, const c
     case OPT_Wconversion_extra:
       gfc_option.warn_conversion_extra = value;
       break;

     case OPT_Wextra:
-      handle_generated_option (&global_options, &global_options_set,
-                              OPT_Wunused_parameter, NULL, value,
-                              gfc_option_lang_mask (), kind, loc,
-                              handlers, global_dc);
       set_Wextra (value);
-
       break;

     case OPT_Wfunction_elimination:
       gfc_option.warn_function_elimination = value;
       break;

If you want to have the same behavior in Fortran as in the rest of GCC, then
delete the above. The above was enabling -Wunused-parameter just with -Wextra
(only in Fortran), and because of the existing bug fixed by r210246, this was
never overriden by the general machinery.
>From gcc-bugs-return-451148-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri May 09 16:23:04 2014
Return-Path: <gcc-bugs-return-451148-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 7702 invoked by alias); 9 May 2014 16:23:04 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 7404 invoked by uid 48); 9 May 2014 16:23:00 -0000
From: "yaozhen_guo at yahoo dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/57494] [4.9 regression] bootstrap comparison failure
Date: Fri, 09 May 2014 16:23:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: bootstrap
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: blocker
X-Bugzilla-Who: yaozhen_guo at yahoo dot com
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-57494-4-e7NjN6GkEH@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-57494-4@http.gcc.gnu.org/bugzilla/>
References: <bug-57494-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg00840.txt.bz2
Content-length: 474

http://gcc.gnu.org/bugzilla/show_bug.cgi?idW494

YaoZhenGuo <yaozhen_guo at yahoo dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yaozhen_guo at yahoo dot com

--- Comment #3 from YaoZhenGuo <yaozhen_guo at yahoo dot com> ---
(In reply to Richard Biener from comment #2)
> patch was reverted.

Where can get the patch?

[Bug fortran/61126] gfortran does not enable -Wununused-parameter with -Wextra

[manu at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61126

--- Comment #11 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Note that the above code is broken in other ways:

-Wno-unused-parameter -Wextra will enable -Wunused-parameter, which is not what
should happen.
>From gcc-bugs-return-451151-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri May 09 17:00:35 2014
Return-Path: <gcc-bugs-return-451151-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 15602 invoked by alias); 9 May 2014 17:00:34 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 15536 invoked by uid 55); 9 May 2014 17:00:30 -0000
From: "tejohnson at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/61009] [4.9 Regression] Incorrect jump threading in dom
Date: Fri, 09 May 2014 17:00:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 4.10.0
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: tejohnson at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: law at redhat dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61009-4-CxIZrq991X@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61009-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61009-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg00843.txt.bz2
Content-length: 951

http://gcc.gnu.org/bugzilla/show_bug.cgi?ida009

--- Comment #12 from tejohnson at gcc dot gnu.org ---
Author: tejohnson
Date: Fri May  9 16:59:56 2014
New Revision: 210279

URL: http://gcc.gnu.org/viewcvs?rev!0279&root=gcc&view=rev
Log:
Backport r210254 from trunk for Google b/14380607.

    2014-05-08  Jeff Law  <law@redhat.com>

    PR tree-optimization/61009
    * tree-ssa-threadedge.c (thread_through_normal_block): Return a
    tri-state rather than a boolean.  When a block is too big to
    thread through, inform caller via negative return value.
    (thread_across_edge): If a block was too big for normal threading,
    then it's too big for a joiner too, so remove temporary equivalences
    and return immediately.

    PR tree-optimization/61009
    * g++.dg/tree-ssa/pr61009.C: New test.

Added:
    branches/google/gcc-4_9/gcc/testsuite/g++.dg/tree-ssa/pr61009.C
Modified:
    branches/google/gcc-4_9/gcc/tree-ssa-threadedge.c

[Bug fortran/61126] gfortran does not enable -Wununused-parameter with -Wextra

[manu at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61126

--- Comment #14 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Manuel López-Ibáñez from comment #13)
> This builds gfortran and fixes the testcase, but I haven't tested it beyond
> that.

Together with the patch in comment #10, of course.
>From gcc-bugs-return-451191-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri May 09 22:39:04 2014
Return-Path: <gcc-bugs-return-451191-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 7972 invoked by alias); 9 May 2014 22:39:03 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 7889 invoked by uid 55); 9 May 2014 22:38:58 -0000
From: "joseph at codesourcery dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/61126] gfortran does not enable -Wununused-parameter with -Wextra
Date: Fri, 09 May 2014 22:39:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 4.10.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: joseph at codesourcery dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61126-4-7aC89h4qC4@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61126-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61126-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg00883.txt.bz2
Content-length: 256

http://gcc.gnu.org/bugzilla/show_bug.cgi?ida126

--- Comment #15 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
I think that if the order in which the handlers are executed matters,
something is too fragile in those handlers.

[Bug fortran/61126] gfortran does not enable -Wununused-parameter with -Wextra

[doko at ubuntu dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61126

--- Comment #16 from Matthias Klose <doko at ubuntu dot com> ---
Am 10.05.2014 00:21, schrieb manu at gcc dot gnu.org:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61126
> 
> --- Comment #14 from Manuel López-Ibáñez <manu at gcc dot gn
> u.org> ---
> 
> (In reply to Manuel López-Ibáñez from comment #13)
> 
>> This builds gfortran and fixes the testcase, but I haven't tested it
>> beyond that.
> 
> Together with the patch in comment #10, of course.

fixes the test and doesn't show regressions on the trunk. Now testing the
branches.
>From gcc-bugs-return-451212-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat May 10 12:46:18 2014
Return-Path: <gcc-bugs-return-451212-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 12529 invoked by alias); 10 May 2014 12:46:17 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 12491 invoked by uid 48); 10 May 2014 12:46:12 -0000
From: "i.nixman at autistici dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/60244] GCC-trunk rev.207809, Segmentation fault when executing ".../xgcc -dumpspecs"
Date: Sat, 10 May 2014 12:46:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: bootstrap
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: i.nixman at autistici dot org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-60244-4-lZYoz3ws8c@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-60244-4@http.gcc.gnu.org/bugzilla/>
References: <bug-60244-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg00904.txt.bz2
Content-length: 435

http://gcc.gnu.org/bugzilla/show_bug.cgi?id`244

--- Comment #4 from niXman <i.nixman at autistici dot org> ---
(In reply to Halo9Pan03 from comment #3)
> I got the same problem.
> niXman, did you have a patch for it? Because I found you already build
> i686-w64-mingw32 with gcc 4.9.0 and dwarf2 successfully.
> Thanks.

This error occurred when I tried to build GCC-trunk rev.205009, but gcc-4.9.0
release was built successfully.

[Bug fortran/61126] gfortran does not enable -Wununused-parameter with -Wextra

[doko at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61126

--- Comment #17 from Matthias Klose <doko at gcc dot gnu.org> ---
patch posted at
http://gcc.gnu.org/ml/gcc-patches/2014-05/msg00785.html

[Bug fortran/61126] [4.8/4.9/4.10 Regression] gfortran does not enable -Wununused-parameter with -Wextra

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61126

Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hp at gcc dot gnu.org
            Summary|gfortran does not enable    |[4.8/4.9/4.10 Regression]
                   |-Wununused-parameter with   |gfortran does not enable
                   |-Wextra                     |-Wununused-parameter with
                   |                            |-Wextra

--- Comment #18 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
I'm adding proper regression markers in the title. The cause may be odd but
it's an observed regression in test-results no matter what the cause.  I've
noticed this test passing on trunk ("4.10") for cris-elf since it was
introduced (in r192649) until starting to fail in the window (210245:210253],
matching comment 1.  For 4.9, the window is (210236:210248] and for 4.8 it's
(210245:210253].  It's also seems to be everywhere (all targets) so I wonder if
the author did valid testing and not incorrectly e.g skip fortran testing when
saying "no regressions with the trunk, the 4.9 and 4.8 branches" in the patch
submission.

[Bug fortran/61126] [4.8/4.9/4.10 Regression] gfortran does not enable -Wununused-parameter with -Wextra

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61126

--- Comment #19 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
(In reply to Hans-Peter Nilsson from comment #18)
Ah, I saw the link in comment 17 now.

[Bug fortran/61126] [4.10 Regression] gfortran does not enable -Wununused-parameter with -Wextra

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61126

Matthias Klose <doko at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.8/4.9/4.10 Regression]   |[4.10 Regression] gfortran
                   |gfortran does not enable    |does not enable
                   |-Wununused-parameter with   |-Wununused-parameter with
                   |-Wextra                     |-Wextra

--- Comment #20 from Matthias Klose <doko at gcc dot gnu.org> ---
the fix for PR61106 is now reverted on the branches.

[Bug fortran/61126] [4.10 Regression] gfortran does not enable -Wununused-parameter with -Wextra

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61126

--- Comment #21 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> > -Wunused-parameter is enabled by -Wall.
>
> No, according to the manual it isn't.

The gfortran manual reads:

-Wunused-parameter
Contrary to gcc's meaning of -Wunused-parameter, gfortran's implementation of
this option does not warn about unused dummy arguments (see
-Wunused-dummy-argument), but about unused PARAMETER values. -Wunused-parameter
is not included in -Wall but is implied by -Wall -Wextra. 

This should probably be changed if -Wunused-parameter is implied by -Wextra.

Note that if -Wextra can be used alone without implying -Wall, it is yet
another poor choice for the -W naming (starting with -Wall which is not all
warnings at all).

[Bug fortran/61126] [4.10 Regression] gfortran does not enable -Wununused-parameter with -Wextra

[manu at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61126

--- Comment #22 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Dominique d'Humieres from comment #21)
> -Wunused-parameter
> Contrary to gcc's meaning of -Wunused-parameter, gfortran's implementation
> of this option does not warn about unused dummy arguments (see
> -Wunused-dummy-argument), but about unused PARAMETER values.
> -Wunused-parameter is not included in -Wall but is implied by -Wall -Wextra. 
> 
> This should probably be changed if -Wunused-parameter is implied by -Wextra.

What is that gfortran wants? 

1. -Wunused-parameter is enabled just by -Wextra. This needs the patches above
plus update the manual. This means that -Wextra -Wno-unused, will keep giving
-Wunused-parameter warnings.

2. Follow all the other FEs, that is, -Wunused-parameter is enabled by the
combination of -Wunused and -Wextra. This needs just the patch in comment #10
plus change -Wall to -Wunused in the manual (the current text is correct, but
the actual reason is that -Wall implies -Wunused, so -Wall -Wextra => -Wunused
-Wextra => -Wunused-parameter).
>From gcc-bugs-return-451675-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu May 15 11:27:53 2014
Return-Path: <gcc-bugs-return-451675-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 15235 invoked by alias); 15 May 2014 11:27:52 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 14828 invoked by uid 48); 15 May 2014 11:27:49 -0000
From: "tony.theodore at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug lto/60981] lto-plugin configuration doesn't test for -static-libgcc (OSX gcc -> clang)
Date: Thu, 15 May 2014 11:27:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: lto
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: tony.theodore at gmail dot com
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: ro at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.1
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-60981-4-by9mnePuib@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-60981-4@http.gcc.gnu.org/bugzilla/>
References: <bug-60981-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg01367.txt.bz2
Content-length: 133

https://gcc.gnu.org/bugzilla/show_bug.cgi?id`981

--- Comment #11 from Tony Theodore <tony.theodore at gmail dot com> ---
Thanks!

[Bug fortran/61126] [4.10 Regression] gfortran does not enable -Wununused-parameter with -Wextra

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61126

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
   Target Milestone|---                         |4.10.0

[Bug fortran/61126] [4.10 Regression] gfortran does not enable -Wununused-parameter with -Wextra

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61126

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #27 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Should be FIXED.

The first commit contains the patches from comment 10 and 23, the second (cf.
comment 22) mentions -Wextra -Wunused in the manual; I kept the -Wextra -Wall
in line with gcc/doc/invoke.texi, even though -Wall is only indirectly
affecting this option.