[Bug other/61146] New: wide-int error when building GCC with clang

[Bug other/61146] New: wide-int error when building GCC with clang

[olegendo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61146

            Bug ID: 61146
           Summary: wide-int error when building GCC with clang
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
          Assignee: unassigned at gcc dot gnu.org
          Reporter: olegendo at gcc dot gnu.org

Created attachment 32776
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32776&action=edit
compressed build log

Building an SH cross GCC on OSX with clang results in the following errors:

../../gcc-trunk/gcc/wide-int.cc:1269:23: error: invalid use of a cast in a
inline asm context requiring an l-value: remove the cast or build with
-fheinous-gnu-extensions
          umul_ppmm (val[1], val[0], op1.ulow (), op2.ulow ());
          ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../gcc-trunk/gcc/../include/longlong.h:505:24: note: expanded from macro
'umul_ppmm'
           : "=a" ((UDItype) (w0)),                                     \
                              ^
../../gcc-trunk/gcc/wide-int.cc:1269:15: error: invalid use of a cast in a
inline asm context requiring an l-value: remove the cast or build with
-fheinous-gnu-extensions
          umul_ppmm (val[1], val[0], op1.ulow (), op2.ulow ());
          ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../gcc-trunk/gcc/../include/longlong.h:506:24: note: expanded from macro
'umul_ppmm'
             "=d" ((UDItype) (w1))                                      \
                              ^
../../gcc-trunk/gcc/wide-int.cc:1278:22: error: invalid use of a cast in a
inline asm context requiring an l-value: remove the cast or build with
-fheinous-gnu-extensions
          umul_ppmm (upper, val[0], op1.ulow (), op2.ulow ());
          ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../gcc-trunk/gcc/../include/longlong.h:505:24: note: expanded from macro
'umul_ppmm'
           : "=a" ((UDItype) (w0)),                                     \
                              ^
../../gcc-trunk/gcc/wide-int.cc:1278:15: error: invalid use of a cast in a
inline asm context requiring an l-value: remove the cast or build with
-fheinous-gnu-extensions
          umul_ppmm (upper, val[0], op1.ulow (), op2.ulow ());
          ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../gcc-trunk/gcc/../include/longlong.h:506:24: note: expanded from macro
'umul_ppmm'
             "=d" ((UDItype) (w1))

The full log is attached, which shows also other (spurious) warnings.

The problem can be worked around by setting
export CFLAGS="-fheinous-gnu-extensions"
export CXXFLAGS="-fheinous-gnu-extensions"
export CFLAGS_FOR_TARGET="-O2"
export CXXFLAGS_FOR_TARGET="-O2"

The *FLAGS_FOR_TARGET are required or else they will be set to *FLAGS, which
will pass -fheinous-gnu-extensions to the SH xgcc when building libgcc etc. (PR
25672)

The clang version on my OSX system:
clang -v
Apple LLVM version 5.1 (clang-503.0.40) (based on LLVM 3.4svn)
Target: x86_64-apple-darwin13.1.0
Thread model: posix

[Bug other/61146] wide-int error when building GCC with clang

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61146

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
The cast is useless so it is ignored by gcc. Anyways this inline-asm is a gcc
extension so this is not a bug at all unless the inline-asm is not not bounded
by a check for gnu c++. Clang should not be saying it supports gnu c++ unless
it really supports it.

[Bug other/61146] wide-int error when building GCC with clang

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61146

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |INVALID

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
#if defined (__GNUC__) && !defined (NO_ASM)

not a GCC source bug. Rather Clang should not define __GNUC__ at all.  This is
the same issue with ICC really we had declared that they both falsely define
__GNUC__ when they don't implement the full GNU C/C++ extensions.  Please file
a bug report to clang to have them stop defining __GNUC__.

[Bug other/61146] wide-int error when building GCC with clang

[glisse at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=61146

--- Comment #3 from Marc Glisse <glisse at gcc dot gnu.org> ---
These casts still look like a bad idea to me. GMP's version of longlong.h
removed the lvalue casts in 2005, and I don't see the point of keeping them
here. Can we pretend the PR wasn't caused by using clang and consider it a
cleanup?

[Bug other/61146] wide-int error when building GCC with clang

[mrs at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61146

mrs at gcc dot gnu.org <mrs at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fxcoudert at gcc dot gnu.org

--- Comment #5 from mrs at gcc dot gnu.org <mrs at gcc dot gnu.org> ---
*** Bug 61315 has been marked as a duplicate of this bug. ***

[Bug other/61146] wide-int error when building GCC with clang

[mrs at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61146

mrs at gcc dot gnu.org <mrs at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |ASSIGNED
   Last reconfirmed|                            |2014-05-27
                 CC|                            |mrs at gcc dot gnu.org
         Resolution|INVALID                     |---
     Ever confirmed|0                           |1

--- Comment #6 from mrs at gcc dot gnu.org <mrs at gcc dot gnu.org> ---
Don't worry, gcc will build with clang.

[Bug other/61146] wide-int error when building GCC with clang

[mrs at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61146

--- Comment #7 from mrs at gcc dot gnu.org <mrs at gcc dot gnu.org> ---
Patch posted https://gcc.gnu.org/ml/gcc/2014-05/msg00316.html

[Bug other/61146] wide-int error when building GCC with clang

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61146

Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
Alternative patch committed to trunk. Fixed.

[Bug other/61146] wide-int error when building GCC with clang

[mrs at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61146

mrs at gcc dot gnu.org <mrs at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |ASSIGNED
         Resolution|FIXED                       |---

--- Comment #9 from mrs at gcc dot gnu.org <mrs at gcc dot gnu.org> ---
Thanks.

[Bug other/61146] wide-int error when building GCC with clang

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61146

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
It is fixed, isn't it?

[Bug other/61146] wide-int error when building GCC with clang

[howarth.at.gcc at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61146

Jack Howarth <howarth.at.gcc at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |howarth.at.gcc at gmail dot com

--- Comment #12 from Jack Howarth <howarth.at.gcc at gmail dot com> ---
(In reply to mrs@gcc.gnu.org from comment #11)
> Yes, weird, thanks.

A find that gcc trunk at r211023 bootstrap fines against the clang 3.4svn-based
compilers from Xcode 5.1.1. However I am still puzzled why, considering that it
is agreed that the casts are useless and ignored by gcc, why they weren't just
removed? I did find that freebsd has been doing this…

http://svnweb.freebsd.org/base/head/contrib/gcc/longlong.h?view=patch&r1=211505&r2=211504&pathrev=211505
>From gcc-bugs-return-452749-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed May 28 18:48:05 2014
Return-Path: <gcc-bugs-return-452749-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 10490 invoked by alias); 28 May 2014 18:48:04 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 10291 invoked by uid 48); 28 May 2014 18:47:59 -0000
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug other/61146] wide-int error when building GCC with clang
Date: Wed, 28 May 2014 18:48:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: other
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: redi at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61146-4-8fVqOwORe7@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61146-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61146-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg02441.txt.bz2
Content-length: 170

https://gcc.gnu.org/bugzilla/show_bug.cgi?ida146

--- Comment #13 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Because they are not ignored and are not useless.

[Bug other/61146] wide-int error when building GCC with clang

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61146

--- Comment #14 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> Because they are not ignored and are not useless.

See https://gcc.gnu.org/ml/gcc/2014-05/msg00332.html.

[Bug other/61146] wide-int error when building GCC with clang

[mikestump at comcast dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61146

--- Comment #15 from Mike Stump <mikestump at comcast dot net> ---
Short answer, error checking.  Remove them and one removes some error checking.

[Bug other/61146] wide-int error when building GCC with clang

[howarth.at.gcc at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61146

--- Comment #16 from Jack Howarth <howarth.at.gcc at gmail dot com> ---
(In reply to Mike Stump from comment #15)
> Short answer, error checking.  Remove them and one removes some error
> checking.

Will the current fix have any impact on our having the complete wide-int
functionality on darwin?

[Bug other/61146] wide-int error when building GCC with clang

[manu at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61146

--- Comment #17 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
The changelog was wrong. This is why bugzilla didn't catch the commit. It
should have said:

PR bootstrap/61146

instead of

PR bootstrap/PR61146

It would be nice to have a commit hook that catches this kind of thing.
>From gcc-bugs-return-452757-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed May 28 19:59:17 2014
Return-Path: <gcc-bugs-return-452757-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 19262 invoked by alias); 28 May 2014 19:59:16 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 19078 invoked by uid 48); 28 May 2014 19:59:12 -0000
From: "dominiq at lps dot ens.fr" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug other/61146] wide-int error when building GCC with clang
Date: Wed, 28 May 2014 19:59:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: other
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dominiq at lps dot ens.fr
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61146-4-4BcTibVZRw@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61146-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61146-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg02449.txt.bz2
Content-length: 343

https://gcc.gnu.org/bugzilla/show_bug.cgi?ida146

--- Comment #18 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Revision 211023

Author:    fxcoudert
Date:    Wed May 28 15:17:29 2014 UTC (4 hours, 39 minutes ago)
Log Message:
    PR bootstrap/PR61146
    * wide-int.cc: Do not include longlong.h when compiling with clang.

[Bug other/61146] wide-int error when building GCC with clang

[mikestump at comcast dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61146

--- Comment #19 from Mike Stump <mikestump at comcast dot net> ---
Nope.