[Bug c/61162] possibly bad error location with -Wc++-compat

["tromey at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61162

--- Comment #9 from Tom Tromey <tromey at gcc dot gnu.org> ---
(In reply to Manuel López-Ibáñez from comment #8)

> If you point to '=', then the macro expansion note will not appear in your
> other example (PR61165).

Yeah, I still think the '=' is preferable.
I think it lets one know exactly where to insert a cast.
>From gcc-bugs-return-451489-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue May 13 15:51:17 2014
Return-Path: <gcc-bugs-return-451489-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 8848 invoked by alias); 13 May 2014 15:51:17 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 8178 invoked by uid 48); 13 May 2014 15:51:10 -0000
From: "tony.theodore at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug lto/60981] lto-plugin configuration doesn't test for -static-libgcc (OSX gcc -> clang)
Date: Tue, 13 May 2014 15:51:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: lto
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: tony.theodore at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-60981-4-KGmKFtYHkP@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-60981-4@http.gcc.gnu.org/bugzilla/>
References: <bug-60981-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg01181.txt.bz2
Content-length: 1574

https://gcc.gnu.org/bugzilla/show_bug.cgi?id`981

--- Comment #6 from Tony Theodore <tony.theodore at gmail dot com> ---
(In reply to ro@CeBiTec.Uni-Bielefeld.DE from comment #4)
> > --- Comment #3 from Tony Theodore <tony.theodore at gmail dot com> ---
> > I'm building a cross compiler with:
>
> It would have helped enormously if you'd stated so in the first place.

Apologies.

> > Apple LLVM version 5.1 (clang-503.0.40) (based on LLVM 3.4svn)
> > Target: x86_64-apple-darwin13.1.0
> > Thread model: posix
>
> On Mac OS X 10.7, gcc -v *does accept* -static-libgcc, though, although
> it's also LLVM-based.  No idea why they changed this in 10.9.

Up till LLVM 3.3 there was a gcc plugin called DragonEgg which used gcc as a
front-end and LLVM as the back-end. Now "gcc" is basically an alias for the
clang front-end.

> Your proposed patch has two problems, unfortunately:
>
> * Don't check for $GCC.  I don't care who the compiler thinks he is as
>   long as it accepts -static-libgcc.
>
> * The gcc version check is wrong: -static-libgcc goes back way long
>   (even 2.95 and perhaps even before).  It did apply to
>   -static-libstdc++, though I don't know what a version check buys us if
>   the compiler accepts the option.

Thanks for the explanation, that make sense.

> Please try the attached patch instead.  Manual testing with Oracle
> Studio cc (which doesn't accept -static-libgcc) and gcc gave the correct
> results.

I can confirm that this works with all three mingw targets (after installing
autoconf 2.64) - thank you very much!

Cheers,

Tony