public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/61166] overflow when parse number in std::duration operator"" Date: Fri, 16 May 2014 07:17:00 -0000 [thread overview] Message-ID: <bug-61166-4-cxOOY8ew95@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-61166-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61166 --- Comment #11 from Jonathan Wakely <redi at gcc dot gnu.org> --- (In reply to Kan Liu from comment #10) > _Select_type already does the overflow check, so *template implemented > operators* is still redundant I think. You can't use _Select_type on a literal operator that is not a template. > Since the standard units (std::hours, > milliseconds ...) requires the duration::rep to be *int64_t*, No it doesn't, only chrono::nanoseconds is required to have a 64-bit representation. chrono::hours and chrono::minutes are allowed to have fewer than 32 bits ("at least 23 bits" and "at least 29 bits" respectively). > there's no > need to do too much check. Not all values of uint64_t fit in int64_t
next prev parent reply other threads:[~2014-05-16 7:17 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-05-13 7:42 [Bug libstdc++/61166] New: " kan.liu.229 at gmail dot com 2014-05-13 10:55 ` [Bug libstdc++/61166] " paolo.carlini at oracle dot com 2014-05-13 13:34 ` emsr at gcc dot gnu.org 2014-05-13 13:41 ` kan.liu.229 at gmail dot com 2014-05-13 13:46 ` kan.liu.229 at gmail dot com 2014-05-13 18:06 ` 3dw4rd at verizon dot net 2014-05-14 14:12 ` kan.liu.229 at gmail dot com 2014-05-14 18:15 ` redi at gcc dot gnu.org 2014-05-14 18:15 ` redi at gcc dot gnu.org 2014-05-15 19:09 ` redi at gcc dot gnu.org 2014-05-16 5:55 ` kan.liu.229 at gmail dot com 2014-05-16 7:17 ` redi at gcc dot gnu.org [this message] 2014-05-16 7:32 ` kan.liu.229 at gmail dot com 2014-05-16 9:31 ` redi at gcc dot gnu.org 2014-06-23 15:39 ` redi at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-61166-4-cxOOY8ew95@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).