public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rsandifo at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/61268] [4.10 regression] ICE in vt_expand_var_loc_chain, at var-tracking.c:8262
Date: Wed, 18 Jun 2014 08:19:00 -0000	[thread overview]
Message-ID: <bug-61268-4-FOdHSha4OG@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-61268-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61268

rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |rsandifo at gcc dot gnu.org

--- Comment #5 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> ---
Created attachment 32962
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=32962&action=edit
Proposed patch

This was caused by some invalid rtl sharing between DECL_INCOMING_RTL
and the insn stream.  I think the right fix is (a) to copy stack_parm
and entry_parm before using them in the rtl stream and (b) as compensation,
to allow validize_mem to modify its argument in-place.  As well as fixing
the bug, this seems to reduce the total amount of rtl copying required.

Of course, the problem with (b) is that this could in turn expose other
invalid sharing bugs, so it's a bit frying-pan-to-fire.  I've tried to
look through all calls to validize_mem to see which might be affected.

The patch passed bootstrap on x86_64-linux-gnu but could you test it for
sparc too?


  parent reply	other threads:[~2014-06-18  8:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-21 12:17 [Bug middle-end/61268] New: " ro at gcc dot gnu.org
2014-05-21 12:18 ` [Bug middle-end/61268] " ro at gcc dot gnu.org
2014-06-17 13:08 ` ro at gcc dot gnu.org
2014-06-17 13:08 ` ro at gcc dot gnu.org
2014-06-17 14:02 ` ro at gcc dot gnu.org
2014-06-17 14:03 ` ro at gcc dot gnu.org
2014-06-18  8:19 ` rsandifo at gcc dot gnu.org [this message]
2014-06-18  8:55 ` ro at CeBiTec dot Uni-Bielefeld.DE
2014-07-17 11:47 ` ro at gcc dot gnu.org
2014-07-17 23:53 ` pthaugen at gcc dot gnu.org
2014-07-24 15:18 ` rsandifo at gcc dot gnu.org
2014-07-24 15:36 ` rsandifo at gcc dot gnu.org
2014-07-28  8:46 ` rsandifo at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-61268-4-FOdHSha4OG@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).