public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c/61271] New: 3 * possible coding error with logical not (!)
@ 2014-05-21 14:01 dcb314 at hotmail dot com
2014-05-21 14:20 ` [Bug c/61271] " dcb314 at hotmail dot com
` (20 more replies)
0 siblings, 21 replies; 22+ messages in thread
From: dcb314 at hotmail dot com @ 2014-05-21 14:01 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61271
Bug ID: 61271
Summary: 3 * possible coding error with logical not (!)
Product: gcc
Version: 4.9.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: c
Assignee: unassigned at gcc dot gnu.org
Reporter: dcb314 at hotmail dot com
I just compiled gcc trunk 20140521 with boot compiler clang++ -g -O2 -Wall
and it said
1.
../../src/trunk/gcc/cgraphunit.c:1182:8: warning: logical not is only applied
to the left hand side of this comparison [-Wlogical-not-parentheses]
Source code is
&& (! TREE_CODE (target_node->decl) == FUNCTION_DECL
Maybe
&& (TREE_CODE (target_node->decl) != FUNCTION_DECL)
was intended.
2.
../../src/trunk/gcc/config/i386/i386.c:37905:10: warning: logical not is only
applied to the left hand side of this comparison [-Wlogical-not-parentheses]
Source code is
|| (!GET_CODE (x) != LABEL_REF
Confusing with the double negative. Maybe
|| (GET_CODE (x) == LABEL_REF
was intended.
3.
../../src/trunk/gcc/cp/cp-array-notation.c:1420:7: warning: logical not is only
applied to the left hand side of this comparison [-Wlogical-not-parentheses]
Source code is
if (!TREE_CODE (type) == FUNCTION_TYPE)
{
error_at (loc, "array notation cannot be used with function type");
return false;
}
Maybe
if (TREE_CODE (type) == FUNCTION_TYPE)
{
error_at (loc, "array notation cannot be used with function type");
return false;
}
was intended.
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug c/61271] 3 * possible coding error with logical not (!)
2014-05-21 14:01 [Bug c/61271] New: 3 * possible coding error with logical not (!) dcb314 at hotmail dot com
@ 2014-05-21 14:20 ` dcb314 at hotmail dot com
2014-05-21 14:31 ` [Bug c/61271] 6 " redi at gcc dot gnu.org
` (19 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: dcb314 at hotmail dot com @ 2014-05-21 14:20 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61271
--- Comment #1 from David Binderman <dcb314 at hotmail dot com> ---
Some more:
4.
trunk/gcc/expr.c:10660:10: warning: logical not is only applied to the left
hand side of this comparison [-Wlogical-not-parentheses]
Source code
|| !exact_log2 (tree_to_uhwi (TREE_OPERAND (offset, 1)) + 1) < 0)
Maybe
|| exact_log2 (tree_to_uhwi (TREE_OPERAND (offset, 1)) + 1) >= 0)
5.
trunk/gcc/ipa-devirt.c:1122:11: warning: logical not is only applied to the
left hand side of this comparison [-Wlogical-not-parentheses]
Source code is
|| !tree_to_shwi (TYPE_SIZE (subtype)) <= 0)
Maybe
|| tree_to_shwi (TYPE_SIZE (subtype)) > 0)
6.
trunk/gcc/ira-color.c:3851:9: warning: logical not is only applied to the left
hand side of this comparison [-Wlogical-not-parentheses]
Source code is
|| !FRAME_GROWS_DOWNWARD == STACK_GROWS_DOWNWARD ? diff : -diff);
Maybe
|| ((FRAME_GROWS_DOWNWARD != STACK_GROWS_DOWNWARD) ? diff : -diff));
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug c/61271] 6 * possible coding error with logical not (!)
2014-05-21 14:01 [Bug c/61271] New: 3 * possible coding error with logical not (!) dcb314 at hotmail dot com
2014-05-21 14:20 ` [Bug c/61271] " dcb314 at hotmail dot com
@ 2014-05-21 14:31 ` redi at gcc dot gnu.org
2014-05-21 14:33 ` dcb314 at hotmail dot com
` (18 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: redi at gcc dot gnu.org @ 2014-05-21 14:31 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61271
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2014-05-21
Ever confirmed|0 |1
--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
yikes
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug c/61271] 6 * possible coding error with logical not (!)
2014-05-21 14:01 [Bug c/61271] New: 3 * possible coding error with logical not (!) dcb314 at hotmail dot com
2014-05-21 14:20 ` [Bug c/61271] " dcb314 at hotmail dot com
2014-05-21 14:31 ` [Bug c/61271] 6 " redi at gcc dot gnu.org
@ 2014-05-21 14:33 ` dcb314 at hotmail dot com
2014-05-21 16:12 ` [Bug c/61271] 10 " manu at gcc dot gnu.org
` (17 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: dcb314 at hotmail dot com @ 2014-05-21 14:33 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61271
--- Comment #3 from David Binderman <dcb314 at hotmail dot com> ---
Even more:
7.
src/trunk/gcc/lra-spills.c:240:9: warning: logical not is only applied to the
left hand side of this comparison [-Wlogical-not-parentheses]
Source code is
|| !FRAME_GROWS_DOWNWARD == STACK_GROWS_DOWNWARD ? diff : -diff);
Looks like #6
8.
trunk/gcc/sel-sched-ir.c:6189:30: warning: logical not is only applied to the
left hand side of this comparison [-Wlogical-not-parentheses]
Source code is
if (bb->loop_father && !bb->loop_father->num == 0
Maybe
if (bb->loop_father && bb->loop_father->num != 0
9.
trunk/gcc/tree-vect-data-refs.c:1833:11: warning: logical not is only applied
to the left hand side of this comparison [-Wlogical-not-parentheses]
Source code is
if (!LOOP_REQUIRES_VERSIONING_FOR_ALIGNMENT (loop_vinfo))
but
#define LOOP_REQUIRES_VERSIONING_FOR_ALIGNMENT(L) \
(L)->may_misalign_stmts.length () > 0
Maybe
#define LOOP_REQUIRES_VERSIONING_FOR_ALIGNMENT(L) \
((L)->may_misalign_stmts.length () > 0)
might fix the problem.
10.
trunk/gcc/tree-vect-loop.c:1795:14: warning: logical not is only applied to the
left hand side of this comparison [-Wlogical-not-parentheses]
trunk/gcc/tree-vect-loop.c:1796:17: warning: logical not is only applied to the
left hand side of this comparison [-Wlogical-not-parentheses]
Source code is
&& ((!LOOP_REQUIRES_VERSIONING_FOR_ALIAS (loop_vinfo)
&& !LOOP_REQUIRES_VERSIONING_FOR_ALIGNMENT (loop_vinfo))
Maybe something like
#define LOOP_REQUIRES_VERSIONING_FOR_ALIAS(L) \
((L)->may_alias_ddrs.length () > 0)
might solve the problem.
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug c/61271] 10 * possible coding error with logical not (!)
2014-05-21 14:01 [Bug c/61271] New: 3 * possible coding error with logical not (!) dcb314 at hotmail dot com
` (2 preceding siblings ...)
2014-05-21 14:33 ` dcb314 at hotmail dot com
@ 2014-05-21 16:12 ` manu at gcc dot gnu.org
2014-05-22 12:17 ` redi at gcc dot gnu.org
` (16 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: manu at gcc dot gnu.org @ 2014-05-21 16:12 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61271
Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |manu at gcc dot gnu.org
--- Comment #5 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
I'm almost tempted to check svn blame to see who wrote these... a fair acto of
contrition would be to implement the warning for GCC. ;-)
>From gcc-bugs-return-452184-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed May 21 16:16:26 2014
Return-Path: <gcc-bugs-return-452184-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 5787 invoked by alias); 21 May 2014 16:16:26 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 5740 invoked by uid 48); 21 May 2014 16:16:22 -0000
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/61276] warn about possible coding errors with logical not (!)
Date: Wed, 21 May 2014 16:16:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: redi at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status cf_reconfirmed_on everconfirmed
Message-ID: <bug-61276-4-rHT5TBGKS7@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61276-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61276-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg01876.txt.bz2
Content-length: 547
https://gcc.gnu.org/bugzilla/show_bug.cgi?ida276
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2014-05-21
Ever confirmed|0 |1
--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Patch for this one at https://gcc.gnu.org/ml/gcc-patches/2014-05/msg01792.html
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug c/61271] 10 * possible coding error with logical not (!)
2014-05-21 14:01 [Bug c/61271] New: 3 * possible coding error with logical not (!) dcb314 at hotmail dot com
` (3 preceding siblings ...)
2014-05-21 16:12 ` [Bug c/61271] 10 " manu at gcc dot gnu.org
@ 2014-05-22 12:17 ` redi at gcc dot gnu.org
2014-05-26 17:33 ` uros at gcc dot gnu.org
` (15 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: redi at gcc dot gnu.org @ 2014-05-22 12:17 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61271
--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Thu May 22 12:17:15 2014
New Revision: 210804
URL: http://gcc.gnu.org/viewcvs?rev=210804&root=gcc&view=rev
Log:
cp:
PR c/61271
* cp-array-notation.c (cilkplus_an_triplet_types_ok_p): Fix condition.
testsuite:
PR c/61271
* g++.dg/cilk-plus/AN/array_function.cc: New.
Added:
trunk/gcc/testsuite/g++.dg/cilk-plus/AN/array_function.cc
Modified:
trunk/gcc/cp/ChangeLog
trunk/gcc/cp/cp-array-notation.c
trunk/gcc/testsuite/ChangeLog
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug c/61271] 10 * possible coding error with logical not (!)
2014-05-21 14:01 [Bug c/61271] New: 3 * possible coding error with logical not (!) dcb314 at hotmail dot com
` (4 preceding siblings ...)
2014-05-22 12:17 ` redi at gcc dot gnu.org
@ 2014-05-26 17:33 ` uros at gcc dot gnu.org
2014-05-29 8:16 ` uros at gcc dot gnu.org
` (14 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: uros at gcc dot gnu.org @ 2014-05-26 17:33 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61271
--- Comment #9 from uros at gcc dot gnu.org ---
Author: uros
Date: Mon May 26 17:33:09 2014
New Revision: 210937
URL: http://gcc.gnu.org/viewcvs?rev=210937&root=gcc&view=rev
Log:
PR target/61271
* config/i386/i386.c (ix86_rtx_costs)
<case CONST_INT, case CONST, case LABEL_REF, case SYMBOL_REF>:
Fix condition.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/config/i386/i386.c
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug c/61271] 10 * possible coding error with logical not (!)
2014-05-21 14:01 [Bug c/61271] New: 3 * possible coding error with logical not (!) dcb314 at hotmail dot com
` (5 preceding siblings ...)
2014-05-26 17:33 ` uros at gcc dot gnu.org
@ 2014-05-29 8:16 ` uros at gcc dot gnu.org
2014-06-04 8:30 ` manu at gcc dot gnu.org
` (13 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: uros at gcc dot gnu.org @ 2014-05-29 8:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61271
--- Comment #10 from uros at gcc dot gnu.org ---
Author: uros
Date: Thu May 29 08:15:40 2014
New Revision: 211046
URL: http://gcc.gnu.org/viewcvs?rev=211046&root=gcc&view=rev
Log:
Backport from mainline
2014-05-26 Uros Bizjak <ubizjak@gmail.com>
PR target/61271
* config/i386/i386.c (ix86_rtx_costs)
<case CONST_INT, case CONST, case LABEL_REF, case SYMBOL_REF>:
Fix condition.
Modified:
branches/gcc-4_9-branch/gcc/ChangeLog
branches/gcc-4_9-branch/gcc/config/i386/i386.c
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug c/61271] 10 * possible coding error with logical not (!)
2014-05-21 14:01 [Bug c/61271] New: 3 * possible coding error with logical not (!) dcb314 at hotmail dot com
` (6 preceding siblings ...)
2014-05-29 8:16 ` uros at gcc dot gnu.org
@ 2014-06-04 8:30 ` manu at gcc dot gnu.org
2014-08-19 11:36 ` mpolacek at gcc dot gnu.org
` (12 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: manu at gcc dot gnu.org @ 2014-06-04 8:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61271
Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|61276 |49706
--- Comment #11 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Bugzilla should learn to update the blocking list when marking duplicates.
>From gcc-bugs-return-453169-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Jun 04 08:40:45 2014
Return-Path: <gcc-bugs-return-453169-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 30367 invoked by alias); 4 Jun 2014 08:40:45 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 30329 invoked by uid 48); 4 Jun 2014 08:40:41 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/61407] Build errors on latest OS X 10.10 Yosemite with Xcode 6 on GCC 4.8.3
Date: Wed, 04 Jun 2014 08:40:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-61407-4-3TqHJyxwyp@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61407-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61407-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-06/txt/msg00251.txt.bz2
Content-length: 1444
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61407
Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |manu at gcc dot gnu.org
--- Comment #4 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #2)
> (In reply to Andrew Pinski from comment #1)
> > Looks like the Mac OS X's headers are not C99/C++98 compatible at all:
> >
> > /Applications/Xcode6-Beta.app/Contents/Developer/Platforms/MacOSX.platform/
> > Developer/SDKs/MacOSX10.10.sdk/usr/include/Availability.h:174:44: error:
> > missing binary operator before token "("
> > #if defined(__has_feature) &&
> > __has_feature(attribute_availability_with_message)
> > ^
>
> This error is correct because with the preprocessor && does not short
> cutting if the first operand is true.
If this is true, it sucks. Short-cutting simplifies writing such conditions.
But then the CPP manual is wrong:
https://gcc.gnu.org/onlinedocs/gcc-4.9.0/cpp/If.html#If
"Arithmetic operators for addition, subtraction, multiplication, division,
bitwise operations, shifts, comparisons, and logical operations (&& and ||).
The latter two obey the usual short-circuiting rules of standard C. "
>From gcc-bugs-return-453170-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Jun 04 08:43:53 2014
Return-Path: <gcc-bugs-return-453170-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 32569 invoked by alias); 4 Jun 2014 08:43:53 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 32512 invoked by uid 55); 4 Jun 2014 08:43:49 -0000
From: "ro at CeBiTec dot Uni-Bielefeld.DE" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/61320] [4.10 regression] ICE in jcf-parse.c:1622 (parse_class_file
Date: Wed, 04 Jun 2014 08:43:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: bootstrap
X-Bugzilla-Version: 4.10.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ro at CeBiTec dot Uni-Bielefeld.DE
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.10.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61320-4-olNqJK614B@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61320-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61320-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-06/txt/msg00252.txt.bz2
Content-length: 996
https://gcc.gnu.org/bugzilla/show_bug.cgi?ida320
--- Comment #22 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #21 from Thomas Preud'homme <thomas.preudhomme at arm dot com> ---
> (In reply to ro@CeBiTec.Uni-Bielefeld.DE from comment #19)
>>
>> I've now regtested that patch on sparc-sun-solaris2.11 (compared to a
>> bootstrap without java before) and i386-pc-solaris2.11. No regressions,
>> but gcc.c-torture/execute/bswap-2.c is still failing on sparc.
>
> There is a patch for bswap-2.c ready [0]. I'm just waiting for Andreas to
> confirm me it works for him on m68k. I'd be interested in knowing if that
> solves your issue as well.
>
> [0] https://gcc.gnu.org/ml/gcc-patches/2014-05/msg02519.html
I'm giving both patches combined a try right now, though SPARC bootstrap
will take 7+ hours to complete.
Please remember to add proposed patches to the URL field of the PR,
otherwise they are easily overlooked.
Thanks.
Rainer
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug c/61271] 10 * possible coding error with logical not (!)
2014-05-21 14:01 [Bug c/61271] New: 3 * possible coding error with logical not (!) dcb314 at hotmail dot com
` (7 preceding siblings ...)
2014-06-04 8:30 ` manu at gcc dot gnu.org
@ 2014-08-19 11:36 ` mpolacek at gcc dot gnu.org
2014-08-22 19:41 ` mpolacek at gcc dot gnu.org
` (11 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-08-19 11:36 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61271
--- Comment #12 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Tue Aug 19 11:35:39 2014
New Revision: 214142
URL: https://gcc.gnu.org/viewcvs?rev=214142&root=gcc&view=rev
Log:
PR c/61271
* cgraphunit.c (handle_alias_pairs): Fix condition.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/cgraphunit.c
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug c/61271] 10 * possible coding error with logical not (!)
2014-05-21 14:01 [Bug c/61271] New: 3 * possible coding error with logical not (!) dcb314 at hotmail dot com
` (8 preceding siblings ...)
2014-08-19 11:36 ` mpolacek at gcc dot gnu.org
@ 2014-08-22 19:41 ` mpolacek at gcc dot gnu.org
2014-08-26 9:21 ` mpolacek at gcc dot gnu.org
` (10 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-08-22 19:41 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61271
--- Comment #13 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Fri Aug 22 19:40:28 2014
New Revision: 214359
URL: https://gcc.gnu.org/viewcvs?rev=214359&root=gcc&view=rev
Log:
PR c/61271
* ira-color.c (coalesced_pseudo_reg_slot_compare): Wrap LHS of
a comparison in parens.
* lra-spills.c (pseudo_reg_slot_compare): Wrap LHS of a comparison
in parens.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/ira-color.c
trunk/gcc/lra-spills.c
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug c/61271] 10 * possible coding error with logical not (!)
2014-05-21 14:01 [Bug c/61271] New: 3 * possible coding error with logical not (!) dcb314 at hotmail dot com
` (9 preceding siblings ...)
2014-08-22 19:41 ` mpolacek at gcc dot gnu.org
@ 2014-08-26 9:21 ` mpolacek at gcc dot gnu.org
2014-08-26 9:26 ` mpolacek at gcc dot gnu.org
` (9 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-08-26 9:21 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61271
--- Comment #14 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Tue Aug 26 09:21:18 2014
New Revision: 214493
URL: https://gcc.gnu.org/viewcvs?rev=214493&root=gcc&view=rev
Log:
PR c/61271
* tree-vectorizer.h (LOOP_REQUIRES_VERSIONING_FOR_ALIGNMENT,
LOOP_REQUIRES_VERSIONING_FOR_ALIAS): Wrap in parens.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/tree-vectorizer.h
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug c/61271] 10 * possible coding error with logical not (!)
2014-05-21 14:01 [Bug c/61271] New: 3 * possible coding error with logical not (!) dcb314 at hotmail dot com
` (10 preceding siblings ...)
2014-08-26 9:21 ` mpolacek at gcc dot gnu.org
@ 2014-08-26 9:26 ` mpolacek at gcc dot gnu.org
2014-08-26 9:31 ` mpolacek at gcc dot gnu.org
` (8 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-08-26 9:26 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61271
--- Comment #15 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Tue Aug 26 09:25:37 2014
New Revision: 214494
URL: https://gcc.gnu.org/viewcvs?rev=214494&root=gcc&view=rev
Log:
PR c/61271
* tree-vectorizer.h (LOOP_REQUIRES_VERSIONING_FOR_ALIGNMENT,
LOOP_REQUIRES_VERSIONING_FOR_ALIAS): Wrap in parens.
Modified:
branches/gcc-4_9-branch/gcc/ChangeLog
branches/gcc-4_9-branch/gcc/tree-vectorizer.h
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug c/61271] 10 * possible coding error with logical not (!)
2014-05-21 14:01 [Bug c/61271] New: 3 * possible coding error with logical not (!) dcb314 at hotmail dot com
` (11 preceding siblings ...)
2014-08-26 9:26 ` mpolacek at gcc dot gnu.org
@ 2014-08-26 9:31 ` mpolacek at gcc dot gnu.org
2014-08-26 9:31 ` mpolacek at gcc dot gnu.org
` (7 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-08-26 9:31 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61271
Marek Polacek <mpolacek at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |mpolacek at gcc dot gnu.org
Assignee|unassigned at gcc dot gnu.org |mpolacek at gcc dot gnu.org
Target Milestone|--- |5.0
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug c/61271] 10 * possible coding error with logical not (!)
2014-05-21 14:01 [Bug c/61271] New: 3 * possible coding error with logical not (!) dcb314 at hotmail dot com
` (12 preceding siblings ...)
2014-08-26 9:31 ` mpolacek at gcc dot gnu.org
@ 2014-08-26 9:31 ` mpolacek at gcc dot gnu.org
2014-08-26 9:35 ` mpolacek at gcc dot gnu.org
` (6 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-08-26 9:31 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61271
--- Comment #16 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Tue Aug 26 09:30:29 2014
New Revision: 214495
URL: https://gcc.gnu.org/viewcvs?rev=214495&root=gcc&view=rev
Log:
PR c/61271
* tree-vectorizer.h (LOOP_REQUIRES_VERSIONING_FOR_ALIGNMENT,
LOOP_REQUIRES_VERSIONING_FOR_ALIAS): Wrap in parens.
Modified:
branches/gcc-4_8-branch/gcc/ChangeLog
branches/gcc-4_8-branch/gcc/tree-vectorizer.h
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug c/61271] 10 * possible coding error with logical not (!)
2014-05-21 14:01 [Bug c/61271] New: 3 * possible coding error with logical not (!) dcb314 at hotmail dot com
` (13 preceding siblings ...)
2014-08-26 9:31 ` mpolacek at gcc dot gnu.org
@ 2014-08-26 9:35 ` mpolacek at gcc dot gnu.org
2014-08-26 14:25 ` mpolacek at gcc dot gnu.org
` (5 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-08-26 9:35 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61271
--- Comment #17 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Tue Aug 26 09:35:10 2014
New Revision: 214496
URL: https://gcc.gnu.org/viewcvs?rev=214496&root=gcc&view=rev
Log:
PR c/61271
* expr.c (is_aligning_offset): Remove logical not.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/expr.c
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug c/61271] 10 * possible coding error with logical not (!)
2014-05-21 14:01 [Bug c/61271] New: 3 * possible coding error with logical not (!) dcb314 at hotmail dot com
` (14 preceding siblings ...)
2014-08-26 9:35 ` mpolacek at gcc dot gnu.org
@ 2014-08-26 14:25 ` mpolacek at gcc dot gnu.org
2014-09-01 9:32 ` mpolacek at gcc dot gnu.org
` (4 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-08-26 14:25 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61271
--- Comment #18 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Tue Aug 26 14:24:15 2014
New Revision: 214523
URL: https://gcc.gnu.org/viewcvs?rev=214523&root=gcc&view=rev
Log:
PR c/61271
* sel-sched-ir.c (make_regions_from_the_rest): Fix condition.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/sel-sched-ir.c
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug c/61271] 10 * possible coding error with logical not (!)
2014-05-21 14:01 [Bug c/61271] New: 3 * possible coding error with logical not (!) dcb314 at hotmail dot com
` (15 preceding siblings ...)
2014-08-26 14:25 ` mpolacek at gcc dot gnu.org
@ 2014-09-01 9:32 ` mpolacek at gcc dot gnu.org
2014-09-01 10:07 ` mpolacek at gcc dot gnu.org
` (3 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-09-01 9:32 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61271
Marek Polacek <mpolacek at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #19 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
All the issues mentioned in #c1 a #c2 are fixed. What remains is now tracked
in PR62270 (Fortran FE).
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug c/61271] 10 * possible coding error with logical not (!)
2014-05-21 14:01 [Bug c/61271] New: 3 * possible coding error with logical not (!) dcb314 at hotmail dot com
` (16 preceding siblings ...)
2014-09-01 9:32 ` mpolacek at gcc dot gnu.org
@ 2014-09-01 10:07 ` mpolacek at gcc dot gnu.org
2014-09-01 10:12 ` mpolacek at gcc dot gnu.org
` (2 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-09-01 10:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61271
--- Comment #20 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Mon Sep 1 10:07:05 2014
New Revision: 214782
URL: https://gcc.gnu.org/viewcvs?rev=214782&root=gcc&view=rev
Log:
PR c/61271
* cgraphunit.c (handle_alias_pairs): Fix condition.
Modified:
branches/gcc-4_9-branch/gcc/ChangeLog
branches/gcc-4_9-branch/gcc/cgraphunit.c
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug c/61271] 10 * possible coding error with logical not (!)
2014-05-21 14:01 [Bug c/61271] New: 3 * possible coding error with logical not (!) dcb314 at hotmail dot com
` (17 preceding siblings ...)
2014-09-01 10:07 ` mpolacek at gcc dot gnu.org
@ 2014-09-01 10:12 ` mpolacek at gcc dot gnu.org
2014-09-01 10:15 ` mpolacek at gcc dot gnu.org
2014-09-01 10:17 ` mpolacek at gcc dot gnu.org
20 siblings, 0 replies; 22+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-09-01 10:12 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61271
--- Comment #21 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Mon Sep 1 10:12:00 2014
New Revision: 214783
URL: https://gcc.gnu.org/viewcvs?rev=214783&root=gcc&view=rev
Log:
PR c/61271
* cgraphunit.c (handle_alias_pairs): Fix condition.
Modified:
branches/gcc-4_8-branch/gcc/ChangeLog
branches/gcc-4_8-branch/gcc/cgraphunit.c
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug c/61271] 10 * possible coding error with logical not (!)
2014-05-21 14:01 [Bug c/61271] New: 3 * possible coding error with logical not (!) dcb314 at hotmail dot com
` (18 preceding siblings ...)
2014-09-01 10:12 ` mpolacek at gcc dot gnu.org
@ 2014-09-01 10:15 ` mpolacek at gcc dot gnu.org
2014-09-01 10:17 ` mpolacek at gcc dot gnu.org
20 siblings, 0 replies; 22+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-09-01 10:15 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61271
--- Comment #22 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Mon Sep 1 10:14:22 2014
New Revision: 214784
URL: https://gcc.gnu.org/viewcvs?rev=214784&root=gcc&view=rev
Log:
PR c/61271
* expr.c (is_aligning_offset): Remove logical not.
Modified:
branches/gcc-4_9-branch/gcc/ChangeLog
branches/gcc-4_9-branch/gcc/expr.c
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug c/61271] 10 * possible coding error with logical not (!)
2014-05-21 14:01 [Bug c/61271] New: 3 * possible coding error with logical not (!) dcb314 at hotmail dot com
` (19 preceding siblings ...)
2014-09-01 10:15 ` mpolacek at gcc dot gnu.org
@ 2014-09-01 10:17 ` mpolacek at gcc dot gnu.org
20 siblings, 0 replies; 22+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-09-01 10:17 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61271
--- Comment #23 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Mon Sep 1 10:16:43 2014
New Revision: 214785
URL: https://gcc.gnu.org/viewcvs?rev=214785&root=gcc&view=rev
Log:
PR c/61271
* expr.c (is_aligning_offset): Remove logical not.
Modified:
branches/gcc-4_8-branch/gcc/ChangeLog
branches/gcc-4_8-branch/gcc/expr.c
^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2014-09-01 10:17 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-21 14:01 [Bug c/61271] New: 3 * possible coding error with logical not (!) dcb314 at hotmail dot com
2014-05-21 14:20 ` [Bug c/61271] " dcb314 at hotmail dot com
2014-05-21 14:31 ` [Bug c/61271] 6 " redi at gcc dot gnu.org
2014-05-21 14:33 ` dcb314 at hotmail dot com
2014-05-21 16:12 ` [Bug c/61271] 10 " manu at gcc dot gnu.org
2014-05-22 12:17 ` redi at gcc dot gnu.org
2014-05-26 17:33 ` uros at gcc dot gnu.org
2014-05-29 8:16 ` uros at gcc dot gnu.org
2014-06-04 8:30 ` manu at gcc dot gnu.org
2014-08-19 11:36 ` mpolacek at gcc dot gnu.org
2014-08-22 19:41 ` mpolacek at gcc dot gnu.org
2014-08-26 9:21 ` mpolacek at gcc dot gnu.org
2014-08-26 9:26 ` mpolacek at gcc dot gnu.org
2014-08-26 9:31 ` mpolacek at gcc dot gnu.org
2014-08-26 9:31 ` mpolacek at gcc dot gnu.org
2014-08-26 9:35 ` mpolacek at gcc dot gnu.org
2014-08-26 14:25 ` mpolacek at gcc dot gnu.org
2014-09-01 9:32 ` mpolacek at gcc dot gnu.org
2014-09-01 10:07 ` mpolacek at gcc dot gnu.org
2014-09-01 10:12 ` mpolacek at gcc dot gnu.org
2014-09-01 10:15 ` mpolacek at gcc dot gnu.org
2014-09-01 10:17 ` mpolacek at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).