public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug sanitizer/61272] New: [UBSAN] ICE in is_ubsan_builtin_p(tree_node*), gcc/ubsan.c:534
@ 2014-05-21 14:34 burnus at gcc dot gnu.org
2014-05-21 14:53 ` [Bug sanitizer/61272] " mpolacek at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: burnus at gcc dot gnu.org @ 2014-05-21 14:34 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61272
Bug ID: 61272
Summary: [UBSAN] ICE in is_ubsan_builtin_p(tree_node*),
gcc/ubsan.c:534
Product: gcc
Version: 4.10.0
Status: UNCONFIRMED
Keywords: ice-on-invalid-code
Severity: normal
Priority: P3
Component: sanitizer
Assignee: unassigned at gcc dot gnu.org
Reporter: burnus at gcc dot gnu.org
CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
jakub at gcc dot gnu.org, kcc at gcc dot gnu.org,
mpolacek at gcc dot gnu.org
Created attachment 32841
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=32841&action=edit
Compile with g++ -S -std=c++11 -fsanitize=undefined
Compiling the attached test case (invalid code) with
g++ -S -std=c++11 -fsanitize=undefined test39.ii
ICEs with:
test39.ii:26:156: required from ‘struct
std::__gnu_cxx::_Vector_base<std::__gnu_cxx::Point2d<int>,
std::allocator<std::__gnu_cxx::Point2d<int> > >’
test39.ii:27:78: required from ‘class
std::__gnu_cxx::vector<std::__gnu_cxx::Point2d<int> >’
test39.ii:30:33: required from here
in is_ubsan_builtin_p, at ubsan.c:534
template < typename _Alloc > struct __alloc_traits:std::allocator_traits <
_Alloc >
^
0xc07468 is_ubsan_builtin_p(tree_node*)
../../gcc/ubsan.c:534
0x6ab586 dump_expr
../../gcc/cp/error.c:2022
0x6a8240 dump_type
../../gcc/cp/error.c:547
>From gcc-bugs-return-452168-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed May 21 14:41:20 2014
Return-Path: <gcc-bugs-return-452168-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 3828 invoked by alias); 21 May 2014 14:41:20 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 3786 invoked by uid 48); 21 May 2014 14:41:16 -0000
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/61271] 10 * possible coding error with logical not (!)
Date: Wed, 21 May 2014 14:41:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: redi at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61271-4-T6CK4cDvpr@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61271-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61271-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg01860.txt.bz2
Content-length: 815
https://gcc.gnu.org/bugzilla/show_bug.cgi?ida271
--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to David Binderman from comment #0)
> 3.
>
> ../../src/trunk/gcc/cp/cp-array-notation.c:1420:7: warning: logical not is
> only applied to the left hand side of this comparison
> [-Wlogical-not-parentheses]
>
> Source code is
>
> if (!TREE_CODE (type) == FUNCTION_TYPE)
> {
> error_at (loc, "array notation cannot be used with function type");
> return false;
> }
>
> Maybe
>
> if (TREE_CODE (type) == FUNCTION_TYPE)
> {
> error_at (loc, "array notation cannot be used with function type");
> return false;
> }
>
> was intended.
Indeed. Here's a testcase for that one, which gives an ICE:
void func() { }
int main()
{
func[1:2:3];
}
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug sanitizer/61272] [UBSAN] ICE in is_ubsan_builtin_p(tree_node*), gcc/ubsan.c:534
2014-05-21 14:34 [Bug sanitizer/61272] New: [UBSAN] ICE in is_ubsan_builtin_p(tree_node*), gcc/ubsan.c:534 burnus at gcc dot gnu.org
@ 2014-05-21 14:53 ` mpolacek at gcc dot gnu.org
2014-05-21 15:39 ` mpolacek at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-05-21 14:53 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61272
Marek Polacek <mpolacek at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2014-05-21
Target Milestone|--- |4.10.0
Ever confirmed|0 |1
--- Comment #1 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Confirmed.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug sanitizer/61272] [UBSAN] ICE in is_ubsan_builtin_p(tree_node*), gcc/ubsan.c:534
2014-05-21 14:34 [Bug sanitizer/61272] New: [UBSAN] ICE in is_ubsan_builtin_p(tree_node*), gcc/ubsan.c:534 burnus at gcc dot gnu.org
2014-05-21 14:53 ` [Bug sanitizer/61272] " mpolacek at gcc dot gnu.org
@ 2014-05-21 15:39 ` mpolacek at gcc dot gnu.org
2014-05-21 18:50 ` mpolacek at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-05-21 15:39 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61272
--- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
I think easiest would be
--- a/gcc/ubsan.c
+++ b/gcc/ubsan.c
@@ -531,9 +538,9 @@ ubsan_instrument_unreachable (location_t loc)
bool
is_ubsan_builtin_p (tree t)
{
- gcc_checking_assert (TREE_CODE (t) == FUNCTION_DECL);
- return strncmp (IDENTIFIER_POINTER (DECL_NAME (t)),
- "__builtin___ubsan_", 18) == 0;
+ return TREE_CODE (t) == FUNCTION_DECL
+ && strncmp (IDENTIFIER_POINTER (DECL_NAME (t)),
+ "__builtin___ubsan_", 18) == 0;
}
/* Expand UBSAN_NULL internal call. */
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug sanitizer/61272] [UBSAN] ICE in is_ubsan_builtin_p(tree_node*), gcc/ubsan.c:534
2014-05-21 14:34 [Bug sanitizer/61272] New: [UBSAN] ICE in is_ubsan_builtin_p(tree_node*), gcc/ubsan.c:534 burnus at gcc dot gnu.org
2014-05-21 14:53 ` [Bug sanitizer/61272] " mpolacek at gcc dot gnu.org
2014-05-21 15:39 ` mpolacek at gcc dot gnu.org
@ 2014-05-21 18:50 ` mpolacek at gcc dot gnu.org
2014-05-21 19:08 ` mpolacek at gcc dot gnu.org
2014-05-21 19:09 ` mpolacek at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-05-21 18:50 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61272
Marek Polacek <mpolacek at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |mpolacek at gcc dot gnu.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug sanitizer/61272] [UBSAN] ICE in is_ubsan_builtin_p(tree_node*), gcc/ubsan.c:534
2014-05-21 14:34 [Bug sanitizer/61272] New: [UBSAN] ICE in is_ubsan_builtin_p(tree_node*), gcc/ubsan.c:534 burnus at gcc dot gnu.org
` (2 preceding siblings ...)
2014-05-21 18:50 ` mpolacek at gcc dot gnu.org
@ 2014-05-21 19:08 ` mpolacek at gcc dot gnu.org
2014-05-21 19:09 ` mpolacek at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-05-21 19:08 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61272
--- Comment #3 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Wed May 21 19:07:30 2014
New Revision: 210723
URL: http://gcc.gnu.org/viewcvs?rev=210723&root=gcc&view=rev
Log:
PR sanitizer/61272
* ubsan.c (is_ubsan_builtin_p): Turn assert into a condition.
* g++.dg/ubsan/pr61272.C: New test.
Added:
trunk/gcc/testsuite/g++.dg/ubsan/pr61272.C
Modified:
trunk/gcc/ChangeLog
trunk/gcc/testsuite/ChangeLog
trunk/gcc/ubsan.c
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug sanitizer/61272] [UBSAN] ICE in is_ubsan_builtin_p(tree_node*), gcc/ubsan.c:534
2014-05-21 14:34 [Bug sanitizer/61272] New: [UBSAN] ICE in is_ubsan_builtin_p(tree_node*), gcc/ubsan.c:534 burnus at gcc dot gnu.org
` (3 preceding siblings ...)
2014-05-21 19:08 ` mpolacek at gcc dot gnu.org
@ 2014-05-21 19:09 ` mpolacek at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-05-21 19:09 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61272
Marek Polacek <mpolacek at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-05-21 19:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-21 14:34 [Bug sanitizer/61272] New: [UBSAN] ICE in is_ubsan_builtin_p(tree_node*), gcc/ubsan.c:534 burnus at gcc dot gnu.org
2014-05-21 14:53 ` [Bug sanitizer/61272] " mpolacek at gcc dot gnu.org
2014-05-21 15:39 ` mpolacek at gcc dot gnu.org
2014-05-21 18:50 ` mpolacek at gcc dot gnu.org
2014-05-21 19:08 ` mpolacek at gcc dot gnu.org
2014-05-21 19:09 ` mpolacek at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).